* [U-Boot] [PATCH] pci: Device scanning range fix.
@ 2016-04-18 8:02 Yoshinori Sato
2016-04-23 15:12 ` Simon Glass
2016-04-25 6:14 ` [U-Boot] [PATCH v2] " Yoshinori Sato
0 siblings, 2 replies; 8+ messages in thread
From: Yoshinori Sato @ 2016-04-18 8:02 UTC (permalink / raw)
To: u-boot
Don't lookup pci device 1f.7
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
---
drivers/pci/pci-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
index c7fbf7b..32590ce 100644
--- a/drivers/pci/pci-uclass.c
+++ b/drivers/pci/pci-uclass.c
@@ -682,7 +682,7 @@ int pci_bind_bus_devices(struct udevice *bus)
found_multi = false;
end = PCI_BDF(bus->seq, PCI_MAX_PCI_DEVICES - 1,
PCI_MAX_PCI_FUNCTIONS - 1);
- for (bdf = PCI_BDF(bus->seq, 0, 0); bdf < end;
+ for (bdf = PCI_BDF(bus->seq, 0, 0); bdf <= end;
bdf += PCI_BDF(0, 0, 1)) {
struct pci_child_platdata *pplat;
struct udevice *dev;
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] pci: Device scanning range fix.
2016-04-18 8:02 [U-Boot] [PATCH] pci: Device scanning range fix Yoshinori Sato
@ 2016-04-23 15:12 ` Simon Glass
2016-04-25 6:14 ` [U-Boot] [PATCH v2] " Yoshinori Sato
1 sibling, 0 replies; 8+ messages in thread
From: Simon Glass @ 2016-04-23 15:12 UTC (permalink / raw)
To: u-boot
Hi Yoshinori,
On 18 April 2016 at 02:02, Yoshinori Sato <ysato@users.sourceforge.jp> wrote:
> Don't lookup pci device 1f.7
>
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
> drivers/pci/pci-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
> index c7fbf7b..32590ce 100644
> --- a/drivers/pci/pci-uclass.c
> +++ b/drivers/pci/pci-uclass.c
> @@ -682,7 +682,7 @@ int pci_bind_bus_devices(struct udevice *bus)
> found_multi = false;
> end = PCI_BDF(bus->seq, PCI_MAX_PCI_DEVICES - 1,
> PCI_MAX_PCI_FUNCTIONS - 1);
> - for (bdf = PCI_BDF(bus->seq, 0, 0); bdf < end;
> + for (bdf = PCI_BDF(bus->seq, 0, 0); bdf <= end;
> bdf += PCI_BDF(0, 0, 1)) {
> struct pci_child_platdata *pplat;
> struct udevice *dev;
The patch looks good thank you. But your commit message seem the
opposite of what this patch does. Can you update it in v2, or explain
it better?
Regards,
Simon
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2] pci: Device scanning range fix.
2016-04-18 8:02 [U-Boot] [PATCH] pci: Device scanning range fix Yoshinori Sato
2016-04-23 15:12 ` Simon Glass
@ 2016-04-25 6:14 ` Yoshinori Sato
2016-04-25 6:27 ` Bin Meng
2016-04-25 6:41 ` [U-Boot] [PATCH v3] " Yoshinori Sato
1 sibling, 2 replies; 8+ messages in thread
From: Yoshinori Sato @ 2016-04-25 6:14 UTC (permalink / raw)
To: u-boot
The terminal condition in the area where a PCI device is scanned is wrong,
and 1f.7 isn't scanned.
Changes v2:
- update commit message.
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
---
drivers/pci/pci-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
index c7fbf7b..32590ce 100644
--- a/drivers/pci/pci-uclass.c
+++ b/drivers/pci/pci-uclass.c
@@ -682,7 +682,7 @@ int pci_bind_bus_devices(struct udevice *bus)
found_multi = false;
end = PCI_BDF(bus->seq, PCI_MAX_PCI_DEVICES - 1,
PCI_MAX_PCI_FUNCTIONS - 1);
- for (bdf = PCI_BDF(bus->seq, 0, 0); bdf < end;
+ for (bdf = PCI_BDF(bus->seq, 0, 0); bdf <= end;
bdf += PCI_BDF(0, 0, 1)) {
struct pci_child_platdata *pplat;
struct udevice *dev;
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2] pci: Device scanning range fix.
2016-04-25 6:14 ` [U-Boot] [PATCH v2] " Yoshinori Sato
@ 2016-04-25 6:27 ` Bin Meng
2016-04-25 6:38 ` Yoshinori Sato
2016-04-25 6:41 ` [U-Boot] [PATCH v3] " Yoshinori Sato
1 sibling, 1 reply; 8+ messages in thread
From: Bin Meng @ 2016-04-25 6:27 UTC (permalink / raw)
To: u-boot
Hi Yoshinori,
On Mon, Apr 25, 2016 at 2:14 PM, Yoshinori Sato
<ysato@users.sourceforge.jp> wrote:
> The terminal condition in the area where a PCI device is scanned is wrong,
> and 1f.7 isn't scanned.
>
> Changes v2:
> - update commit message.
Please hide this "changes v2" from the commit message.
Also nits: please remove the ending period in the commit title ..
>
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
> drivers/pci/pci-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
> index c7fbf7b..32590ce 100644
> --- a/drivers/pci/pci-uclass.c
> +++ b/drivers/pci/pci-uclass.c
> @@ -682,7 +682,7 @@ int pci_bind_bus_devices(struct udevice *bus)
> found_multi = false;
> end = PCI_BDF(bus->seq, PCI_MAX_PCI_DEVICES - 1,
> PCI_MAX_PCI_FUNCTIONS - 1);
> - for (bdf = PCI_BDF(bus->seq, 0, 0); bdf < end;
> + for (bdf = PCI_BDF(bus->seq, 0, 0); bdf <= end;
> bdf += PCI_BDF(0, 0, 1)) {
> struct pci_child_platdata *pplat;
> struct udevice *dev;
> --
Regards,
Bin
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2] pci: Device scanning range fix.
2016-04-25 6:27 ` Bin Meng
@ 2016-04-25 6:38 ` Yoshinori Sato
0 siblings, 0 replies; 8+ messages in thread
From: Yoshinori Sato @ 2016-04-25 6:38 UTC (permalink / raw)
To: u-boot
On Mon, 25 Apr 2016 15:27:19 +0900,
Bin Meng wrote:
>
> Hi Yoshinori,
>
> On Mon, Apr 25, 2016 at 2:14 PM, Yoshinori Sato
> <ysato@users.sourceforge.jp> wrote:
> > The terminal condition in the area where a PCI device is scanned is wrong,
> > and 1f.7 isn't scanned.
> >
> > Changes v2:
> > - update commit message.
>
> Please hide this "changes v2" from the commit message.
>
> Also nits: please remove the ending period in the commit title ..
OK.
Thanks comment.
> >
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> > ---
> > drivers/pci/pci-uclass.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
> > index c7fbf7b..32590ce 100644
> > --- a/drivers/pci/pci-uclass.c
> > +++ b/drivers/pci/pci-uclass.c
> > @@ -682,7 +682,7 @@ int pci_bind_bus_devices(struct udevice *bus)
> > found_multi = false;
> > end = PCI_BDF(bus->seq, PCI_MAX_PCI_DEVICES - 1,
> > PCI_MAX_PCI_FUNCTIONS - 1);
> > - for (bdf = PCI_BDF(bus->seq, 0, 0); bdf < end;
> > + for (bdf = PCI_BDF(bus->seq, 0, 0); bdf <= end;
> > bdf += PCI_BDF(0, 0, 1)) {
> > struct pci_child_platdata *pplat;
> > struct udevice *dev;
> > --
>
> Regards,
> Bin
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v3] pci: Device scanning range fix
2016-04-25 6:14 ` [U-Boot] [PATCH v2] " Yoshinori Sato
2016-04-25 6:27 ` Bin Meng
@ 2016-04-25 6:41 ` Yoshinori Sato
2016-04-25 7:07 ` Bin Meng
2016-04-26 0:17 ` [U-Boot] [U-Boot,v3] " Tom Rini
1 sibling, 2 replies; 8+ messages in thread
From: Yoshinori Sato @ 2016-04-25 6:41 UTC (permalink / raw)
To: u-boot
The terminal condition in the area where a PCI device is scanned is wrong,
and 1f.7 isn't scanned.
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
---
drivers/pci/pci-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
index c7fbf7b..32590ce 100644
--- a/drivers/pci/pci-uclass.c
+++ b/drivers/pci/pci-uclass.c
@@ -682,7 +682,7 @@ int pci_bind_bus_devices(struct udevice *bus)
found_multi = false;
end = PCI_BDF(bus->seq, PCI_MAX_PCI_DEVICES - 1,
PCI_MAX_PCI_FUNCTIONS - 1);
- for (bdf = PCI_BDF(bus->seq, 0, 0); bdf < end;
+ for (bdf = PCI_BDF(bus->seq, 0, 0); bdf <= end;
bdf += PCI_BDF(0, 0, 1)) {
struct pci_child_platdata *pplat;
struct udevice *dev;
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v3] pci: Device scanning range fix
2016-04-25 6:41 ` [U-Boot] [PATCH v3] " Yoshinori Sato
@ 2016-04-25 7:07 ` Bin Meng
2016-04-26 0:17 ` [U-Boot] [U-Boot,v3] " Tom Rini
1 sibling, 0 replies; 8+ messages in thread
From: Bin Meng @ 2016-04-25 7:07 UTC (permalink / raw)
To: u-boot
On Mon, Apr 25, 2016 at 2:41 PM, Yoshinori Sato
<ysato@users.sourceforge.jp> wrote:
> The terminal condition in the area where a PCI device is scanned is wrong,
> and 1f.7 isn't scanned.
>
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
> drivers/pci/pci-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [U-Boot,v3] pci: Device scanning range fix
2016-04-25 6:41 ` [U-Boot] [PATCH v3] " Yoshinori Sato
2016-04-25 7:07 ` Bin Meng
@ 2016-04-26 0:17 ` Tom Rini
1 sibling, 0 replies; 8+ messages in thread
From: Tom Rini @ 2016-04-26 0:17 UTC (permalink / raw)
To: u-boot
On Mon, Apr 25, 2016 at 03:41:01PM +0900, Yoshinori Sato wrote:
> The terminal condition in the area where a PCI device is scanned is wrong,
> and 1f.7 isn't scanned.
>
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160425/8ea09141/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-04-26 0:17 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-18 8:02 [U-Boot] [PATCH] pci: Device scanning range fix Yoshinori Sato
2016-04-23 15:12 ` Simon Glass
2016-04-25 6:14 ` [U-Boot] [PATCH v2] " Yoshinori Sato
2016-04-25 6:27 ` Bin Meng
2016-04-25 6:38 ` Yoshinori Sato
2016-04-25 6:41 ` [U-Boot] [PATCH v3] " Yoshinori Sato
2016-04-25 7:07 ` Bin Meng
2016-04-26 0:17 ` [U-Boot] [U-Boot,v3] " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox