U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal via U-Boot <u-boot@lists.u-boot-project.org>
To: Ronan Dalton <ronan.dalton@alliedtelesis.co.nz>
Cc: u-boot@lists.denx.de,
	 Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	 Michael Trimarchi <michael@amarulasolutions.com>,
	 Chris Packham <chris.packham@alliedtelesis.co.nz>,
	 Aryan Srivastava <aryan.srivastava@alliedtelesis.co.nz>
Subject: Re: [PATCH] mtd: nand: pxa3xx: Fallback to 1-bit ECC when chip requirement is zero
Date: Fri, 24 Jul 2026 11:44:16 +0200	[thread overview]
Message-ID: <87y0f0rabz.fsf@bootlin.com> (raw)
In-Reply-To: <20260624041243.1045912-2-ronan.dalton@alliedtelesis.co.nz> (Ronan Dalton's message of "Wed, 24 Jun 2026 16:12:44 +1200")

Hi Ronan,

> Currently there is no fallback condition for when a NAND chip connected
> reports an ECC requirement of zero and no value is specified in the DTS.
> When this happens, pxa_ecc_init attempts to find a match, but fails with
> the following error message:
>
>   ECC strength 0 at page size N is not supported
>
> Linux already has a fallback case for this scenario.
>
> Make u-boot match the Linux behavior by triggering the fallback when the
> ECC strength requirement reported by the chip is zero. Changing && to ||
> is sufficient to make the behavior equivalent.
>
> Signed-off-by: Ronan Dalton <ronan.dalton@alliedtelesis.co.nz>
> Cc: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Cc: Aryan Srivastava <aryan.srivastava@alliedtelesis.co.nz>

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

      parent reply	other threads:[~2026-07-24 14:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-24  4:12 [PATCH] mtd: nand: pxa3xx: Fallback to 1-bit ECC when chip requirement is zero Ronan Dalton
2026-07-23  3:56 ` Ronan Dalton
2026-07-24  9:44 ` Miquel Raynal via U-Boot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0f0rabz.fsf@bootlin.com \
    --to=u-boot@lists.u-boot-project.org \
    --cc=aryan.srivastava@alliedtelesis.co.nz \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=michael@amarulasolutions.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=ronan.dalton@alliedtelesis.co.nz \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox