From: Rasmus Villemoes <ravi@prevas.dk>
To: Peng Fan <peng.fan@oss.nxp.com>
Cc: alice.guo@oss.nxp.com, "NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
u-boot@lists.denx.de, "Christoph Stoidner" <c.stoidner@phytec.de>,
upstream@lists.phytec.de, "Joseph Guo" <qijian.guo@nxp.com>,
"Stefano Babic" <sbabic@nabladev.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Tom Rini" <trini@konsulko.com>, "Peng Fan" <peng.fan@nxp.com>,
"Ye Li" <ye.li@nxp.com>,
"Ranjani Vaidyanathan" <ranjani.vaidyanathan@nxp.com>,
"Ji Luo" <ji.luo@nxp.com>, "Marek Vasut" <marex@nabladev.com>,
"Jacky Bai" <ping.bai@nxp.com>,
"Stefan Roese" <stefan.roese@mailbox.org>,
"Marek Vasut" <marek.vasut+renesas@mailbox.org>,
"David Zang" <davidzangcs@gmail.com>,
"Simon Glass" <sjg@chromium.org>,
"João Paulo Gonçalves" <joao.goncalves@toradex.com>,
"Primoz Fiser" <primoz.fiser@norik.com>,
"Frieder Schrempf" <frieder.schrempf@kontron.de>,
"Jérémie Dautheribes (Schneider Electric)"
<jeremie.dautheribes@bootlin.com>,
"Mathieu Othacehe" <m.othacehe@gmail.com>,
"Francesco Dolcini" <francesco.dolcini@toradex.com>,
"Jindong Yue" <jindong.yue@nxp.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Max Krummenacher" <max.krummenacher@toradex.com>,
"Ernest Van Hoecke" <ernest.vanhoecke@toradex.com>,
"Emanuele Ghidoli" <emanuele.ghidoli@toradex.com>,
"Alice Guo" <alice.guo@nxp.com>
Subject: Re: [PATCH v1 01/10] imx: Add helper to get watchdog base address from DT alias
Date: Thu, 12 Mar 2026 10:52:27 +0100 [thread overview]
Message-ID: <87y0jxpe78.fsf@prevas.dk> (raw)
In-Reply-To: <abJol9LRGVDhfAnO@shlinux89> (Peng Fan's message of "Thu, 12 Mar 2026 15:17:43 +0800")
On Thu, Mar 12 2026, Peng Fan <peng.fan@oss.nxp.com> wrote:
> On Tue, Mar 10, 2026 at 03:53:35PM +0800, alice.guo@oss.nxp.com wrote:
>>From: Alice Guo <alice.guo@nxp.com>
>>
>>Add imx_wdog_alias_to_addr() to get watchdog register base address from
>>device tree aliases. This function is used by mx7ulp, imx8ulp and imx9
>>SoCs to locate watchdog hardware.
>>
>>The function supports:
>>- Matching specific alias (e.g., "wdog0") or any "wdog*" if name is
>> NULL.
>>- Optional device tree status check via check_status parameter.
>
> I not see wdog alias is used by anyone.
Indeed, don't use the stem 'wdog'. Use the stem 'watchdog', as e.g. the
linux watchdog framework does enumerate watchdog devices based on their
DT alias, but using 'watchdog' as the stem:
drivers/watchdog/watchdog_core.c- /* Use alias for watchdog id if possible */
drivers/watchdog/watchdog_core.c- if (wdd->parent) {
drivers/watchdog/watchdog_core.c: ret = of_alias_get_id(wdd->parent->of_node, "watchdog");
drivers/watchdog/watchdog_core.c- if (ret >= 0)
drivers/watchdog/watchdog_core.c- id = ida_alloc_range(&watchdog_ida, ret, ret,
drivers/watchdog/watchdog_core.c- GFP_KERNEL);
drivers/watchdog/watchdog_core.c- }
Rasmus
next prev parent reply other threads:[~2026-03-12 12:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 7:53 [PATCH 00/10] imx: Switch watchdog addressing from macros to devicetree alice.guo
2026-03-10 7:53 ` [PATCH v1 01/10] imx: Add helper to get watchdog base address from DT alias alice.guo
2026-03-12 7:17 ` Peng Fan
2026-03-12 9:52 ` Rasmus Villemoes [this message]
2026-03-10 7:53 ` [PATCH v1 02/10] watchdog: ulp_wdog: Get watchdog base address from device tree alice.guo
2026-03-12 7:19 ` Peng Fan
2026-03-10 7:53 ` [PATCH v1 03/10] imx: soc: Get watchdog base addresses " alice.guo
2026-03-12 9:01 ` Peng Fan
2026-03-10 7:53 ` [PATCH v1 04/10] imx7ulp: dtsi: Add wdog1 and wdog2 nodes with aliases alice.guo
2026-03-10 7:53 ` [PATCH v1 05/10] imx8ulp: dtsi: Add wdog3 alias and bootph-all property alice.guo
2026-03-10 7:53 ` [PATCH v1 06/10] imx93: dtsi: Add wdog3/wdog4/wdog5 " alice.guo
2026-03-10 7:53 ` [PATCH v1 07/10] imx91: " alice.guo
2026-03-10 7:53 ` [PATCH v1 08/10] imx943: dtsi: Add wdog3 and wdog4 nodes with aliases alice.guo
2026-03-10 7:53 ` [PATCH v1 09/10] imx95: " alice.guo
2026-03-10 7:53 ` [PATCH v1 10/10] imx: Remove hardcoded watchdog base address macros alice.guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0jxpe78.fsf@prevas.dk \
--to=ravi@prevas.dk \
--cc=Frank.Li@nxp.com \
--cc=alice.guo@nxp.com \
--cc=alice.guo@oss.nxp.com \
--cc=c.stoidner@phytec.de \
--cc=davidzangcs@gmail.com \
--cc=emanuele.ghidoli@toradex.com \
--cc=ernest.vanhoecke@toradex.com \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=frieder.schrempf@kontron.de \
--cc=jeremie.dautheribes@bootlin.com \
--cc=ji.luo@nxp.com \
--cc=jindong.yue@nxp.com \
--cc=joao.goncalves@toradex.com \
--cc=m.othacehe@gmail.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=marex@nabladev.com \
--cc=max.krummenacher@toradex.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=ping.bai@nxp.com \
--cc=primoz.fiser@norik.com \
--cc=qijian.guo@nxp.com \
--cc=ranjani.vaidyanathan@nxp.com \
--cc=sbabic@nabladev.com \
--cc=sjg@chromium.org \
--cc=stefan.roese@mailbox.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
--cc=upstream@lists.phytec.de \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox