Re: [PATCH v1 1/2] fastboot: mmc: make boot partition offset configurable

Mattijs Korpershoek
2026-02-06T10:21:12Z

Hi Heiko,

Thank you for the patch.

On Sat, Jan 24, 2026 at 06:47, Heiko Schocher <hs@nabladev.com> wrote:

> From: Adrian Freihofer <adrian.freihofer@siemens.com>
>
> Add a weak function fb_mmc_get_boot_offset() to allow to override
> the default offset (0) when writing to eMMC boot partitions.
> This enables support for devices with non-standard boot partition
> layouts, such as those requiring an offset for correct bootloader
> placement.
>
> The imx8qxp processors are an example where older revisions need a
> 32kB offset.
>
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> Signed-off-by: Heiko Schocher <hs@nabladev.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

I'm fine with this commit message but I also like the one that Peng
suggested[1]

Up to you to decide if you want to respin to update.

[1] https://lore.kernel.org/all/aXbGZ22OTwTbbGEw@shlinux89/

> ---
>
> drivers/fastboot/fb_block.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>