Re: [PATCH v1 2/2] arch: imx8qxp: Override weak fb_mmc_get_boot_offset function

Mattijs Korpershoek
2026-02-06T10:24:33Z

Hi Heiko,

Thank you for the patch.

On Sat, Jan 24, 2026 at 06:47, Heiko Schocher <hs@nabladev.com> wrote:

> From: Adrian Freihofer <adrian.freihofer@siemens.com>
>
> Add IMX8QXP SoCs specific implementation of fb_mmc_get_boot_offset()
>
> This is needed as bootloader offset is different dependent on SoC
> revision!
>
> For revision B0 the bootloader starts at 32k offset. On offset
> 0x0 the bootloaders environment is stored.
>
> On C0 revisions of the SoC bootloader image starts at offset 0x0
>
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> Signed-off-by: Heiko Schocher <hs@nabladev.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

This looks good to me but please have a look at Peng's comment [1]

I can pick this up but I'll need an ACK from Stefano, Fabio or someone
from u-boot-imx@nxp.com

[1] https://lore.kernel.org/all/aXbHDnU+SpgnEt+Q@shlinux89/

> ---
>
> arch/arm/mach-imx/imx8/cpu.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>