public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	 Tim Harvey <tharvey@gateworks.com>,
	 Simon Glass <sjg@chromium.org>,
	u-boot@lists.denx.de
Subject: Re: [PATCH 1/1] tpm: update descriptions in tpm-v2.h header
Date: Mon, 30 Dec 2024 09:49:47 +0100	[thread overview]
Message-ID: <87y0zx8sic.fsf@bootlin.com> (raw)
In-Reply-To: <20241224220049.26629-1-heinrich.schuchardt@canonical.com> (Heinrich Schuchardt's message of "Tue, 24 Dec 2024 23:00:49 +0100")

On 24/12/2024 at 23:00:49 +01, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote:

> * Provide a link to 'TPM 2.0 Library Specification'
> * Remove outdated comment for TPM2_NUM_PCR_BANKS.
>   The value 16 can be found in the current standard
>   TCG TSS 2.0 Overview and Common Structures Specification 1.0, rev 10

What about including this in the comment rather than dropping the
comment entirely?

> * Describe some of the structures in Sphinx style.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Fine otherwise,

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

  parent reply	other threads:[~2024-12-30  8:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-24 22:00 [PATCH 1/1] tpm: update descriptions in tpm-v2.h header Heinrich Schuchardt
2024-12-27 11:14 ` Ilias Apalodimas
2024-12-30  8:49 ` Miquel Raynal [this message]
2025-01-07 10:57   ` Ilias Apalodimas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0zx8sic.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=sjg@chromium.org \
    --cc=tharvey@gateworks.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox