[PATCH v1 0/5] TEE: minor cleanup

[PATCH v1 0/5] TEE: minor cleanup

[Igor Opaniuk]

- Address some spelling errors and typos
- Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
- Remove common.h inclusion for drivers/tee

Igor Opaniuk (5):
  tee: optee: fix description in Kconfig
  tee: sandbox: fix spelling errors
  cmd: optee_rpmb: build cmd for sandbox
  test: py: add optee_rpmb tests
  tee: remove common.h inclusion

 cmd/Kconfig                        |  4 +++-
 drivers/tee/broadcom/chimp_optee.c |  2 +-
 drivers/tee/optee/Kconfig          |  2 +-
 drivers/tee/optee/core.c           |  1 -
 drivers/tee/optee/i2c.c            |  1 -
 drivers/tee/optee/rpmb.c           |  1 -
 drivers/tee/optee/supplicant.c     |  2 +-
 drivers/tee/sandbox.c              | 10 +++++-----
 drivers/tee/tee-uclass.c           |  1 -
 test/py/tests/test_optee_rpmb.py   | 20 ++++++++++++++++++++
 10 files changed, 31 insertions(+), 13 deletions(-)
 create mode 100644 test/py/tests/test_optee_rpmb.py

-- 
2.34.1

[PATCH v1 1/5] tee: optee: fix description in Kconfig

[Igor Opaniuk]

Fix OPTEE_TA_AVB symbol description in Kconfig:
s/"write"rb"/"write_rb"/g

Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com>
---

 drivers/tee/optee/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tee/optee/Kconfig b/drivers/tee/optee/Kconfig
index 9dc65b0501e..db0bcfa6f15 100644
--- a/drivers/tee/optee/Kconfig
+++ b/drivers/tee/optee/Kconfig
@@ -19,7 +19,7 @@ config OPTEE_TA_AVB
 	default y
 	help
 	  Enables support for the AVB Trusted Application (TA) in OP-TEE.
-	  The TA can support the "avb" subcommands "read_rb", "write"rb"
+	  The TA can support the "avb" subcommands "read_rb", "write_rb"
 	  and "is_unlocked".
 
 config OPTEE_TA_RPC_TEST
-- 
2.34.1

[PATCH v1 2/5] tee: sandbox: fix spelling errors

[Igor Opaniuk]

Fix spelling errors in comments.

Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com>
---

 drivers/tee/sandbox.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/tee/sandbox.c b/drivers/tee/sandbox.c
index 86219a9bb1a..ec66401878c 100644
--- a/drivers/tee/sandbox.c
+++ b/drivers/tee/sandbox.c
@@ -14,7 +14,7 @@
 #include "optee/optee_private.h"
 
 /*
- * The sandbox tee driver tries to emulate a generic Trusted Exectution
+ * The sandbox tee driver tries to emulate a generic Trusted Execution
  * Environment (TEE) with the Trusted Applications (TA) OPTEE_TA_AVB and
  * OPTEE_TA_RPC_TEST available.
  */
@@ -23,7 +23,7 @@ static const u32 pstorage_max = 16;
 /**
  * struct ta_entry - TA entries
  * @uuid:		UUID of an emulated TA
- * @open_session	Called when a session is openened to the TA
+ * @open_session	Called when a session is opened to the TA
  * @invoke_func		Called when a function in the TA is to be invoked
  *
  * This struct is used to register TAs in this sandbox emulation of a TEE.
@@ -140,8 +140,8 @@ static u32 pta_scp03_invoke_func(struct udevice *dev, u32 func, uint num_params,
 			provisioned = true;
 
 		/*
-		 * Either way, we asume both operations succeeded and that
-		 * the communication channel has now been stablished
+		 * Either way, we assume both operations succeeded and that
+		 * the communication channel has now been established
 		 */
 
 		return TEE_SUCCESS;
-- 
2.34.1

[PATCH v1 3/5] cmd: optee_rpmb: build cmd for sandbox

[Igor Opaniuk]

Support CMD_OPTEE_RPMB for SANDBOX configurations.
Test:

$ ./u-boot -d arch/sandbox/dts/test.dtb
...
=> optee_rpmb write_pvalue test_variable test_value
Wrote 11 bytes
=> optee_rpmb read_pvalue test_variable 11
Read 11 bytes, value = test_value

Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com>
---

 cmd/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index a86b5705174..8ad8c0c542c 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1370,7 +1370,9 @@ config CMD_CLONE
 
 config CMD_OPTEE_RPMB
 	bool "Enable read/write support on RPMB via OPTEE"
-	depends on SUPPORT_EMMC_RPMB && OPTEE
+	depends on (SUPPORT_EMMC_RPMB && OPTEE) || SANDBOX_TEE
+	default y if SANDBOX_TEE
+	select OPTEE_TA_AVB if SANDBOX_TEE
 	help
 	  Enable the commands for reading, writing persistent named values
 	  in the Replay Protection Memory Block partition in eMMC by
-- 
2.34.1

[PATCH v1 4/5] test: py: add optee_rpmb tests

[Igor Opaniuk]

Add read/write tests for optee_rpmb cmd.

Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com>
---

 test/py/tests/test_optee_rpmb.py | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 test/py/tests/test_optee_rpmb.py

diff --git a/test/py/tests/test_optee_rpmb.py b/test/py/tests/test_optee_rpmb.py
new file mode 100644
index 00000000000..8a081b5c494
--- /dev/null
+++ b/test/py/tests/test_optee_rpmb.py
@@ -0,0 +1,20 @@
+# SPDX-License-Identifier:  GPL-2.0+
+#
+# Tests for OP-TEE RPMB read/write support
+
+"""
+This tests optee_rpmb cmd in U-Boot
+"""
+
+import pytest
+import u_boot_utils as util
+
+@pytest.mark.buildconfigspec('cmd_optee_rpmb')
+def test_optee_rpmb_read_write(u_boot_console):
+    """Test OP-TEE RPMB cmd read/write
+    """
+    response = u_boot_console.run_command('optee_rpmb write_pvalue test_variable test_value')
+    assert response == 'Wrote 11 bytes'
+
+    response = u_boot_console.run_command('optee_rpmb read_pvalue test_variable 11')
+    assert response == 'Read 11 bytes, value = test_value'
\ No newline at end of file
-- 
2.34.1

[PATCH v1 5/5] tee: remove common.h inclusion

[Igor Opaniuk]

The usage of the common.h include file is deprecated [1], and has already
been removed from several files.
Get rid of all inclusions in the "drivers/tee" directory, and replace it
with required include files directly where needed.

[1] doc/develop/codingstyle.rst

Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com>
---

 drivers/tee/broadcom/chimp_optee.c | 2 +-
 drivers/tee/optee/core.c           | 1 -
 drivers/tee/optee/i2c.c            | 1 -
 drivers/tee/optee/rpmb.c           | 1 -
 drivers/tee/optee/supplicant.c     | 2 +-
 drivers/tee/sandbox.c              | 2 +-
 drivers/tee/tee-uclass.c           | 1 -
 7 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/tee/broadcom/chimp_optee.c b/drivers/tee/broadcom/chimp_optee.c
index 37f9b094f76..c142ebd542f 100644
--- a/drivers/tee/broadcom/chimp_optee.c
+++ b/drivers/tee/broadcom/chimp_optee.c
@@ -3,9 +3,9 @@
  * Copyright 2020 Broadcom.
  */
 
-#include <common.h>
 #include <tee.h>
 #include <broadcom/chimp.h>
+#include <linux/errno.h>
 
 #ifdef CONFIG_CHIMP_OPTEE
 
diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
index 47f845cffe3..5fc0505c788 100644
--- a/drivers/tee/optee/core.c
+++ b/drivers/tee/optee/core.c
@@ -3,7 +3,6 @@
  * Copyright (c) 2018-2020 Linaro Limited
  */
 
-#include <common.h>
 #include <cpu_func.h>
 #include <dm.h>
 #include <dm/device_compat.h>
diff --git a/drivers/tee/optee/i2c.c b/drivers/tee/optee/i2c.c
index ef4e10f9912..e3fb99897c5 100644
--- a/drivers/tee/optee/i2c.c
+++ b/drivers/tee/optee/i2c.c
@@ -3,7 +3,6 @@
  * Copyright (c) 2020 Foundries.io Ltd
  */
 
-#include <common.h>
 #include <dm.h>
 #include <i2c.h>
 #include <tee.h>
diff --git a/drivers/tee/optee/rpmb.c b/drivers/tee/optee/rpmb.c
index 5bc13757ea8..bacced6af6c 100644
--- a/drivers/tee/optee/rpmb.c
+++ b/drivers/tee/optee/rpmb.c
@@ -3,7 +3,6 @@
  * Copyright (c) 2018 Linaro Limited
  */
 
-#include <common.h>
 #include <dm.h>
 #include <log.h>
 #include <tee.h>
diff --git a/drivers/tee/optee/supplicant.c b/drivers/tee/optee/supplicant.c
index f9dd874b594..8a426f53ba8 100644
--- a/drivers/tee/optee/supplicant.c
+++ b/drivers/tee/optee/supplicant.c
@@ -3,10 +3,10 @@
  * Copyright (c) 2018, Linaro Limited
  */
 
-#include <common.h>
 #include <log.h>
 #include <malloc.h>
 #include <tee.h>
+#include <linux/errno.h>
 #include <linux/types.h>
 
 #include "optee_msg.h"
diff --git a/drivers/tee/sandbox.c b/drivers/tee/sandbox.c
index ec66401878c..8ad7c09efdd 100644
--- a/drivers/tee/sandbox.c
+++ b/drivers/tee/sandbox.c
@@ -2,7 +2,7 @@
 /*
  * Copyright (C) 2018 Linaro Limited
  */
-#include <common.h>
+
 #include <dm.h>
 #include <sandboxtee.h>
 #include <tee.h>
diff --git a/drivers/tee/tee-uclass.c b/drivers/tee/tee-uclass.c
index 52412a4098e..0194d732193 100644
--- a/drivers/tee/tee-uclass.c
+++ b/drivers/tee/tee-uclass.c
@@ -5,7 +5,6 @@
 
 #define LOG_CATEGORY UCLASS_TEE
 
-#include <common.h>
 #include <cpu_func.h>
 #include <dm.h>
 #include <log.h>
-- 
2.34.1

Re: [PATCH v1 1/5] tee: optee: fix description in Kconfig

[Heinrich Schuchardt]

On 2/14/24 7:34 PM, Igor Opaniuk wrote:
> Fix OPTEE_TA_AVB symbol description in Kconfig:
> s/"write"rb"/"write_rb"/g
>
> Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com>

The change is consistent with
cmd/avb.c:424:
U_BOOT_CMD_MKENT(write_rb, 3, 0, do_avb_write_rb, "", ""),

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

> ---
>
>   drivers/tee/optee/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tee/optee/Kconfig b/drivers/tee/optee/Kconfig
> index 9dc65b0501e..db0bcfa6f15 100644
> --- a/drivers/tee/optee/Kconfig
> +++ b/drivers/tee/optee/Kconfig
> @@ -19,7 +19,7 @@ config OPTEE_TA_AVB
>   	default y
>   	help
>   	  Enables support for the AVB Trusted Application (TA) in OP-TEE.
> -	  The TA can support the "avb" subcommands "read_rb", "write"rb"
> +	  The TA can support the "avb" subcommands "read_rb", "write_rb"
>   	  and "is_unlocked".
>
>   config OPTEE_TA_RPC_TEST

Re: [PATCH v1 2/5] tee: sandbox: fix spelling errors

[Heinrich Schuchardt]

On 2/14/24 7:34 PM, Igor Opaniuk wrote:
> Fix spelling errors in comments.
>
> Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com>

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

> ---
>
>   drivers/tee/sandbox.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tee/sandbox.c b/drivers/tee/sandbox.c
> index 86219a9bb1a..ec66401878c 100644
> --- a/drivers/tee/sandbox.c
> +++ b/drivers/tee/sandbox.c
> @@ -14,7 +14,7 @@
>   #include "optee/optee_private.h"
>
>   /*
> - * The sandbox tee driver tries to emulate a generic Trusted Exectution
> + * The sandbox tee driver tries to emulate a generic Trusted Execution
>    * Environment (TEE) with the Trusted Applications (TA) OPTEE_TA_AVB and
>    * OPTEE_TA_RPC_TEST available.
>    */
> @@ -23,7 +23,7 @@ static const u32 pstorage_max = 16;
>   /**
>    * struct ta_entry - TA entries
>    * @uuid:		UUID of an emulated TA
> - * @open_session	Called when a session is openened to the TA
> + * @open_session	Called when a session is opened to the TA
>    * @invoke_func		Called when a function in the TA is to be invoked
>    *
>    * This struct is used to register TAs in this sandbox emulation of a TEE.
> @@ -140,8 +140,8 @@ static u32 pta_scp03_invoke_func(struct udevice *dev, u32 func, uint num_params,
>   			provisioned = true;
>
>   		/*
> -		 * Either way, we asume both operations succeeded and that
> -		 * the communication channel has now been stablished
> +		 * Either way, we assume both operations succeeded and that
> +		 * the communication channel has now been established
>   		 */
>
>   		return TEE_SUCCESS;

Re: [PATCH v1 3/5] cmd: optee_rpmb: build cmd for sandbox

[Mattijs Korpershoek]

Hi Igor,

Thank you for the patch.

On mer., févr. 14, 2024 at 19:34, Igor Opaniuk <igor.opaniuk@foundries.io> wrote:

> Support CMD_OPTEE_RPMB for SANDBOX configurations.
> Test:
>
> $ ./u-boot -d arch/sandbox/dts/test.dtb
> ...
> => optee_rpmb write_pvalue test_variable test_value
> Wrote 11 bytes
> => optee_rpmb read_pvalue test_variable 11
> Read 11 bytes, value = test_value
>
> Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> # on sandbox

> ---
>
>  cmd/Kconfig | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index a86b5705174..8ad8c0c542c 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1370,7 +1370,9 @@ config CMD_CLONE
>  
>  config CMD_OPTEE_RPMB
>  	bool "Enable read/write support on RPMB via OPTEE"
> -	depends on SUPPORT_EMMC_RPMB && OPTEE
> +	depends on (SUPPORT_EMMC_RPMB && OPTEE) || SANDBOX_TEE
> +	default y if SANDBOX_TEE
> +	select OPTEE_TA_AVB if SANDBOX_TEE
>  	help
>  	  Enable the commands for reading, writing persistent named values
>  	  in the Replay Protection Memory Block partition in eMMC by
> -- 
> 2.34.1

Re: [PATCH v1 0/5] TEE: minor cleanup

[Igor Opaniuk]

Hi Ilias,

On Wed, Feb 14, 2024 at 7:34 PM Igor Opaniuk <igor.opaniuk@foundries.io>
wrote:

> - Address some spelling errors and typos
> - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
> - Remove common.h inclusion for drivers/tee
>
> Igor Opaniuk (5):
>   tee: optee: fix description in Kconfig
>   tee: sandbox: fix spelling errors
>   cmd: optee_rpmb: build cmd for sandbox
>   test: py: add optee_rpmb tests
>   tee: remove common.h inclusion
>
>  cmd/Kconfig                        |  4 +++-
>  drivers/tee/broadcom/chimp_optee.c |  2 +-
>  drivers/tee/optee/Kconfig          |  2 +-
>  drivers/tee/optee/core.c           |  1 -
>  drivers/tee/optee/i2c.c            |  1 -
>  drivers/tee/optee/rpmb.c           |  1 -
>  drivers/tee/optee/supplicant.c     |  2 +-
>  drivers/tee/sandbox.c              | 10 +++++-----
>  drivers/tee/tee-uclass.c           |  1 -
>  test/py/tests/test_optee_rpmb.py   | 20 ++++++++++++++++++++
>  10 files changed, 31 insertions(+), 13 deletions(-)
>  create mode 100644 test/py/tests/test_optee_rpmb.py
>
> --
> 2.34.1
>
>
Are there currently any comments/objections that can prevent these cosmetic
changes from being applied? If there are - just let me know, thanks

Regards,
Igor

-- 
Best regards - Atentamente - Meilleures salutations

Igor Opaniuk

mailto: igor.opaniuk@gmail.com
skype: igor.opanyuk
http://ua.linkedin.com/in/iopaniuk

Re: [PATCH v1 0/5] TEE: minor cleanup

[Peter Robinson]

On Thu, 29 Feb 2024 at 19:11, Igor Opaniuk <igor.opaniuk@gmail.com> wrote:
>
> Hi Ilias,
>
> On Wed, Feb 14, 2024 at 7:34 PM Igor Opaniuk <igor.opaniuk@foundries.io>
> wrote:
>
> > - Address some spelling errors and typos
> > - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
> > - Remove common.h inclusion for drivers/tee
> >
> > Igor Opaniuk (5):
> >   tee: optee: fix description in Kconfig
> >   tee: sandbox: fix spelling errors
> >   cmd: optee_rpmb: build cmd for sandbox
> >   test: py: add optee_rpmb tests
> >   tee: remove common.h inclusion
> >
> >  cmd/Kconfig                        |  4 +++-
> >  drivers/tee/broadcom/chimp_optee.c |  2 +-
> >  drivers/tee/optee/Kconfig          |  2 +-
> >  drivers/tee/optee/core.c           |  1 -
> >  drivers/tee/optee/i2c.c            |  1 -
> >  drivers/tee/optee/rpmb.c           |  1 -
> >  drivers/tee/optee/supplicant.c     |  2 +-
> >  drivers/tee/sandbox.c              | 10 +++++-----
> >  drivers/tee/tee-uclass.c           |  1 -
> >  test/py/tests/test_optee_rpmb.py   | 20 ++++++++++++++++++++
> >  10 files changed, 31 insertions(+), 13 deletions(-)
> >  create mode 100644 test/py/tests/test_optee_rpmb.py
> >
> > --
> > 2.34.1
> >
> >
> Are there currently any comments/objections that can prevent these cosmetic
> changes from being applied? If there are - just let me know, thanks

Probably awaiting the next dev cycle, we're post RC3 now so it's
mostly fixes landing ATM.

Re: [PATCH v1 0/5] TEE: minor cleanup

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1807 bytes --]

On Thu, Feb 29, 2024 at 07:25:10PM +0000, Peter Robinson wrote:
> On Thu, 29 Feb 2024 at 19:11, Igor Opaniuk <igor.opaniuk@gmail.com> wrote:
> >
> > Hi Ilias,
> >
> > On Wed, Feb 14, 2024 at 7:34 PM Igor Opaniuk <igor.opaniuk@foundries.io>
> > wrote:
> >
> > > - Address some spelling errors and typos
> > > - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
> > > - Remove common.h inclusion for drivers/tee
> > >
> > > Igor Opaniuk (5):
> > >   tee: optee: fix description in Kconfig
> > >   tee: sandbox: fix spelling errors
> > >   cmd: optee_rpmb: build cmd for sandbox
> > >   test: py: add optee_rpmb tests
> > >   tee: remove common.h inclusion
> > >
> > >  cmd/Kconfig                        |  4 +++-
> > >  drivers/tee/broadcom/chimp_optee.c |  2 +-
> > >  drivers/tee/optee/Kconfig          |  2 +-
> > >  drivers/tee/optee/core.c           |  1 -
> > >  drivers/tee/optee/i2c.c            |  1 -
> > >  drivers/tee/optee/rpmb.c           |  1 -
> > >  drivers/tee/optee/supplicant.c     |  2 +-
> > >  drivers/tee/sandbox.c              | 10 +++++-----
> > >  drivers/tee/tee-uclass.c           |  1 -
> > >  test/py/tests/test_optee_rpmb.py   | 20 ++++++++++++++++++++
> > >  10 files changed, 31 insertions(+), 13 deletions(-)
> > >  create mode 100644 test/py/tests/test_optee_rpmb.py
> > >
> > > --
> > > 2.34.1
> > >
> > >
> > Are there currently any comments/objections that can prevent these cosmetic
> > changes from being applied? If there are - just let me know, thanks
> 
> Probably awaiting the next dev cycle, we're post RC3 now so it's
> mostly fixes landing ATM.

The -next branch is open too now tho, and I am picking up things out of
my queue. And other custodians can as well, time permitting :)

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH v1 1/5] tee: optee: fix description in Kconfig

[Ilias Apalodimas]

On Wed, Feb 14, 2024 at 07:34:40PM +0100, Igor Opaniuk wrote:
> Fix OPTEE_TA_AVB symbol description in Kconfig:
> s/"write"rb"/"write_rb"/g
> 
> Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com>
> ---
> 
>  drivers/tee/optee/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tee/optee/Kconfig b/drivers/tee/optee/Kconfig
> index 9dc65b0501e..db0bcfa6f15 100644
> --- a/drivers/tee/optee/Kconfig
> +++ b/drivers/tee/optee/Kconfig
> @@ -19,7 +19,7 @@ config OPTEE_TA_AVB
>  	default y
>  	help
>  	  Enables support for the AVB Trusted Application (TA) in OP-TEE.
> -	  The TA can support the "avb" subcommands "read_rb", "write"rb"
> +	  The TA can support the "avb" subcommands "read_rb", "write_rb"
>  	  and "is_unlocked".
>  
>  config OPTEE_TA_RPC_TEST
> -- 
> 2.34.1
> 

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

Re: [PATCH v1 2/5] tee: sandbox: fix spelling errors

[Ilias Apalodimas]

On Wed, Feb 14, 2024 at 07:34:41PM +0100, Igor Opaniuk wrote:
> Fix spelling errors in comments.
> 
> Signed-off-by: Igor Opaniuk <igor.opaniuk@gmail.com>
> ---
> 
>  drivers/tee/sandbox.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/tee/sandbox.c b/drivers/tee/sandbox.c
> index 86219a9bb1a..ec66401878c 100644
> --- a/drivers/tee/sandbox.c
> +++ b/drivers/tee/sandbox.c
> @@ -14,7 +14,7 @@
>  #include "optee/optee_private.h"
>  
>  /*
> - * The sandbox tee driver tries to emulate a generic Trusted Exectution
> + * The sandbox tee driver tries to emulate a generic Trusted Execution
>   * Environment (TEE) with the Trusted Applications (TA) OPTEE_TA_AVB and
>   * OPTEE_TA_RPC_TEST available.
>   */
> @@ -23,7 +23,7 @@ static const u32 pstorage_max = 16;
>  /**
>   * struct ta_entry - TA entries
>   * @uuid:		UUID of an emulated TA
> - * @open_session	Called when a session is openened to the TA
> + * @open_session	Called when a session is opened to the TA
>   * @invoke_func		Called when a function in the TA is to be invoked
>   *
>   * This struct is used to register TAs in this sandbox emulation of a TEE.
> @@ -140,8 +140,8 @@ static u32 pta_scp03_invoke_func(struct udevice *dev, u32 func, uint num_params,
>  			provisioned = true;
>  
>  		/*
> -		 * Either way, we asume both operations succeeded and that
> -		 * the communication channel has now been stablished
> +		 * Either way, we assume both operations succeeded and that
> +		 * the communication channel has now been established
>  		 */
>  
>  		return TEE_SUCCESS;
> -- 
> 2.34.1
> 
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

Re: [PATCH v1 0/5] TEE: minor cleanup

[Ilias Apalodimas]

Hi Igor,

On Thu, 29 Feb 2024 at 21:11, Igor Opaniuk <igor.opaniuk@gmail.com> wrote:
>
> Hi Ilias,
>
> On Wed, Feb 14, 2024 at 7:34 PM Igor Opaniuk <igor.opaniuk@foundries.io> wrote:
>>
>> - Address some spelling errors and typos
>> - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
>> - Remove common.h inclusion for drivers/tee

CI fails on https://source.denx.de/u-boot/custodians/u-boot-tpm/-/pipelines/19780
Can you have a look?

Thanks
/Ilias
>>
>> Igor Opaniuk (5):
>>   tee: optee: fix description in Kconfig
>>   tee: sandbox: fix spelling errors
>>   cmd: optee_rpmb: build cmd for sandbox
>>   test: py: add optee_rpmb tests
>>   tee: remove common.h inclusion
>>
>>  cmd/Kconfig                        |  4 +++-
>>  drivers/tee/broadcom/chimp_optee.c |  2 +-
>>  drivers/tee/optee/Kconfig          |  2 +-
>>  drivers/tee/optee/core.c           |  1 -
>>  drivers/tee/optee/i2c.c            |  1 -
>>  drivers/tee/optee/rpmb.c           |  1 -
>>  drivers/tee/optee/supplicant.c     |  2 +-
>>  drivers/tee/sandbox.c              | 10 +++++-----
>>  drivers/tee/tee-uclass.c           |  1 -
>>  test/py/tests/test_optee_rpmb.py   | 20 ++++++++++++++++++++
>>  10 files changed, 31 insertions(+), 13 deletions(-)
>>  create mode 100644 test/py/tests/test_optee_rpmb.py
>>
>> --
>> 2.34.1
>>
>
> Are there currently any comments/objections that can prevent these cosmetic
> changes from being applied? If there are - just let me know, thanks
>
> Regards,
> Igor
>
> --
> Best regards - Atentamente - Meilleures salutations
>
> Igor Opaniuk
>
> mailto: igor.opaniuk@gmail.com
> skype: igor.opanyuk
> http://ua.linkedin.com/in/iopaniuk

Re: [PATCH v1 0/5] TEE: minor cleanup

[Igor Opaniuk]

Hello Ilias,

On Fri, Mar 1, 2024 at 10:41 AM Ilias Apalodimas <
ilias.apalodimas@linaro.org> wrote:

> Hi Igor,
>
> On Thu, 29 Feb 2024 at 21:11, Igor Opaniuk <igor.opaniuk@gmail.com> wrote:
> >
> > Hi Ilias,
> >
> > On Wed, Feb 14, 2024 at 7:34 PM Igor Opaniuk <igor.opaniuk@foundries.io>
> wrote:
> >>
> >> - Address some spelling errors and typos
> >> - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
> >> - Remove common.h inclusion for drivers/tee
>
> CI fails on
> https://source.denx.de/u-boot/custodians/u-boot-tpm/-/pipelines/19780
> Can you have a look?
>
I've fixed and sent v2, thanks!


>
> Thanks
> /Ilias
> >>
> >> Igor Opaniuk (5):
> >>   tee: optee: fix description in Kconfig
> >>   tee: sandbox: fix spelling errors
> >>   cmd: optee_rpmb: build cmd for sandbox
> >>   test: py: add optee_rpmb tests
> >>   tee: remove common.h inclusion
> >>
> >>  cmd/Kconfig                        |  4 +++-
> >>  drivers/tee/broadcom/chimp_optee.c |  2 +-
> >>  drivers/tee/optee/Kconfig          |  2 +-
> >>  drivers/tee/optee/core.c           |  1 -
> >>  drivers/tee/optee/i2c.c            |  1 -
> >>  drivers/tee/optee/rpmb.c           |  1 -
> >>  drivers/tee/optee/supplicant.c     |  2 +-
> >>  drivers/tee/sandbox.c              | 10 +++++-----
> >>  drivers/tee/tee-uclass.c           |  1 -
> >>  test/py/tests/test_optee_rpmb.py   | 20 ++++++++++++++++++++
> >>  10 files changed, 31 insertions(+), 13 deletions(-)
> >>  create mode 100644 test/py/tests/test_optee_rpmb.py
> >>
> >> --
> >> 2.34.1
> >>
> >
> > Are there currently any comments/objections that can prevent these
> cosmetic
> > changes from being applied? If there are - just let me know, thanks
> >
> > Regards,
> > Igor
> >
> > --
> > Best regards - Atentamente - Meilleures salutations
> >
> > Igor Opaniuk
> >
> > mailto: igor.opaniuk@gmail.com
> > skype: igor.opanyuk
> > http://ua.linkedin.com/in/iopaniuk
>


-- 
Best regards - Atentamente - Meilleures salutations

Igor Opaniuk

mailto: igor.opaniuk@gmail.com
skype: igor.opanyuk
http://ua.linkedin.com/in/iopaniuk