From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B382C636D6 for ; Wed, 22 Feb 2023 16:51:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BCDC885C0A; Wed, 22 Feb 2023 17:45:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=tkos.co.il Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=tkos.co.il header.i=@tkos.co.il header.b="kmF1bd8h"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1D5A185BEA; Wed, 22 Feb 2023 17:45:14 +0100 (CET) Received: from mail.tkos.co.il (hours.tkos.co.il [84.110.109.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 96D3F85BF7 for ; Wed, 22 Feb 2023 17:45:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=tkos.co.il Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=baruch@tkos.co.il Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.tkos.co.il (Postfix) with ESMTPS id 8C50C440883; Wed, 22 Feb 2023 18:40:47 +0200 (IST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1677084047; bh=/wDN3dBKgpRKp23loC2BBSUhKW3JFRyJ21snXgILRio=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=kmF1bd8hXVnsBahuu+6KyOf7U65KT7XBI2lTPyAP55tecWLiQTc1BGzGeYLJzkDQf 3fmsfnYCkE0rRMWXHim+BsFCGq0JVFWH+MB2APnK1xZQIkI0e03F9r2kznPce5WHkz P0LtfhOYeXSuuQ82CV3A9/Es8UP8Neg2s8X2YZN9716ZefgT6i+9rrWyNpIGxFLjsP Z1FuauY5wT4uD0XNWWiZCFUCXcpOvaRxh39yeGFnmHg640hfg99MUuwGNiSJiEMxkq sTgAcso+vDOvK4ixJsjLrEW9ZiYH/n9aaG/tNKudCawO4pniXN0nfr6YrNYjj5g2w9 zSE+rChC3cfEw== References: <20230222163425.2043934-1-sjg@chromium.org> <20230222163425.2043934-37-sjg@chromium.org> User-agent: mu4e 1.9.21; emacs 28.2 From: Baruch Siach To: Simon Glass Cc: U-Boot Mailing List , Tom Rini , Fabio Estevam , Stefano Babic , Troy Kisky Subject: Re: [PATCH v5 36/44] imx: Use SATA instead of CMD_SATA Date: Wed, 22 Feb 2023 18:43:53 +0200 In-reply-to: <20230222163425.2043934-37-sjg@chromium.org> Message-ID: <87y1opmyy4.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On Wed, Feb 22 2023, Simon Glass wrote: > This causes a build failure on mx6cuboxi with split config, since CMD_SATA > shows up as enabled in SPl (because there is no SPL_CMD_SATA). > > The condition is wrong anyway, so change it to use SATA instead. > > Signed-off-by: Simon Glass This conflicts with https://patchwork.ozlabs.org/project/uboot/patch/20230222013821.1144691-19-troykiskyboundary@gmail.com/ baruch > --- > > (no changes since v1) > > board/solidrun/mx6cuboxi/mx6cuboxi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c b/board/solidrun/mx6cuboxi/mx6cuboxi.c > index 7c44379ec4a..cb14c2f30c9 100644 > --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c > +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c > @@ -275,7 +275,7 @@ int board_early_init_f(void) > { > setup_iomux_uart(); > > -#ifdef CONFIG_CMD_SATA > +#ifdef CONFIG_SATA > setup_sata(); > #endif > setup_fec(); -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -