public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] arm: odroid: Increase default env size in preparation for distro_bootcmd.
Date: Thu, 07 Jun 2018 18:46:57 -0700	[thread overview]
Message-ID: <87y3fqaw32.fsf@aikidev.net> (raw)
In-Reply-To: <CALrBrZ0rwnN-k9tDib8pp5+nFVQgXgOe8kZDc8rwmcr2=e0oeA@mail.gmail.com>

On 2018-06-07, Minkyu Kang wrote:
> 2018년 6월 6일 (수) 06:16, Vagrant Cascadian <vagrant@debian.org>님이 작성:
>
>> Adding distro_bootcmd support bumps the default environment size over
>> 4500. Increase to 16384 to allow for room to grow in the future.
>>
>> Signed-off-by: Vagrant Cascadian <vagrant@debian.org>
>> ---
>>
>>  include/configs/odroid.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/configs/odroid.h b/include/configs/odroid.h
>> index b7b75c0dc0..c795ee8c74 100644
>> --- a/include/configs/odroid.h
>> +++ b/include/configs/odroid.h
>> @@ -50,7 +50,7 @@
>>  #define CONFIG_SYS_MONITOR_BASE        0x00000000
>>
>>  #define CONFIG_SYS_MMC_ENV_DEV         CONFIG_MMC_DEFAULT_DEV
>> -#define CONFIG_ENV_SIZE                        4096
>> +#define CONFIG_ENV_SIZE                        16384
>>
>
> I think it's better to use SZ_16K.
> What do you think?

No real opinion either way.


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180607/62f07d13/attachment.sig>

  reply	other threads:[~2018-06-08  1:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05 21:13 [U-Boot] [PATCH 0/4] arm: odroid: Convert to distro_bootcmd Vagrant Cascadian
2018-06-05 21:13 ` [U-Boot] [PATCH 1/4] arm: odroid: Use standard environment variable names kernel_addr_r, ramdisk_addr_r and fdt_addr_r Vagrant Cascadian
2018-06-05 21:13 ` [U-Boot] [PATCH 2/4] arm: odroid: Increase default env size in preparation for distro_bootcmd Vagrant Cascadian
2018-06-08  0:54   ` Minkyu Kang
2018-06-08  1:46     ` Vagrant Cascadian [this message]
2018-06-05 21:13 ` [U-Boot] [PATCH 3/4] arm: odroid: Enable distro_bootcmd support Vagrant Cascadian
2018-06-05 21:13 ` [U-Boot] [PATCH 4/4] arm: odroid: Inherit default value for bootdelay from distro_bootcmd Vagrant Cascadian
2018-06-07  7:47 ` [U-Boot] [PATCH 0/4] arm: odroid: Convert to distro_bootcmd Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3fqaw32.fsf@aikidev.net \
    --to=vagrant@debian.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox