From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshinori Sato Date: Sat, 02 Oct 2010 00:02:43 +0900 Subject: [U-Boot] [PATCH] xyzModem.c Packet buffer dynamic allocate In-Reply-To: <20101001075749.B131C153A7E@gemini.denx.de> References: <87sk0q1mnf.wl%ysato@users.sourceforge.jp> <20101001075749.B131C153A7E@gemini.denx.de> Message-ID: <87y6ai2bxo.wl%ysato@users.sourceforge.jp> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de At Fri, 01 Oct 2010 09:57:49 +0200, Wolfgang Denk wrote: > > Dear Yoshinori Sato, > > In message <87sk0q1mnf.wl%ysato@users.sourceforge.jp> you wrote: > > > > It changes reduce bss usage. > > ... and increases the load on the malloc arean. > > > Ymodem receive buffer dinamic allocation. > > As far as I can see we increase the code size, and shift a fixed sized > buffer from bss to the maloc arene. > > I don't consider this an improvement, but I may be overlooking > something. > > Which advantages do you see with the changed code? My target have too small size RAM. I want reduced to data and bss. It is limited to one usage in a static allocation. But dynamic allocation can use generically. > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de > If the facts don't fit the theory, change the facts. > -- Albert Einstein -- Yoshinori Sato