Re: [PATCH 06/14] usb: dwc3-octeon-glue: check dev_remap_addr() for NULL

[Mattijs Korpershoek <mkorpershoek@kernel.org>]

Hi David,

Thank you for the patch.

On Thu, Sep 03, 2026 at 16:35, David Lechner <dlechner@baylibre.com> wrote:

> Check the return value of dev_remap_addr() for NULL instead of
> IS_ERR(). This function only ever returns NULL on failure.
>
> Drop the now-unused <linux/err.h> include.
>
> Fixes: 92ca2fee08d5 ("usb: xhci: octeon: Add DWC3 glue layer for Octeon")
> Signed-off-by: David Lechner <dlechner@baylibre.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---
>  drivers/usb/host/dwc3-octeon-glue.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/host/dwc3-octeon-glue.c b/drivers/usb/host/dwc3-octeon-glue.c
> index 975f375e15a..39f2e70e47d 100644
> --- a/drivers/usb/host/dwc3-octeon-glue.c
> +++ b/drivers/usb/host/dwc3-octeon-glue.c
> @@ -19,7 +19,6 @@
>  #include <dm/of_access.h>
>  #include <linux/bitfield.h>
>  #include <linux/delay.h>
> -#include <linux/err.h>
>  #include <linux/io.h>
>  #include <linux/usb/dwc3.h>
>  #include <linux/usb/otg.h>
> @@ -351,8 +350,8 @@ static int octeon_dwc3_glue_probe(struct udevice *dev)
>  	void __iomem *base;
>  
>  	base = dev_remap_addr(dev);
> -	if (IS_ERR(base))
> -		return PTR_ERR(base);
> +	if (!base)
> +		return -EINVAL;
>  
>  	dwc3_octeon_clocks_start(dev, base);
>  	dwc3_octeon_set_endian_mode(base);
>
> -- 
> 2.43.0