From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B92A4C54798 for ; Sat, 9 Mar 2024 12:39:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 27F2E87CDA; Sat, 9 Mar 2024 13:39:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Pkrlgkbr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A43FA87CF1; Sat, 9 Mar 2024 13:39:30 +0100 (CET) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8866B8765B for ; Sat, 9 Mar 2024 13:39:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=maz@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 18423CE01B7; Sat, 9 Mar 2024 12:39:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B545C433F1; Sat, 9 Mar 2024 12:39:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709987964; bh=50OX0wkqvONeNFvmRPPWr418EHFWBuAljMMZSkjZ+Vw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Pkrlgkbra4XEzwyvjqDlvl+Jkv/eZguMFNGb1WvYp45fxlfIm1K3dPZs6isSsDCtL 9O8N/+Oqd09k0ZVo6kdTIA3PLpw6MjE2xU/5CiLNbD4aZq78K/Ym/SrDqcuDLtCpD8 FR1mUW1I1FMe7myAnGZzQMqCU1u6Km++eWIsc1dtx4j6pvdlryG/NwAhs7gjCN4CET bxtpKY8sFBDlN47O63IgnAixZHEVktOteFzd6+fumPt1foxmCplu8FH9+BbXDXhuDD wqb4zfLPm53fq3eg0zSOuCbKqjRFXN4MfiYxHr9H2RmkdSJ/GfNJ1PvuNMaTxCBmPq Tzx+AszzFNvhA== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rivyz-00Az98-Ow; Sat, 09 Mar 2024 12:39:21 +0000 Date: Sat, 09 Mar 2024 12:39:21 +0000 Message-ID: <87zfv7pojq.wl-maz@kernel.org> From: Marc Zyngier To: Fabio Estevam Cc: "Ying-Chun Liu (PaulLiu)" , u-boot@lists.denx.de, =?UTF-8?B?UGllcnJlLUNsw6ltZW50?= Tosi , Tom Rini , Marcel Ziswiler , Francesco Dolcini Subject: Re: [PATCH 1/2] arm64: Reduce add_map() complexity In-Reply-To: References: <20230214133814.4173549-1-paul.liu@linaro.org> <20230214133814.4173549-2-paul.liu@linaro.org> <875xxvratg.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: festevam@gmail.com, paul.liu@linaro.org, u-boot@lists.denx.de, ptosi@google.com, trini@konsulko.com, marcel.ziswiler@toradex.com, francesco.dolcini@toradex.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Sat, 09 Mar 2024 12:29:10 +0000, Fabio Estevam wrote: >=20 > Hi Marc, >=20 > On Sat, Mar 9, 2024 at 6:53=E2=80=AFAM Marc Zyngier wrot= e: >=20 > > It would be good to narrow down which access is generating this. It is > > an asynchronous error, so the code above won't help. > > > > Alternatively, and if you are sure that this is due to this change, > > dumping the page tables and comparing them before and after would > > help. >=20 > Yes, I am sure the error is due to this change. It is 100% reproducible. Can you figure out what memory access is triggering it? Even at narrowing it to the subsystem level would be a good indication. > I am not familiar with this part of the code, so I would appreciate > it if you could tell me how to dump the page tables so I can compare > them before and after. You could just dump the entries as they are written. The order may not be the same, but for a given VA you should observe the same entries being written. My hunch is that the new code is a lot more picky about the alignment of things, and that could result in something being similarly unaligned. But without access to the platform nor an idea of what gets mapped, it's a bit hard to have a clue. Thanks, M. --=20 Without deviation from the norm, progress is not possible.