From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Simon Glass <sjg@chromium.org>, Safae Ouajih <souajih@baylibre.com>
Cc: u-boot@lists.denx.de, sean.anderson@seco.com,
r.stratiienko@gmail.com, glaroque@baylibre.com,
khilman@baylibre.com
Subject: Re: [PATCH v2 04/17] android: boot: add boot image header v3 and v4 structures
Date: Wed, 01 Feb 2023 09:34:48 +0100 [thread overview]
Message-ID: <87zg9xiy1j.fsf@baylibre.com> (raw)
In-Reply-To: <CAPnjgZ35RxtDb2NdxuXPhnNWKwxtU7=_F+LqS4Vfkyn-Ey8NLg@mail.gmail.com>
On Thu, Jan 26, 2023 at 17:54, Simon Glass <sjg@chromium.org> wrote:
> On Thu, 26 Jan 2023 at 09:05, Safae Ouajih <souajih@baylibre.com> wrote:
>>
>> This adds support for v3/v4 boot image format by adding
>> the following structures:
>>
>> - andr_boot_img_hdr_v3 : describes boot image header
>> - andr_vendor_img_hdr : describes vendor boot image header
>>
>> These definitions have been copied over from the AOSP documentation at
>> [1] and [2]
>>
>> Boot arg sizes are taken from [3]:
>> commit: 35fb6262bc3f (ANDROID: Support for vendor boot)
>>
>> This also adds documentation for boot image header v3/v4 structure
>> that was imported from [4], file: include/bootimg/bootimg.h
>> commit: 8d0922bfb932 (Adding GKI signature in boot.img v4)
>>
>> Link:[1] https://source.android.com/docs/core/architecture/bootloader/boot-image-header
>> Link:[2] https://source.android.com/docs/core/architecture/bootloader/partitions/vendor-boot-partitions#vendor-boot-header
>> Link:[3] https://android.googlesource.com/platform/external/u-boot
>> Link:[4] https://android.googlesource.com/platform/system/tools/mkbootimg
>>
>> Signed-off-by: Safae Ouajih <souajih@baylibre.com>
>> ---
>> include/android_image.h | 183 +++++++++++++++++++++++++++++++++++++++-
>> 1 file changed, 182 insertions(+), 1 deletion(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> You might consider using the sphinx style for struct comments so you
> can include this header file into the docs directly.
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
next prev parent reply other threads:[~2023-02-01 8:34 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 16:04 [PATCH v2 00/17] Support android boot image v3/v4 Safae Ouajih
2023-01-26 16:04 ` [PATCH v2 01/17] android: boot: rename andr_img_hdr -> andr_boot_img_hdr_v0 Safae Ouajih
2023-01-27 0:54 ` Simon Glass
2023-02-01 8:27 ` Mattijs Korpershoek
2023-01-26 16:04 ` [PATCH v2 02/17] android: boot: support vendor boot image in abootimg Safae Ouajih
2023-01-27 0:54 ` Simon Glass
2023-02-01 8:32 ` Mattijs Korpershoek
2023-01-26 16:04 ` [PATCH v2 03/17] android: boot: replace android_image_check_header Safae Ouajih
2023-01-27 0:54 ` Simon Glass
2023-02-01 8:33 ` Mattijs Korpershoek
2023-01-26 16:04 ` [PATCH v2 04/17] android: boot: add boot image header v3 and v4 structures Safae Ouajih
2023-01-27 0:54 ` Simon Glass
2023-02-01 8:34 ` Mattijs Korpershoek [this message]
2023-01-26 16:04 ` [PATCH v2 05/17] android: boot: kcomp: support andr_image_data Safae Ouajih
2023-01-27 0:54 ` Simon Glass
2023-02-01 8:35 ` Mattijs Korpershoek
2023-01-26 16:04 ` [PATCH v2 06/17] android: boot: move to andr_image_data structure Safae Ouajih
2023-01-27 0:54 ` Simon Glass
2023-01-27 15:50 ` Safae Ouajih
2023-01-27 17:15 ` Simon Glass
2023-01-26 16:04 ` [PATCH v2 07/17] android: boot: content print is not supported for v3, v4 header version Safae Ouajih
2023-01-27 0:54 ` [PATCH v2 07/17] android: boot: content print is not supported for v3,v4 " Simon Glass
2023-01-27 15:50 ` Safae Ouajih
2023-01-27 17:15 ` Simon Glass
2023-02-01 8:36 ` Mattijs Korpershoek
2023-01-26 16:04 ` [PATCH v2 08/17] android: boot: boot image header v3, v4 do not support recovery DTBO Safae Ouajih
2023-01-27 0:54 ` [PATCH v2 08/17] android: boot: boot image header v3,v4 " Simon Glass
2023-02-01 8:37 ` Mattijs Korpershoek
2023-01-26 16:04 ` [PATCH v2 09/17] android: boot: add vendor boot image to prepare for v3, v4 support Safae Ouajih
2023-01-27 0:54 ` [PATCH v2 09/17] android: boot: add vendor boot image to prepare for v3,v4 support Simon Glass
2023-01-26 16:04 ` [PATCH v2 10/17] android: boot: update android_image_get_data to support v3, v4 Safae Ouajih
2023-01-27 0:54 ` [PATCH v2 10/17] android: boot: update android_image_get_data to support v3,v4 Simon Glass
2023-01-26 16:05 ` [PATCH v2 11/17] android: boot: ramdisk: support vendor ramdisk Safae Ouajih
2023-01-27 0:54 ` Simon Glass
2023-01-26 16:05 ` [PATCH v2 12/17] android: boot: support extra command line Safae Ouajih
2023-01-27 0:54 ` Simon Glass
2023-01-27 15:51 ` Safae Ouajih
2023-01-27 17:15 ` Simon Glass
2023-02-01 8:39 ` Mattijs Korpershoek
2023-01-26 16:05 ` [PATCH v2 13/17] android: boot: update android_image_get_dtb_img_addr to support v3, v4 Safae Ouajih
2023-01-27 0:55 ` [PATCH v2 13/17] android: boot: update android_image_get_dtb_img_addr to support v3,v4 Simon Glass
2023-02-01 8:42 ` Mattijs Korpershoek
2023-01-26 16:05 ` [PATCH v2 14/17] drivers: fastboot: zImage flashing is not supported for v3, v4 Safae Ouajih
2023-01-27 0:55 ` [PATCH v2 14/17] drivers: fastboot: zImage flashing is not supported for v3,v4 Simon Glass
2023-01-26 16:05 ` [PATCH v2 15/17] android: boot: support boot image header version 3 and 4 Safae Ouajih
2023-01-27 0:55 ` Simon Glass
2023-02-01 8:44 ` Mattijs Korpershoek
2023-02-02 9:54 ` Safae Ouajih
2023-01-26 16:05 ` [PATCH v2 16/17] android: boot: support bootconfig Safae Ouajih
2023-01-27 0:55 ` Simon Glass
2023-02-01 8:45 ` Mattijs Korpershoek
2023-01-26 16:05 ` [PATCH v2 17/17] test/py: android: extend abootimg test Safae Ouajih
2023-01-27 0:55 ` Simon Glass
2023-01-27 15:51 ` Safae Ouajih
2023-01-27 20:37 ` Tom Rini
2023-01-31 12:34 ` Safae Ouajih
2023-01-26 18:17 ` [PATCH v2 00/17] Support android boot image v3/v4 Roman Stratiienko
2023-01-27 9:19 ` Safae Ouajih
2023-02-01 8:26 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg9xiy1j.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=glaroque@baylibre.com \
--cc=khilman@baylibre.com \
--cc=r.stratiienko@gmail.com \
--cc=sean.anderson@seco.com \
--cc=sjg@chromium.org \
--cc=souajih@baylibre.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox