From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 711D6C05027 for ; Wed, 1 Feb 2023 08:34:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8BC4885C19; Wed, 1 Feb 2023 09:34:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20210112.gappssmtp.com header.i=@baylibre-com.20210112.gappssmtp.com header.b="f5Cue8rI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2C5D785C19; Wed, 1 Feb 2023 09:34:53 +0100 (CET) Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BFACB85C18 for ; Wed, 1 Feb 2023 09:34:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mkorpershoek@baylibre.com Received: by mail-wr1-x42c.google.com with SMTP id h12so16496569wrv.10 for ; Wed, 01 Feb 2023 00:34:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=GyP1SmkopihYnf0uWh3/LQSpPgvJ4ycFnoyJ+7QegxY=; b=f5Cue8rI2glI0ZvDnVTcGqdOP4Q0aiGSggNEMqpZafQzcM2xF6W2JGIqR5JOvl2oqT 2ukH/uR7HmF3gMRQmtpm/fL5kVGWmutVUtvvAVvv20wd31IwirpiEPaxspWudCDljVx2 Op+VV/xfU7BfeFY6RKF5DlX1655r0X/A8LDcJrymIK767NjdcdnkKqDNxRCx6YDCBa6O B7C/xLmO4CviOKbIKJRQ52XVC3Ly0jOD+MKEsGohSE6L9Bgf81crc4UKw7kNqWYJf6h/ S6t2Gtl88l+tHYfg2ag8h1A7F0L7So4h6AWENOyK0Lqh9G+6D+JrAzL0pNPnbhu64vur zVJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GyP1SmkopihYnf0uWh3/LQSpPgvJ4ycFnoyJ+7QegxY=; b=Id4Nmvvx2pNVUqG5GicFjyPl0qOmRZUF/MM/5od6ZV08T9EdsOsA8n06OcTzFIyqBn QcGFOLwDpkMurK7YYE51kvVk0qsFzqYJlKtyV7K/iQDA1xFjM+nIxC7HZYTQuauSYxiK jtBUFTdTDQtKHJDqm5GTiI4K5ZQoepTFC8ai8U5cUCNRlwwaVEt8zFpeuFwI3/X0aUI/ 1o6jcxh0kOKLqWA8wjODwL7x86BJtf2Mnh2QnMQ4b7lYZwiPlhP6MrADA4HqeabR3GP3 82iPtt2q35CryKIrILmugZf8AKwSSwW+VJr8k9gzTntGQQY35x9CdG1/IyVJ4AbrDsfg sZRA== X-Gm-Message-State: AO0yUKVq0FSImyMyI/T1+wjJ9IjOoGHZReaM8HgU+UQ99ff0N0XrQuEy 9HWxQNOuCMnYafO25bE0MrrN+koGp/ULaqjA X-Google-Smtp-Source: AK7set/8Z6Y2TzpM43oxDudnHyDMeBw2zWLtAMgR3upu8tFHc55DW7E63gd7/RyL/XeWrIB34k+ncw== X-Received: by 2002:a05:6000:988:b0:2bf:d88b:7b45 with SMTP id by8-20020a056000098800b002bfd88b7b45mr1809048wrb.67.1675240489264; Wed, 01 Feb 2023 00:34:49 -0800 (PST) Received: from localhost ([82.66.159.240]) by smtp.gmail.com with ESMTPSA id r25-20020adfa159000000b00297dcfdc90fsm17185635wrr.24.2023.02.01.00.34.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 00:34:48 -0800 (PST) From: Mattijs Korpershoek To: Simon Glass , Safae Ouajih Cc: u-boot@lists.denx.de, sean.anderson@seco.com, r.stratiienko@gmail.com, glaroque@baylibre.com, khilman@baylibre.com Subject: Re: [PATCH v2 04/17] android: boot: add boot image header v3 and v4 structures In-Reply-To: References: <20230126160506.1026643-1-souajih@baylibre.com> <20230126160506.1026643-5-souajih@baylibre.com> Date: Wed, 01 Feb 2023 09:34:48 +0100 Message-ID: <87zg9xiy1j.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Thu, Jan 26, 2023 at 17:54, Simon Glass wrote: > On Thu, 26 Jan 2023 at 09:05, Safae Ouajih wrote: >> >> This adds support for v3/v4 boot image format by adding >> the following structures: >> >> - andr_boot_img_hdr_v3 : describes boot image header >> - andr_vendor_img_hdr : describes vendor boot image header >> >> These definitions have been copied over from the AOSP documentation at >> [1] and [2] >> >> Boot arg sizes are taken from [3]: >> commit: 35fb6262bc3f (ANDROID: Support for vendor boot) >> >> This also adds documentation for boot image header v3/v4 structure >> that was imported from [4], file: include/bootimg/bootimg.h >> commit: 8d0922bfb932 (Adding GKI signature in boot.img v4) >> >> Link:[1] https://source.android.com/docs/core/architecture/bootloader/boot-image-header >> Link:[2] https://source.android.com/docs/core/architecture/bootloader/partitions/vendor-boot-partitions#vendor-boot-header >> Link:[3] https://android.googlesource.com/platform/external/u-boot >> Link:[4] https://android.googlesource.com/platform/system/tools/mkbootimg >> >> Signed-off-by: Safae Ouajih >> --- >> include/android_image.h | 183 +++++++++++++++++++++++++++++++++++++++- >> 1 file changed, 182 insertions(+), 1 deletion(-) > > Reviewed-by: Simon Glass > > You might consider using the sphinx style for struct comments so you > can include this header file into the docs directly. Reviewed-by: Mattijs Korpershoek