From: Heiko Schocher <hs@denx.de>
To: Eddie James <eajames@linux.ibm.com>, u-boot@lists.denx.de
Subject: Re: [PATCH] i2c: ast_i2c: Remove SCL direct drive mode
Date: Thu, 12 May 2022 06:49:18 +0200 [thread overview]
Message-ID: <88160323-13f4-e21b-b00a-72b8306720fa@denx.de> (raw)
In-Reply-To: <20220511205203.54982-1-eajames@linux.ibm.com>
Hello Eddie,
On 11.05.22 22:52, Eddie James wrote:
> SCL direct drive mode prevents communication with devices that
> do clock stretching, so disable. The Linux driver doesn't use
> this mode, and the engine can handle clock stretching.
My first thought was why not make this option configurable, as
I do not know if there is any user of this mode configuration.
But as linux does not use this option, we may can disable it.
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> drivers/i2c/ast_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Heiko Schocher <hs@denx.de>
It would be good to have here more comments from users of this driver.
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de
next prev parent reply other threads:[~2022-05-12 4:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 20:52 [PATCH] i2c: ast_i2c: Remove SCL direct drive mode Eddie James
2022-05-12 4:49 ` Heiko Schocher [this message]
2022-05-19 0:28 ` Joel Stanley
2022-05-19 1:55 ` Ryan Chen
2022-07-19 11:53 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88160323-13f4-e21b-b00a-72b8306720fa@denx.de \
--to=hs@denx.de \
--cc=eajames@linux.ibm.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox