From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C53A4C433EF for ; Thu, 12 May 2022 04:49:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1696F84311; Thu, 12 May 2022 06:49:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1652330948; bh=7B+QuBcrdTEkdFSfuqKH9B3AFuZzEL2bLtBMhStjSlU=; h=Subject:To:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Reply-To:From; b=ltioO2qRVQDu1Q7JW0Slz6knvr6q1k6eweLAsX6O4LgI967xhs8IKc86Vd2t6w53c E4UXh3LwvBqT72Y4YrVhtYMnBFveWEzisotSUSMcbO13HpCAmNoCXB334WcgiSReiD x9qXgnbiB7kA9XP+9QmTNUJPwOJxVNgcE05tQOGvAnjrDn/ONugR4/P7Oiy0sIYnqi /yI4CP/iq9JOXBO1rl8hlN/s8IaxUsdhzPk/hKzNHYm0USKVSWvjBDEWFtDsBnYCY7 HLIqMhMBxb5XKjlgcxuPE7dWcxHZUmt9GXlnAsDCba60LlPsvPVFM+pT6RK6I2CpqH ReIoVBSdJ6kTA== Received: from [192.168.1.107] (87-97-104-197.pool.digikabel.hu [87.97.104.197]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hs@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 6228C84216; Thu, 12 May 2022 06:49:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1652330945; bh=7B+QuBcrdTEkdFSfuqKH9B3AFuZzEL2bLtBMhStjSlU=; h=Reply-To:Subject:To:References:From:Date:In-Reply-To:From; b=Z1ih4mNBXWphnhpHtNS2oJ+eQa/m9ca6XEaOxojE5XIcjbbPLTEweZob0PxJJkV1A AfSIEhibiaa8N/fE9ZmxNFaeCkUhAGsCDl76+GlE5Uz8pQj5aSTQgDeakGyqfbzJm0 gMHlxcFAmo7E6lQngVtqRVy365NZIL6eiaKWQQ9gX0Tmjso6BEjlzo+y0ffIB+Mei1 wSE4g44uxXxtzUW9p/Cz5/xkCISUtdp29W3Af6WGfYhQ6ustBkx8ImFQxiW/bsYBOf ShvTxxeNW888V3uFV4h52yw/VQ0H8QC3BLK4pk3vJFE8erzJr8IrCo5g3Epp2VypyZ pWDLrZ4EfapLQ== Subject: Re: [PATCH] i2c: ast_i2c: Remove SCL direct drive mode To: Eddie James , u-boot@lists.denx.de References: <20220511205203.54982-1-eajames@linux.ibm.com> From: Heiko Schocher Message-ID: <88160323-13f4-e21b-b00a-72b8306720fa@denx.de> Date: Thu, 12 May 2022 06:49:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220511205203.54982-1-eajames@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: hs@denx.de Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hello Eddie, On 11.05.22 22:52, Eddie James wrote: > SCL direct drive mode prevents communication with devices that > do clock stretching, so disable. The Linux driver doesn't use > this mode, and the engine can handle clock stretching. My first thought was why not make this option configurable, as I do not know if there is any user of this mode configuration. But as linux does not use this option, we may can disable it. > Signed-off-by: Eddie James > --- > drivers/i2c/ast_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Heiko Schocher It would be good to have here more comments from users of this driver. bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de