Re: [PATCH 019/171] lib: Add a Kconfig for SPL_GENERATE_ACPI_TABLE

Simon Glass
2023-02-05T01:22:19Z

Hi Tom, Heinrich,

On Mon, 30 Jan 2023 at 07:52, Tom Rini <trini@konsulko.com> wrote:
>
> On Mon, Jan 30, 2023 at 03:50:23PM +0100, Heinrich Schuchardt wrote:
> > On 1/30/23 15:40, Simon Glass wrote:
> > > This is implicitly used in the source and seems useful, so add it.
> >
> > Please, provide a clear description how this will be used.
>
> To follow up on what I just sent, Simon seems to be taking a pass at
> adding to Kconfig many / most of the options that aren't available today
> but are implied by the usage of CONFIG_IS_ENABLED(FOO). So, this is
> another case where IS_ENABLED(CONFIG_FOO) should be used.

This is needed for coral, which needs to know whether to include the
code to generate the ACPI tables or not. It needs to be omitted in
SPL, for code-size reasons.

If we use IS_ENABLED() then it will be built into SPL.

Regards,
Simon