Re: [PATCH 000/171] Kconfig: More cleanup of CONFIG options

Tom Rini
2023-01-30T16:12:22Z

[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]

On Mon, Jan 30, 2023 at 07:40:33AM -0700, Simon Glass wrote:

> Quite a few CONFIG options without an SPL equivalent are used as if they
> have one. For example, we see CONFIG_IS_ENABLED(IOMMU) when there is no
> SPL_IOMMU Kconfig option.
>
> This series adds new features to moveconfig to detect and remove these
> problems. It includes additions to the Kconfig for options which are
> needed as well as dropping unwanted us of CONFIG_IS_ENABLED, etc.
>
> This follows on from the previous series[1]
>
> It is available at u-boot-dm/splb-working
>
> [1] https://patchwork.ozlabs.org/project/uboot/list/?series=339004

I'm a little confused at the rush, and duplication right now. As part
off the CONFIG_IS_ENABLED / IS_ENABLED thread, Troy did a series of
patches to convert everyone that's using CONFIG_IS_ENABLED to use
IS_ENABLED, got it through CI and I assumed was trying to figure out how
to get it posted, next. Further, this series does too many things, and
needs a bit more thought. All of the CMD_FOO ones are obviously correct,
but then the majority of the rest of the cases should likely not be
adding a disabled Kconfig option but instead converted as well as it's
most likely people are just silencing the checkpatch.pl message and not
thinking about the ramificationns.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]