Re: [PATCH 020/171] efi: Add a Kconfig for SPL_EFI_LOADER et all

Tom Rini
2023-01-30T14:53:19Z

[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]

On Mon, Jan 30, 2023 at 03:48:44PM +0100, Heinrich Schuchardt wrote:
> On 1/30/23 15:40, Simon Glass wrote:
> > This and EFI_DEVICE_PATH_TO_TEXT are implicitly used in the source and
>
> This code is not compiled in SPL. So it cannot be used there.
>
> > seem useful, so add them.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> >
> > lib/efi_loader/Kconfig | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> > index 9fe9a2df9ea..0bd42b9e196 100644
> > --- a/lib/efi_loader/Kconfig
> > +++ b/lib/efi_loader/Kconfig
> > @@ -32,6 +32,10 @@ config EFI_LOADER
> >
> > if EFI_LOADER
> >
> > +config SPL_EFI_LOADER
> > + def_bool n # Support running UEFI applications (SPL)
> > + depends on SPL
> > +
>
> I cannot see how this could be used:
>
> * The size of the EFI code is too big to fit into SPL on most boards.

OK, so please do a series to correct all CONFIG_IS_ENABLED(EFI_*) to be
IS_ENABLED(CONFIG_EFI_*), other than EFI_PARTITIONS which can be in SPL.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]