Re: [PATCH 020/171] efi: Add a Kconfig for SPL_EFI_LOADER et all

Heinrich Schuchardt
2023-01-30T14:52:53Z

On 1/30/23 15:40, Simon Glass wrote:
> This and EFI_DEVICE_PATH_TO_TEXT are implicitly used in the source and

This code is not compiled in SPL. So it cannot be used there.

> seem useful, so add them.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> lib/efi_loader/Kconfig | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index 9fe9a2df9ea..0bd42b9e196 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -32,6 +32,10 @@ config EFI_LOADER
>
> if EFI_LOADER
>
> +config SPL_EFI_LOADER
> + def_bool n # Support running UEFI applications (SPL)
> + depends on SPL
> +

I cannot see how this could be used:

* The size of the EFI code is too big to fit into SPL on most boards.
* Our EFI code depends on DM.

> config CMD_BOOTEFI_BOOTMGR
> bool "UEFI Boot Manager"
> default y
> @@ -233,6 +237,10 @@ config EFI_DEVICE_PATH_TO_TEXT
> The device path to text protocol converts device nodes and paths to
> human readable strings.
>
> +config SPL_EFI_DEVICE_PATH_TO_TEXT
> + def_bool n # Device path to text protocol (SPL)
> + depends on SPL
> +

The EFI sub-system does not exist in SPL.

Best regards

Heinrich

> config EFI_DEVICE_PATH_UTIL
> bool "Device path utilities protocol"
> default y