Re: [PATCH 015/171] iommu: Add a Kconfig for SPL_IOMMU

Simon Glass
2023-02-05T01:22:05Z

Hi Mark,

On Mon, 30 Jan 2023 at 09:24, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>
> > From: Simon Glass <sjg@chromium.org>
> > Date: Mon, 30 Jan 2023 07:40:48 -0700
> >
> > This is implicitly used in the source and seems useful, so add it.
>
> At this point the IOMMU support isn't used for SPL. While I can't
> rule out we'll see an SoC at some point the needs it, I don't think
> I've seen an SoC that has devices that are typically used in SPL (MMC,
> NOR flash, memory controllers) behind an IOMMU. So switching to
> IS_ENABLED(CONFIG_IOMMU) seems more logical to me.

That's actually not the issue here. If we need an option enabled in
U-Boot proper, but not in SPL, then we need to have an SPL option.
Otherwise it gets enabled in both.

If it were OK to have the feature in SPL always for all boards, we
would not need this.

Regards,
Simon