Re: [PATCH 000/171] Kconfig: More cleanup of CONFIG options

Simon Glass
2023-01-31T15:45:30Z

Hi Tom,

On Mon, 30 Jan 2023 at 08:10, Tom Rini <trini@konsulko.com> wrote:
>
> On Mon, Jan 30, 2023 at 07:40:33AM -0700, Simon Glass wrote:
>
> > Quite a few CONFIG options without an SPL equivalent are used as if they
> > have one. For example, we see CONFIG_IS_ENABLED(IOMMU) when there is no
> > SPL_IOMMU Kconfig option.
> >
> > This series adds new features to moveconfig to detect and remove these
> > problems. It includes additions to the Kconfig for options which are
> > needed as well as dropping unwanted us of CONFIG_IS_ENABLED, etc.
> >
> > This follows on from the previous series[1]
> >
> > It is available at u-boot-dm/splb-working
> >
> > [1] https://patchwork.ozlabs.org/project/uboot/list/?series=339004
>
> I'm a little confused at the rush, and duplication right now. As part
> off the CONFIG_IS_ENABLED / IS_ENABLED thread, Troy did a series of
> patches to convert everyone that's using CONFIG_IS_ENABLED to use
> IS_ENABLED, got it through CI and I assumed was trying to figure out how
> to get it posted, next. Further, this series does too many things, and
> needs a bit more thought. All of the CMD_FOO ones are obviously correct,
> but then the majority of the rest of the cases should likely not be
> adding a disabled Kconfig option but instead converted as well as it's
> most likely people are just silencing the checkpatch.pl message and not
> thinking about the ramificationns.

Most of them have been disabled. The patches you refer to at the front
(which add a disabled option) are because I hit build failures just
trying to convert things away from CONFIG_IS_ENABLED(). I may have
made some errors, of course, as there is alot going on.

The rush is that I'd like to do the split config thing, but keep
hitting problems with the Kconfig:

- mention of options which don't existing in Kconfig (spla series)
- use of options in SPL context when there is no SPL_ option (this series splb)

My goal is 'splc', being a small series to split out the configs...but
it requires a pretty high level of consistency. Perhaps I should send
that out so you get the idea where it is heading?

Regards,
Simon