* [PATCH 1/1] efi_loader remove __packed from struct efi_configuration_table
@ 2019-12-28 14:54 Heinrich Schuchardt
2020-01-07 6:37 ` Heinrich Schuchardt
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2019-12-28 14:54 UTC (permalink / raw)
To: u-boot
struct efi_configuration_table is naturally packed. There is no need for a
__packed attribute. Hence remove it.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
include/efi_api.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/efi_api.h b/include/efi_api.h
index 22396172e1..a3ff140ac9 100644
--- a/include/efi_api.h
+++ b/include/efi_api.h
@@ -322,7 +322,7 @@ struct efi_runtime_services {
struct efi_configuration_table {
efi_guid_t guid;
void *table;
-} __packed;
+};
#define EFI_SYSTEM_TABLE_SIGNATURE ((u64)0x5453595320494249ULL)
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH 1/1] efi_loader remove __packed from struct efi_configuration_table
2019-12-28 14:54 [PATCH 1/1] efi_loader remove __packed from struct efi_configuration_table Heinrich Schuchardt
@ 2020-01-07 6:37 ` Heinrich Schuchardt
0 siblings, 0 replies; 2+ messages in thread
From: Heinrich Schuchardt @ 2020-01-07 6:37 UTC (permalink / raw)
To: u-boot
On 12/28/19 3:54 PM, Heinrich Schuchardt wrote:
> struct efi_configuration_table is naturally packed. There is no need for a
> __packed attribute. Hence remove it.
This holds true only on 64bit systems as we defined efi_guid_t to be
8-byte aligned. Instead adjust guidcpy to accept void *. See
https://lists.denx.de/pipermail/u-boot/2020-January/395409.html
[PATCH v5 1/1] efi_loader: Add guidcpy function
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> include/efi_api.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/efi_api.h b/include/efi_api.h
> index 22396172e1..a3ff140ac9 100644
> --- a/include/efi_api.h
> +++ b/include/efi_api.h
> @@ -322,7 +322,7 @@ struct efi_runtime_services {
> struct efi_configuration_table {
> efi_guid_t guid;
> void *table;
> -} __packed;
> +};
>
> #define EFI_SYSTEM_TABLE_SIGNATURE ((u64)0x5453595320494249ULL)
>
> --
> 2.24.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-07 6:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-28 14:54 [PATCH 1/1] efi_loader remove __packed from struct efi_configuration_table Heinrich Schuchardt
2020-01-07 6:37 ` Heinrich Schuchardt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox