From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBC06C001B0 for ; Wed, 26 Jul 2023 16:28:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C02688691D; Wed, 26 Jul 2023 18:28:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id CE250819EB; Wed, 26 Jul 2023 18:28:10 +0200 (CEST) Received: from mail-m11886.qiye.163.com (mail-m11886.qiye.163.com [115.236.118.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5EDFC86900 for ; Wed, 26 Jul 2023 18:27:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11886.qiye.163.com (Hmail) with ESMTPA id B39F1802E2; Wed, 26 Jul 2023 19:00:52 +0800 (CST) Message-ID: <897f2a69-e50b-ff56-c31b-b54a3255b5f1@rock-chips.com> Date: Wed, 26 Jul 2023 19:00:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 3/7] usb: dwc3-generic: Restrict single ctrl node for RK3328 Content-Language: en-US To: Jagan Teki , Simon Glass , Philipp Tomsich Cc: Jonas Karlman , u-boot@lists.denx.de, linux-amarula@amarulasolutions.com, Marek Vasut References: <20230606170918.45581-1-jagan@amarulasolutions.com> <20230606170918.45581-4-jagan@amarulasolutions.com> From: Kever Yang In-Reply-To: <20230606170918.45581-4-jagan@amarulasolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQh1LGVYfQ0NJGR0aGkoYQ0NVEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSk5MSUpJVUpLS1VKQl kG X-HM-Tid: 0a8991dbdeb12ebakusnb39f1802e2 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PTo6HTo5Kz0CSEMpEh45HEgR EzZPFCJVSlVKTUJLSE1CSU5IT01CVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFJQ01CNwY+ X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2023/6/7 01:09, Jagan Teki wrote: > Like Rockchip RK3568, the RK3328 also have single node to > represent the glue and ctrl for USB 3.0. > > So, use the driver data to use single ctrl for RK3328 DWC3. > > Reviewed-by: Marek Vasut > Signed-off-by: Jagan Teki Reviewed-by: Kever Yang Thanks, - Kever > --- > Changes for v2: > - collect Marek RB > > drivers/usb/dwc3/dwc3-generic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c > index 5f8c2613a4..dcf420bafd 100644 > --- a/drivers/usb/dwc3/dwc3-generic.c > +++ b/drivers/usb/dwc3/dwc3-generic.c > @@ -621,7 +621,7 @@ static const struct udevice_id dwc3_glue_ids[] = { > { .compatible = "ti,dwc3", .data = (ulong)&ti_ops }, > { .compatible = "ti,am437x-dwc3", .data = (ulong)&ti_ops }, > { .compatible = "ti,am654-dwc3" }, > - { .compatible = "rockchip,rk3328-dwc3" }, > + { .compatible = "rockchip,rk3328-dwc3", .data = (ulong)&rk_ops }, > { .compatible = "rockchip,rk3399-dwc3" }, > { .compatible = "rockchip,rk3568-dwc3", .data = (ulong)&rk_ops }, > { .compatible = "qcom,dwc3" },