From: Lokesh Vutla <lokeshvutla@ti.com>
To: u-boot@lists.denx.de
Subject: [PATCH 03/26] remoteproc: k3-r5: remove sysfw PM calls if not supported
Date: Sun, 15 Nov 2020 15:59:42 +0530 [thread overview]
Message-ID: <89dd9dcc-ea2d-3755-e40d-0a2acb8c010a@ti.com> (raw)
In-Reply-To: <20201110090602.2255-4-t-kristo@ti.com>
On 10/11/20 2:35 pm, Tero Kristo wrote:
> With the sysfw rearch, sysfw PM calls are no longer available from SPL
> level. To properly support this, remove the is_on checks and the reset
> assertion from the R5 remoteproc driver as these are not supported.
> Attempting to access unavailable services will cause the device to hang.
>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> ---
> drivers/remoteproc/ti_k3_r5f_rproc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/remoteproc/ti_k3_r5f_rproc.c b/drivers/remoteproc/ti_k3_r5f_rproc.c
> index 9332a63d21..b2902e7fd3 100644
> --- a/drivers/remoteproc/ti_k3_r5f_rproc.c
> +++ b/drivers/remoteproc/ti_k3_r5f_rproc.c
> @@ -781,7 +781,9 @@ static int k3_r5f_probe(struct udevice *dev)
> {
> struct k3_r5f_cluster *cluster = dev_get_priv(dev->parent);
> struct k3_r5f_core *core = dev_get_priv(dev);
> +#ifdef CONFIG_CLK_TI_SCI
Since we are checking for device state, can you make this guard under power
domain instead of clock?
> bool r_state;
> +#endif
> int ret;
>
> dev_dbg(dev, "%s\n", __func__);
> @@ -804,6 +806,7 @@ static int k3_r5f_probe(struct udevice *dev)
> return ret;
> }
>
> +#ifdef CONFIG_CLK_TI_SCI
Can you also add a comment here on why we are doing this?
Thanks and regards,
Lokesh
> ret = core->tsp.sci->ops.dev_ops.is_on(core->tsp.sci, core->tsp.dev_id,
> &r_state, &core->in_use);
> if (ret)
> @@ -817,6 +820,7 @@ static int k3_r5f_probe(struct udevice *dev)
>
> /* Make sure Local reset is asserted. Redundant? */
> reset_assert(&core->reset);
> +#endif
>
> ret = k3_r5f_rproc_configure(core);
> if (ret) {
>
next prev parent reply other threads:[~2020-11-15 10:29 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 9:05 [PATCH 00/26] TI J7 SoC HSM Rearch support series Tero Kristo
2020-11-10 9:05 ` [PATCH 01/26] lib: rational: copy the rational fraction lib routines from Linux Tero Kristo
2020-11-10 12:55 ` Tom Rini
2020-11-11 7:03 ` Tero Kristo
2020-11-10 9:05 ` [PATCH 02/26] ram: k3-j721e: fix clk_set_rate API usage Tero Kristo
2020-11-10 9:05 ` [PATCH 03/26] remoteproc: k3-r5: remove sysfw PM calls if not supported Tero Kristo
2020-11-15 10:29 ` Lokesh Vutla [this message]
2020-11-16 12:08 ` Tero Kristo
2020-11-10 9:05 ` [PATCH 04/26] common: fit: Update board_fit_image_post_process() to pass fit and node_offset Tero Kristo
2020-11-10 9:05 ` [PATCH 05/26] clk: fixed_rate: add API for directly registering fixed rate clocks Tero Kristo
2020-11-15 10:27 ` Lokesh Vutla
2020-11-16 0:42 ` Peng Fan
2020-11-10 9:05 ` [PATCH 06/26] clk: fix clock tree dump to properly dump out every registered clock Tero Kristo
2020-11-15 10:28 ` Lokesh Vutla
2020-11-10 9:05 ` [PATCH 07/26] clk: do not attempt to fetch clock pointer with null device Tero Kristo
2020-11-10 9:05 ` [PATCH 08/26] clk: add support for setting clk rate from cmdline Tero Kristo
2020-11-15 10:29 ` Lokesh Vutla
2020-11-16 12:06 ` Tero Kristo
2020-11-16 14:26 ` Lukasz Majewski
2020-11-10 9:05 ` [PATCH 09/26] clk: sci-clk: fix return value of set_rate Tero Kristo
2020-11-10 9:05 ` [PATCH 10/26] clk: fix assigned-clocks to pass with deferring provider Tero Kristo
2020-11-10 9:05 ` [PATCH 11/26] clk: fix set_rate to clean up cached rates for the hierarchy Tero Kristo
2020-11-10 9:05 ` [PATCH 12/26] clk: add support for TI K3 SoC PLL Tero Kristo
2020-11-10 9:05 ` [PATCH 13/26] clk: add support for TI K3 SoC clocks Tero Kristo
2020-11-10 9:05 ` [PATCH 14/26] power: domain: Introduce driver for raw TI K3 PDs Tero Kristo
2020-11-10 9:05 ` [PATCH 15/26] cmd: ti: pd: Add debug command for K3 power domains Tero Kristo
2020-11-10 9:05 ` [PATCH 16/26] tools: k3_fit_atf: add DM binary to the FIT image Tero Kristo
2020-11-10 9:05 ` [PATCH 17/26] arm: mach-k3: Add platform data for j721e and j7200 Tero Kristo
2020-11-10 9:05 ` [PATCH 18/26] arm: mach-k3: add support for detecting firmware images from FIT Tero Kristo
2020-11-10 9:05 ` [PATCH 19/26] arm: mach-k3: j721e: force enable A72 core 0 during spl shutdown Tero Kristo
2020-11-16 4:21 ` Lokesh Vutla
2020-11-16 12:22 ` Tero Kristo
2020-11-10 9:05 ` [PATCH 20/26] arm: mach-k3: do board config for PM and RM only if supported Tero Kristo
2020-11-16 4:23 ` Lokesh Vutla
2020-11-16 12:27 ` Tero Kristo
2020-11-17 6:14 ` Lokesh Vutla
2020-11-17 9:22 ` Tero Kristo
2020-11-18 10:23 ` Tero Kristo
2020-11-10 9:05 ` [PATCH 21/26] arm: mach-k3: common: Drop main r5 start Tero Kristo
2020-11-16 4:24 ` Lokesh Vutla
2020-11-16 12:28 ` Tero Kristo
2020-11-10 9:05 ` [PATCH 22/26] arm: mach-k3: sysfw-loader: pass boardcfg to sciserver Tero Kristo
2020-11-10 9:05 ` [PATCH 23/26] configs: j721e_evm_r5: Enable raw access power management features Tero Kristo
2020-11-10 9:06 ` [PATCH 24/26] configs: j721e_evm_r5: disable SCI PM drivers Tero Kristo
2020-11-10 9:06 ` [PATCH 25/26] configs: j721e_evm_r5: enable FIT image post processing Tero Kristo
2020-11-10 9:06 ` [PATCH 26/26] configs: j7200_evm_r5: Enable raw access power management features Tero Kristo
2020-11-16 4:13 ` [PATCH 00/26] TI J7 SoC HSM Rearch support series Lokesh Vutla
2020-11-16 12:13 ` Tero Kristo
2020-11-16 15:53 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89dd9dcc-ea2d-3755-e40d-0a2acb8c010a@ti.com \
--to=lokeshvutla@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox