From: Teh Kok How <khteh@smartbridges.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH]: common/cmd_flash.c: bug-fix
Date: Mon, 22 Feb 2010 13:36:37 +0800 [thread overview]
Message-ID: <8F43DBAAFE554067877FD8568CAB4FDC@smartbridges.com> (raw)
In-Reply-To: <20100212152732.85063E8CCE4@gemini.denx.de>
Hi Wolfgang;
Sorry, been away for 1 week. The constant 10 is the size of an array
that is arbitrarily chosen so that it is big enough to hold the current mtd
device identifier such as nor0, nor1, nor2, nand0, nand1, nand2, etc.
Regards,
KH
-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Friday, February 12, 2010 11:28 PM
To: Teh Kok How
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH]: common/cmd_flash.c: bug-fix
Dear "Teh Kok How",
In message <89D4E2CB6B654B3FB0DA6A0CE6650515@smartbridges.com> you wrote:
>
> --- u-boot-2009.11.1.orig/common/cmd_flash.c 2010-01-25
> 16:35:12.000000000 +0800
> +++ u-boot-2009.11.1.new/common/cmd_flash.c 2010-02-12
> 16:18:10.565540182 +0800
> @@ -43,6 +43,7 @@
>
> #ifndef CONFIG_SYS_NO_FLASH
> extern flash_info_t flash_info[]; /* info for FLASH chips */
> +extern struct mtd_device *current_mtd_dev;
>
> /*
> * The user interface starts numbering for Flash banks with 1
> @@ -331,6 +332,7 @@
> u8 dev_type, dev_num, pnum;
> #endif
> int rcode = 0;
> + char mtd_dev[10];
Where is this magic constant 10 coming from?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Why is an average signature file longer than an average Perl script??
next prev parent reply other threads:[~2010-02-22 5:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 8:31 [U-Boot] [PATCH]: common/cmd_flash.c: bug-fix Teh Kok How
2010-02-12 9:00 ` Stefan Roese
2010-02-12 9:16 ` Teh Kok How
2010-02-12 10:19 ` Stefan Roese
2010-02-12 10:35 ` [U-Boot] [PATCH]: common/cmd_flash.c: Fix mtdparts usage in "erase" and "protect" Teh Kok How
2010-02-12 15:32 ` Wolfgang Denk
2010-02-12 15:27 ` [U-Boot] [PATCH]: common/cmd_flash.c: bug-fix Wolfgang Denk
2010-02-22 5:36 ` Teh Kok How [this message]
2010-02-22 8:28 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8F43DBAAFE554067877FD8568CAB4FDC@smartbridges.com \
--to=khteh@smartbridges.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox