From: Stefan Agner <stefan@agner.ch>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] colibri_vf: Add board_usb_phy_mode function
Date: Fri, 30 Oct 2015 09:26:25 -0700 [thread overview]
Message-ID: <8a41f98b787bf99c7bb5efec36f14a37@agner.ch> (raw)
In-Reply-To: <201510301724.52271.marex@denx.de>
On 2015-10-30 09:24, Marek Vasut wrote:
> On Friday, October 30, 2015 at 05:12:54 PM, Stefan Agner wrote:
>> Hi All,
>
> Hi!
>
>> On 2015-10-30 05:26, Sanchayan Maity wrote:
>> > +
>> > +int board_usb_phy_mode(int port)
>> > +{
>> > + switch (port) {
>> > + case 0:
>> > + return gpio_get_value(USB_CDET_GPIO);
>> > + break;
>> > + case 1:
>> > + return USB_INIT_HOST;
>> > + break;
>> > + default:
>> > + return USB_INIT_HOST;
>> > + break;
>>
>> One thing I would like to note in this whole discussion is that the old
>> setup is kind of the "default" role of each dual-role controller: The
>> boot ROM uses USB1 as client, the tower board uses this configuration
>> too... So maybe we could/should keep that default role at least in here?
>
> Well we cannot, since this is a custom board, right ?
Ah sorry, the switch statement is enumerating the port numbers, hence
this default refers to ports > 2. Somehow read that the wrong way
around.
Sorry for the noise.
--
Stefan
next prev parent reply other threads:[~2015-10-30 16:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 12:58 [U-Boot] [PATCH 1/3] usb: host: ehci-vf: Remove hardcoded USB host client configuration Sanchayan Maity
2015-10-26 12:58 ` [U-Boot] [PATCH 2/3] usb: host: ehci-vf: Implement board_usb_phy_mode weak function Sanchayan Maity
2016-01-08 12:22 ` maitysanchayan at gmail.com
2016-01-08 14:02 ` Marek Vasut
2015-10-26 12:58 ` [U-Boot] [PATCH 3/3] colibri_vf: Add board_usb_phy_mode function Sanchayan Maity
2015-10-27 9:18 ` Marek Vasut
2015-10-27 11:34 ` maitysanchayan at gmail.com
2015-10-29 10:15 ` [U-Boot] [PATCH v2] " Sanchayan Maity
2015-10-29 17:25 ` Marek Vasut
2015-10-30 12:26 ` [U-Boot] [PATCH v3] " Sanchayan Maity
2015-10-30 13:20 ` Marek Vasut
2015-11-06 7:00 ` maitysanchayan at gmail.com
2015-11-06 15:00 ` Marek Vasut
2015-10-30 16:12 ` Stefan Agner
2015-10-30 16:24 ` Marek Vasut
2015-10-30 16:26 ` Stefan Agner [this message]
2015-10-30 17:07 ` Marek Vasut
2015-11-09 14:59 ` [U-Boot] [PATCH v4] " Sanchayan Maity
2015-11-09 15:22 ` Marek Vasut
2015-11-12 6:17 ` [U-Boot] [PATCH v5] " Sanchayan Maity
2015-11-24 10:23 ` maitysanchayan at gmail.com
2015-11-24 10:30 ` Marek Vasut
2015-11-24 10:37 ` Stefano Babic
2015-11-24 10:38 ` maitysanchayan at gmail.com
2016-01-07 20:02 ` maitysanchayan at gmail.com
2016-01-07 21:12 ` Stefano Babic
2016-01-08 5:50 ` maitysanchayan at gmail.com
2016-01-08 12:11 ` Marek Vasut
2016-01-08 12:18 ` maitysanchayan at gmail.com
2016-01-08 12:25 ` Marek Vasut
2015-10-26 19:19 ` [U-Boot] [PATCH 1/3] usb: host: ehci-vf: Remove hardcoded USB host client configuration Marek Vasut
2015-10-27 3:28 ` maitysanchayan at gmail.com
2016-01-08 12:20 ` maitysanchayan at gmail.com
2016-01-08 12:26 ` Marek Vasut
2016-01-08 12:26 ` maitysanchayan at gmail.com
2016-01-08 14:02 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a41f98b787bf99c7bb5efec36f14a37@agner.ch \
--to=stefan@agner.ch \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox