From: Tirumala Marri <tmarri@apm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/8] APM82xxx: Add SRAM support
Date: Mon, 30 Aug 2010 10:43:55 -0700 [thread overview]
Message-ID: <8a743b6a146f57340881bebd4e31d41f@mail.gmail.com> (raw)
In-Reply-To: <4C778FE7.40401@mvista.com>
>
> > Signed-off-by: Tirumala R Marri <tmarri@apm.com>
> [...]
> > diff --git a/arch/powerpc/include/asm/ppc4xx-isram.h
> b/arch/powerpc/include/asm/ppc4xx-isram.h
> > index d6d17ac..b723401 100644
> > --- a/arch/powerpc/include/asm/ppc4xx-isram.h
> > +++ b/arch/powerpc/include/asm/ppc4xx-isram.h
> > @@ -25,7 +25,8 @@
> > /*
> > * Internal SRAM
> > */
> > -#if defined(CONFIG_440EPX) || defined(CONFIG_440GRX)
> > +#if defined(CONFIG_440EPX) || defined(CONFIG_440GRX) ||\
>
> Please add space before \ to keep the style consistent.
[Marri] Sure will do
>
> > + defined(CONFIG_APM82XXX)
> > #define ISRAM0_DCR_BASE 0x380
> > #else
> > #define ISRAM0_DCR_BASE 0x020
> > @@ -42,7 +43,8 @@
> > #define ISRAM0_REVID (ISRAM0_DCR_BASE+0x09) /* SRAM bus
revision id
> reg */
> > #define ISRAM0_DPC (ISRAM0_DCR_BASE+0x0a) /* SRAM data parity
> check reg */
> >
> > -#if defined(CONFIG_460EX) || defined(CONFIG_460GT)
> > +#if defined(CONFIG_460EX) || defined(CONFIG_460GT) ||\
>
> Same here...
[Marri] Ok
>
> > + defined(CONFIG_APM82XXX)
> > #define ISRAM1_DCR_BASE 0x0B0
> > #define ISRAM1_SB0CR (ISRAM1_DCR_BASE+0x00) /* SRAM1 bank
config
> 0*/
> > #define ISRAM1_BEAR (ISRAM1_DCR_BASE+0x04) /* SRAM1 bus error
addr
> reg */
Regards,
Marri
prev parent reply other threads:[~2010-08-30 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 21:06 [U-Boot] [PATCH 6/8] APM82xxx: Add SRAM support tmarri at apm.com
2010-08-27 10:13 ` Sergei Shtylyov
2010-08-30 17:43 ` Tirumala Marri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a743b6a146f57340881bebd4e31d41f@mail.gmail.com \
--to=tmarri@apm.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox