From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CBFBC54EAA for ; Mon, 30 Jan 2023 15:01:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 033F8857F7; Mon, 30 Jan 2023 16:01:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="clIsUBPJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 19CAC857F6; Mon, 30 Jan 2023 15:54:30 +0100 (CET) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4DF0D857C6 for ; Mon, 30 Jan 2023 15:54:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x835.google.com with SMTP id bb40so2723162qtb.2 for ; Mon, 30 Jan 2023 06:54:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XbGfTVVreImMQ0ZRRotBB7u7s7rZKOpC9e2KisW7Hpo=; b=clIsUBPJIJtxDMstFYNj7yaIJHFLS+625y7rM2PtGNGpullIzAdYYJ2sJG3wQhcV0S 69EFNszBS/g/t9Glk9WGkyMldNMpu+V/pp8YIc1AqzFp6dujajz7LTwOn2rbTxbkhMAu o2sh45sr57OWYh9lJp3SvdsvKjwcgpDXyitDZLEqpw/28Rd9CoRCJqdV7m9cKjCWYVMP m1rIXvsSsbOwhAgP0uPkrhEBSQMABoN8vIcFQbfVRP/tdZ+DGhg/VlfaDKIPPn0MaPqH dv73yhGtbuXGdCX7uW5CHIlqQ6P32/xE0p9mcE7ZQ+w+W+AbROKWYhAlaTh+6oSXZY1/ ISYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XbGfTVVreImMQ0ZRRotBB7u7s7rZKOpC9e2KisW7Hpo=; b=3qk8WeBHaYMnGIAZgL1S1lSWAoUgzBCQ7JLQkyDtbvmCyKLy6aQAEm+e7PH8M7Mv7d Zb+/4q0eqFTkbMqly8Jk27MQYBEC2C3oUWIl4/lyloT4TNf7EQhSLL1H4C9FnSbGB4os qwqD1jmnh0O/xuTqjQ+RsSSe1Dp1rZK2kiR9L+rn23Qlcm0DcK7VLez/qzAOtvRULdF+ 4P5SVTzVQW7ReY+CT2qAVNBXIWjQR+1bKJj5U8P7yjsfgdw+yNF86vjB4KH8FMFNsA3s u4SF8NwNgjQewEoAaY5Vj4tv0HZZ7STtis97RcZ2XwhnnxkC/5d+kzo6Z5BXpbXqbMBj MxEg== X-Gm-Message-State: AO0yUKUFFuOohPIjwG28g07KApNkIjyitiWDsTTJN1pRGqvrl47z4dUE Y7zUFoyGZM3h0rXOURy5137TRuy1zGw= X-Google-Smtp-Source: AK7set/qWVmLMDC0CjbIeAtGVYfCI16L4gmFik1UI7HbHRpYeGhJ9sjkgzGaCQaFJl/RIlW2JMSqIA== X-Received: by 2002:ac8:5f50:0:b0:3b8:2a6c:d1e4 with SMTP id y16-20020ac85f50000000b003b82a6cd1e4mr19557423qta.23.1675090453770; Mon, 30 Jan 2023 06:54:13 -0800 (PST) Received: from [192.168.1.201] (pool-173-73-95-180.washdc.fios.verizon.net. [173.73.95.180]) by smtp.gmail.com with ESMTPSA id d28-20020ac800dc000000b003b0b903720esm1293196qtg.13.2023.01.30.06.54.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 06:54:13 -0800 (PST) Message-ID: <8b185187-6b45-48d0-837a-aa7bb0aca1fe@gmail.com> Date: Mon, 30 Jan 2023 09:54:12 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 042/171] Correct SPL uses of CMD_CLK Content-Language: en-US To: Simon Glass , U-Boot Mailing List Cc: Tom Rini , Lukasz Majewski References: <20230130144324.206208-1-sjg@chromium.org> <20230130144324.206208-43-sjg@chromium.org> From: Sean Anderson In-Reply-To: <20230130144324.206208-43-sjg@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 1/30/23 09:41, Simon Glass wrote: > This converts 7 usages of this option to the non-SPL form, since there is > no SPL_CMD_CLK defined in Kconfig > > Signed-off-by: Simon Glass > --- > > drivers/clk/clk_k210.c | 6 +++--- > drivers/clk/imx/clk-imx8.c | 2 +- > drivers/clk/imx/clk-imx8.h | 2 +- > drivers/clk/imx/clk-imx8qm.c | 2 +- > drivers/clk/imx/clk-imx8qxp.c | 2 +- > 5 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/clk/clk_k210.c b/drivers/clk/clk_k210.c > index f7d36963f85..c534cc07e09 100644 > --- a/drivers/clk/clk_k210.c > +++ b/drivers/clk/clk_k210.c > @@ -308,7 +308,7 @@ enum k210_clk_flags { > * @gate: An &enum k210_gate_id of this clock's gate > */ > struct k210_clk_params { > -#if CONFIG_IS_ENABLED(CMD_CLK) > +#if IS_ENABLED(CONFIG_CMD_CLK) > const char *name; > #endif > u8 flags; > @@ -326,7 +326,7 @@ struct k210_clk_params { > }; > > static const struct k210_clk_params k210_clks[] = { > -#if CONFIG_IS_ENABLED(CMD_CLK) > +#if IS_ENABLED(CONFIG_CMD_CLK) > #define NAME(_name) .name = (_name), > #else > #define NAME(name) > @@ -1284,7 +1284,7 @@ U_BOOT_DRIVER(k210_clk) = { > .priv_auto = sizeof(struct k210_clk_priv), > }; > > -#if CONFIG_IS_ENABLED(CMD_CLK) > +#if IS_ENABLED(CONFIG_CMD_CLK) > static char show_enabled(struct k210_clk_priv *priv, int id) > { > bool enabled; > diff --git a/drivers/clk/imx/clk-imx8.c b/drivers/clk/imx/clk-imx8.c > index b3dc138c4bb..24bdab28aa4 100644 > --- a/drivers/clk/imx/clk-imx8.c > +++ b/drivers/clk/imx/clk-imx8.c > @@ -42,7 +42,7 @@ static int imx8_clk_enable(struct clk *clk) > return __imx8_clk_enable(clk, 1); > } > > -#if CONFIG_IS_ENABLED(CMD_CLK) > +#if IS_ENABLED(CONFIG_CMD_CLK) > int soc_clk_dump(void) > { > struct udevice *dev; > diff --git a/drivers/clk/imx/clk-imx8.h b/drivers/clk/imx/clk-imx8.h > index 68ad6755e80..6e850ba2666 100644 > --- a/drivers/clk/imx/clk-imx8.h > +++ b/drivers/clk/imx/clk-imx8.h > @@ -9,7 +9,7 @@ struct imx8_clks { > const char *name; > }; > > -#if CONFIG_IS_ENABLED(CMD_CLK) > +#if IS_ENABLED(CONFIG_CMD_CLK) > extern struct imx8_clks imx8_clk_names[]; > extern int num_clks; > #endif > diff --git a/drivers/clk/imx/clk-imx8qm.c b/drivers/clk/imx/clk-imx8qm.c > index 7759dc63ee1..b874915ba6a 100644 > --- a/drivers/clk/imx/clk-imx8qm.c > +++ b/drivers/clk/imx/clk-imx8qm.c > @@ -16,7 +16,7 @@ > > #include "clk-imx8.h" > > -#if CONFIG_IS_ENABLED(CMD_CLK) > +#if IS_ENABLED(CONFIG_CMD_CLK) > struct imx8_clks imx8_clk_names[] = { > { IMX8QM_A53_DIV, "A53_DIV" }, > { IMX8QM_UART0_CLK, "UART0" }, > diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c > index ffa2fcee0b2..d580b437221 100644 > --- a/drivers/clk/imx/clk-imx8qxp.c > +++ b/drivers/clk/imx/clk-imx8qxp.c > @@ -16,7 +16,7 @@ > > #include "clk-imx8.h" > > -#if CONFIG_IS_ENABLED(CMD_CLK) > +#if IS_ENABLED(CONFIG_CMD_CLK) > struct imx8_clks imx8_clk_names[] = { > { IMX8QXP_A35_DIV, "A35_DIV" }, > { IMX8QXP_I2C0_CLK, "I2C0" }, Reviewed-by: Sean Anderson