From: Casey Connolly <casey.connolly@linaro.org>
To: Sumit Garg <sumit.garg@kernel.org>, u-boot-qcom@groups.io
Cc: neil.armstrong@linaro.org, trini@konsulko.com,
dmitry.baryshkov@oss.qualcomm.com, u-boot@lists.denx.de,
Sumit Garg <sumit.garg@oss.qualcomm.com>
Subject: Re: [PATCH v2] qcom_defconfig: Add VID/PID to represent fastboot device
Date: Fri, 25 Jul 2025 15:20:41 +0200 [thread overview]
Message-ID: <8c21bb95-8eb0-4c27-be0b-e89cefa12fe3@linaro.org> (raw)
In-Reply-To: <20250724111911.67872-1-sumit.garg@kernel.org>
On 24/07/2025 13:19, Sumit Garg wrote:
> From: Sumit Garg <sumit.garg@oss.qualcomm.com>
>
> Currently fastboot mode is enumerated as VID/PID: 0000:0000 which is
> not appropriate. On Qcom platforms, fastboot mode is rather enumerated
> as VID/PID: 18d1:d00d in ABL or from fastboot.efi app. So lets use the
> same VID/PID pair in U-Boot to represent fastboot mode.
>
> Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
Reviewed-by: Casey Connolly <casey.connolly@linaro.org>
> ---
>
> Changes in v2:
> - Rebased to tip of master since v1 didn't apply cleanly there.
>
> configs/qcom_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
> index b9ba7a677d9..4e24a43b888 100644
> --- a/configs/qcom_defconfig
> +++ b/configs/qcom_defconfig
> @@ -140,6 +140,8 @@ CONFIG_USB_XHCI_DWC3=y
> CONFIG_USB_DWC3=y
> CONFIG_USB_DWC3_GENERIC=y
> CONFIG_USB_GADGET=y
> +CONFIG_USB_GADGET_VENDOR_NUM=0x18d1
> +CONFIG_USB_GADGET_PRODUCT_NUM=0xd00d
> CONFIG_USB_FUNCTION_MASS_STORAGE=y
> CONFIG_UFS=y
> CONFIG_QCOM_UFS=y
--
// Casey (she/her)
next prev parent reply other threads:[~2025-07-25 13:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 11:19 [PATCH v2] qcom_defconfig: Add VID/PID to represent fastboot device Sumit Garg
2025-07-24 11:42 ` neil.armstrong
2025-07-25 13:20 ` Casey Connolly [this message]
2025-08-13 13:50 ` Casey Connolly
2025-08-14 5:48 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c21bb95-8eb0-4c27-be0b-e89cefa12fe3@linaro.org \
--to=casey.connolly@linaro.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=neil.armstrong@linaro.org \
--cc=sumit.garg@kernel.org \
--cc=sumit.garg@oss.qualcomm.com \
--cc=trini@konsulko.com \
--cc=u-boot-qcom@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox