From: Stefan Roese <sr@denx.de>
To: "Marek Behún" <kabel@kernel.org>, "Tom Rini" <trini@konsulko.com>
Cc: u-boot@lists.denx.de, pali@kernel.org,
"Marek Behún" <marek.behun@nic.cz>
Subject: Re: [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port
Date: Wed, 23 Mar 2022 07:46:40 +0100 [thread overview]
Message-ID: <8d6e84f8-e7da-b204-814e-ce3d86cbcc02@denx.de> (raw)
In-Reply-To: <21b4f647-c7ae-60e3-6ec3-a6f5a2ae8ec3@denx.de>
Added Tom to Cc.
On 3/23/22 06:55, Stefan Roese wrote:
> On 3/22/22 17:17, Marek Behún wrote:
>> From: Marek Behún <marek.behun@nic.cz>
>>
>> Commit 0934dddc6436 ("arm: a37xx: Update DTS files to version from
>> upstream Linux kernel") ported Linux's device-tree files for Armada 3720
>> SOCs. This broke USB port on Turris MOX, because in Linux' DTS the bus
>> voltage supply is described as a `phy-supply` property of connector
>> node, a mechanism that is not supported in U-Boot yet.
>>
>> For now, fix this by adding `vbus-supply` to usb3 node.
>>
>> Fixes: 0934dddc6436 ("arm: a37xx: Update DTS files to version from
>> upstream Linux kernel")
>> Signed-off-by: Marek Behún <marek.behun@nic.cz>
>
> Reviewed-by: Stefan Roese <sr@denx.de>
>
>> ---
>> Dear Stefan, as with the network issue, could we get this to master ASAP?
>
> Sure. Let me try...
Tom, I'm having trouble with CI, Azure and Gitlab both report problems
with "test.py coreboot":
https://dev.azure.com/sr0718/u-boot/_build/results?buildId=167&view=results
This should not result from this patch though.
Could you please pull this patch/fix directly?
Thanks,
Stefan
> Thanks,
> Stefan
>
>> ---
>> arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
>> b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
>> index 2e05b973d2..28a36a6103 100644
>> --- a/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
>> +++ b/arch/arm/dts/armada-3720-turris-mox-u-boot.dtsi
>> @@ -21,3 +21,7 @@
>> };
>> /delete-node/ &mdio;
>> +
>> +&usb3 {
>> + vbus-supply = <&exp_usb3_vbus>;
>> +};
>
> Viele Grüße,
> Stefan Roese
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
next prev parent reply other threads:[~2022-03-23 6:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 16:17 [PATCH u-boot-marvell] arm: mvebu: dts: turris_mox: fix non-working USB port Marek Behún
2022-03-23 5:55 ` Stefan Roese
2022-03-23 6:46 ` Stefan Roese [this message]
2022-03-23 11:46 ` Tom Rini
2022-03-23 13:00 ` Pali Rohár
2022-03-23 13:05 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d6e84f8-e7da-b204-814e-ce3d86cbcc02@denx.de \
--to=sr@denx.de \
--cc=kabel@kernel.org \
--cc=marek.behun@nic.cz \
--cc=pali@kernel.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox