Re: [PATCH] efi_loader: Select EVENT as well

Jan Kiszka
2022-04-28T10:03:53Z

On 27.04.22 07:55, AKASHI Takahiro wrote:
> On Wed, Apr 27, 2022 at 07:47:15AM +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Fixes
>>
>> WARNING: unmet direct dependencies detected for EVENT_DYNAMIC
>> Depends on [n]: EVENT [=n]
>> Selected by [y]:
>> - EFI_LOADER [=y] && OF_LIBFDT [=y] && ...
>>
>> and the succeeding build breakage.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> lib/efi_loader/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
>> index 6b245f50a72..1bfb9ddbda9 100644
>> --- a/lib/efi_loader/Kconfig
>> +++ b/lib/efi_loader/Kconfig
>> @@ -15,6 +15,7 @@ config EFI_LOADER
>> depends on !EFI_APP
>> default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
>> select DM_EVENT
>> + select EVENT
>
> I wonder why DM_EVENT does not *select*, but implies EVENT.
> Should any subsystem relying on DM_EVENT work without EVENT?
> -> Simon?
>

Looks like you forgot to CC him.

Jan

> -Takahiro Akashi
>
>> select EVENT_DYNAMIC
>> select LIB_UUID
>> imply PARTITION_UUIDS
>> --
>> 2.34.1

--
Siemens AG, Technology
Competence Center Embedded Linux