Re: [PATCH] efi_loader: Select EVENT as well

Jan Kiszka
2022-05-03T05:00:44Z

On 28.04.22 13:04, Heinrich Schuchardt wrote:
> On 4/28/22 12:03, Jan Kiszka wrote:
>> On 27.04.22 07:55, AKASHI Takahiro wrote:
>>> On Wed, Apr 27, 2022 at 07:47:15AM +0200, Jan Kiszka wrote:
>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>
>>>> Fixes
>>>>
>>>> WARNING: unmet direct dependencies detected for EVENT_DYNAMIC
>>>>    Depends on [n]: EVENT [=n]
>>>>    Selected by [y]:
>>>>    - EFI_LOADER [=y] && OF_LIBFDT [=y] && ...
>>>>
>>>> and the succeeding build breakage.
>>>>
>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>>> ---
>>>>   lib/efi_loader/Kconfig | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
>>>> index 6b245f50a72..1bfb9ddbda9 100644
>>>> --- a/lib/efi_loader/Kconfig
>>>> +++ b/lib/efi_loader/Kconfig
>>>> @@ -15,6 +15,7 @@ config EFI_LOADER
>>>>       depends on !EFI_APP
>>>>       default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
>>>>       select DM_EVENT
>>>> +    select EVENT
>
> event_notify_null() used for the DM_EVENT implementation is not
> available without EVENT.

It is a static inline stub in that case.

>
> Please, let DM_EVENT select on EVENT (drivers/core/Kconfig).
>

Just tested with a qemu target, and there is no generic build dependency
of DM_EVENT on EVENT.

The problem here is that EFI_LOADER selects EVENT_DYNAMIC but not EVENT,
and that cannot work because the former depends on the latter.

Jan

--
Siemens AG, Technology
Competence Center Embedded Linux