From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 122AEC433F5 for ; Wed, 20 Oct 2021 21:41:30 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 754E7610E6 for ; Wed, 20 Oct 2021 21:41:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 754E7610E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 93918833E6; Wed, 20 Oct 2021 23:41:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="liT2imiV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 49B418332B; Wed, 20 Oct 2021 23:00:54 +0200 (CEST) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 256B28332B for ; Wed, 20 Oct 2021 23:00:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=fntoth@gmail.com Received: by mail-ed1-x533.google.com with SMTP id t16so1173535eds.9 for ; Wed, 20 Oct 2021 14:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=g2u4RDFqAd/NjgcsSCxLLwI3izZVSrTqzAYszoI8cqA=; b=liT2imiVSXvRw+2Pqs9bdseooLBGtJ7I3u450QQ42UIVit7VstRx88GFFE5Qw8tgSO 1jMWDGfmQ/HnMc7HrVm9FvBPjTbPznvE6K4ceyZyH5uY29saZBr+KDTeztRCw9rzdvz4 j+AtirWJRX/IFvbQMEhuoMZji1Lnb87mgNvQ0iLvRuLHCvuizpWhWiQcHQyRGxKcUaFG df6N4nSiLMY7p4N4P8Gy3qFU5ihHbUaFY8Fsn+TWQns8DuayhHArCwHTlZ9rT2jO8zfn f9/TWKKWeKfTK52z2A49CuCi+clUNDtg65n07zZ/FjEsKg3ckUZeHFCUuSOljQ9QKVIK w3uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=g2u4RDFqAd/NjgcsSCxLLwI3izZVSrTqzAYszoI8cqA=; b=ykgGVLZDlaHmIDP9658GnHb89FIgImdooosuhURykIy4xorePTiR82ewf1q77yfE1d 4VBIGt2zETuaBrDSsTuwBEkeIojSgp5fStATV05MHGSg+Hn7/C0hlBiEQbjDB13lqj8o 6HYr6wnzUWFtff+mSjNvxAvmCW5D/L3l6EtKMPe1fsPIEDK6nCtKEf8AJFgbFDF9ARHB Q7t6/vX+t2zqzUz05KNsOTB4nCMRl/M8Pdub1V9iV3gSjhg6ucQFjEhCBUb5rnHq60Dg ijMACEl/zCVhcFK8ek7l+h0+WLtBpGDiq23OhI9IPJkkPz0YloXJzSGClpi+d8P2ZDIh 3Nyw== X-Gm-Message-State: AOAM533tL8iigBBCekTp1ftgU738LXs7n+3l2pkGB+TTwn7qRUiiw5wS svLYEbflh0q0bd0ZfUjT3f+cpgBJSR4= X-Google-Smtp-Source: ABdhPJzn4uQGyUY3dOWZf+DZtWff4nKdeDFw0Yb/70k9LpszKAY6+utid9CqOPo8mXjpDd5diuHhGg== X-Received: by 2002:a17:906:3947:: with SMTP id g7mr2061435eje.407.1634763649674; Wed, 20 Oct 2021 14:00:49 -0700 (PDT) Received: from ?IPv6:2001:981:6fec:1:3bbb:3574:7e12:f56f? ([2001:981:6fec:1:3bbb:3574:7e12:f56f]) by smtp.gmail.com with ESMTPSA id w6sm1694691edt.12.2021.10.20.14.00.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Oct 2021 14:00:49 -0700 (PDT) Subject: Re: [PATCH v1 2/2] x86: edison: Don't take SD card detect pin into consideration To: Andy Shevchenko , Bin Meng , Simon Glass , u-boot@lists.denx.de References: <20211015171147.51948-1-andriy.shevchenko@linux.intel.com> <20211015171147.51948-2-andriy.shevchenko@linux.intel.com> From: Ferry Toth Message-ID: <8e524b3f-44cd-9828-9611-172fa281feb4@gmail.com> Date: Wed, 20 Oct 2021 23:00:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211015171147.51948-2-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Wed, 20 Oct 2021 23:41:26 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi, Op 15-10-2021 om 19:11 schreef Andy Shevchenko: > There are two PCB designs in the wild which use the opposite > signaling for SD card detect. This makes U-Boot working in one case > and failing in the other. Quirk this out by disconnecting SD card > detect pin from the PCB by switching to mode 3. > Tested-by: Ferry Toth @ Intel Edison-Arduino board > BugLink: https://github.com/edison-fw/meta-intel-edison/issues/136 > Signed-off-by: Andy Shevchenko > --- > arch/x86/dts/edison.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/x86/dts/edison.dts b/arch/x86/dts/edison.dts > index 2c8cf6c07102..04e8a4e457c8 100644 > --- a/arch/x86/dts/edison.dts > +++ b/arch/x86/dts/edison.dts > @@ -94,6 +94,7 @@ > sdcard: mmc@ff3fa000 { > compatible = "intel,sdhci-tangier"; > reg = <0xff3fa000 0x1000>; > + cd-inverted; > }; > > pmu: power@ff00b000 { > @@ -131,6 +132,17 @@ > compatible = "intel,pinctrl-tangier"; > reg = <0xff0c0000 0x8000>; > > + /* > + * Disconnect SD card detect, so it won't affect the reality > + * on two different PCB designs where it's using the opposite > + * signaling: Edison/Arduino uses Active Low, while SparkFun > + * went with Active High. > + */ > + sd_cd@0 { > + pad-offset = <37>; > + mode-func = <3>; > + }; > + > /* > * Initial configuration came from the firmware. > * Which quite likely has been used in the phones, where I2C #8, >