From: Kever Yang <kever.yang@rock-chips.com>
To: FUKAUMI Naoki <naoki@radxa.com>, u-boot@lists.denx.de
Cc: banglang.huang@foxmail.com, jonas@kwiboo.se, sjg@chromium.org,
philipp.tomsich@vrull.eu, jagan@amarulasolutions.com,
gajjar04akash@gmail.com, chris.obbard@collabora.com,
dsimic@manjaro.org
Subject: Re: [PATCH v2 2/2] arm: dts: rockchip: turn LEDs on at boot for Radxa boards
Date: Mon, 21 Oct 2024 16:16:22 +0800 [thread overview]
Message-ID: <8e615323-e655-4c40-a9d9-a2ddf2c279a6@rock-chips.com> (raw)
In-Reply-To: <20240808222325.2082-2-naoki@radxa.com>
On 2024/8/9 06:23, FUKAUMI Naoki wrote:
> Basically, Radxa's boards are intended to turn LEDs on at U-Boot.
> add `default-state = "on"` to u-boot.dtsi.
>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> Changes in v2:
> - remove irrelevant contents from rk3399-rock-4c-plus-u-boot.dtsi
> - depend https://patchwork.ozlabs.org/project/uboot/patch/20240808221902.2006-1-naoki@radxa.com/
> ---
> .../arm/dts/rk3328-rock-pi-e-base-u-boot.dtsi | 6 +++++
> arch/arm/dts/rk3399-rock-4c-plus-u-boot.dtsi | 12 ++++++++++
> arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi | 8 +++++++
> arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi | 8 +++++++
> arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi | 23 +++++++++++++++++++
> arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 8 +++++++
> arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 8 +++++++
> arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi | 8 +++++++
> 8 files changed, 81 insertions(+)
>
> diff --git a/arch/arm/dts/rk3328-rock-pi-e-base-u-boot.dtsi b/arch/arm/dts/rk3328-rock-pi-e-base-u-boot.dtsi
> index 39bb66c4fcb..a30adb0be98 100644
> --- a/arch/arm/dts/rk3328-rock-pi-e-base-u-boot.dtsi
> +++ b/arch/arm/dts/rk3328-rock-pi-e-base-u-boot.dtsi
> @@ -6,6 +6,12 @@
> #include "rk3328-u-boot.dtsi"
>
> / {
> + leds {
> + led-0 {
> + default-state = "on";
> + };
> + };
> +
> smbios {
> compatible = "u-boot,sysinfo-smbios";
>
> diff --git a/arch/arm/dts/rk3399-rock-4c-plus-u-boot.dtsi b/arch/arm/dts/rk3399-rock-4c-plus-u-boot.dtsi
> index 50dae5cb5ef..7a6af430a6f 100644
> --- a/arch/arm/dts/rk3399-rock-4c-plus-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-rock-4c-plus-u-boot.dtsi
> @@ -6,6 +6,18 @@
> #include "rk3399-u-boot.dtsi"
> #include "rk3399-sdram-lpddr4-100.dtsi"
>
> +/ {
> + leds {
> + led-0 {
> + default-state = "on";
> + };
> +
> + led-1 {
> + default-state = "on";
> + };
> + };
> +};
> +
> &pcfg_pull_none_18ma {
> bootph-pre-ram;
> bootph-some-ram;
> diff --git a/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi b/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi
> index b3bfc77f756..4861574636e 100644
> --- a/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi
> @@ -6,6 +6,14 @@
> #include "rk3399-u-boot.dtsi"
> #include "rk3399-sdram-lpddr4-100.dtsi"
>
> +/ {
> + leds {
> + led-0 {
> + default-state = "on";
> + };
> + };
> +};
> +
> &sdhci {
> cap-mmc-highspeed;
> mmc-ddr-1_8v;
> diff --git a/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi b/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
> index e0e501deccf..412f9e06aff 100644
> --- a/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
> +++ b/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
> @@ -5,6 +5,14 @@
>
> #include "rk356x-u-boot.dtsi"
>
> +/ {
> + leds {
> + led-1 {
> + default-state = "on";
> + };
> + };
> +};
> +
> &sdhci {
> cap-mmc-highspeed;
> };
> diff --git a/arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi b/arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi
> index 74755a44eae..efeab626d8a 100644
> --- a/arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi
> +++ b/arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi
> @@ -2,6 +2,29 @@
>
> #include "rk356x-u-boot.dtsi"
>
> +/ {
> + gpio-leds {
> + led-0 {
> + default-state = "on";
> + };
> +
> + led-red {
> + default-state = "on";
> + gpios = <&gpio0 RK_PC0 GPIO_ACTIVE_HIGH>;
> + };
> +
> + led-green {
> + default-state = "on";
> + gpios = <&gpio0 RK_PC1 GPIO_ACTIVE_HIGH>;
> + };
> +
> + led-blue {
> + default-state = "on";
> + gpios = <&gpio4 RK_PC5 GPIO_ACTIVE_HIGH>;
> + };
> + };
> +};
> +
> &pcie3x1 {
> pinctrl-0 = <&pcie30x1_reset_h>;
> };
> diff --git a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
> index 9d18f5d0b36..c493352abc1 100644
> --- a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
> +++ b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
> @@ -6,6 +6,14 @@
>
> #include "rk356x-u-boot.dtsi"
>
> +/ {
> + leds {
> + led-0 {
> + default-state = "on";
> + };
> + };
> +};
> +
> &pcie3x2 {
> pinctrl-0 = <&pcie3x2_reset_h>;
> };
> diff --git a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi
> index 8e318e624a8..8ebba36f90a 100644
> --- a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi
> +++ b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi
> @@ -5,6 +5,14 @@
>
> #include "rk3588-u-boot.dtsi"
>
> +/ {
> + leds {
> + led_rgb_b {
> + default-state = "on";
> + };
> + };
> +};
> +
> &fspim2_pins {
> bootph-pre-ram;
> bootph-some-ram;
> diff --git a/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi b/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi
> index efba0c359ba..a75ae296386 100644
> --- a/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi
> +++ b/arch/arm/dts/rk3588s-rock-5a-u-boot.dtsi
> @@ -5,6 +5,14 @@
>
> #include "rk3588s-u-boot.dtsi"
>
> +/ {
> + leds {
> + io-led {
> + default-state = "on";
> + };
> + };
> +};
> +
> &sdhci {
> cap-mmc-highspeed;
> mmc-hs200-1_8v;
next prev parent reply other threads:[~2024-10-21 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 22:23 [PATCH v2 1/2] configs: rockchip: enable gpio-leds driver for Radxa boards FUKAUMI Naoki
2024-08-08 22:23 ` [PATCH v2 2/2] arm: dts: rockchip: turn LEDs on at boot " FUKAUMI Naoki
2024-10-21 8:16 ` Kever Yang [this message]
2024-10-21 8:16 ` [PATCH v2 1/2] configs: rockchip: enable gpio-leds driver " Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e615323-e655-4c40-a9d9-a2ddf2c279a6@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=banglang.huang@foxmail.com \
--cc=chris.obbard@collabora.com \
--cc=dsimic@manjaro.org \
--cc=gajjar04akash@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=jonas@kwiboo.se \
--cc=naoki@radxa.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox