From: Johann Neuhauser <jneuhauser@dh-electronics.com>
To: Marek Vasut <marex@denx.de>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>,
u-boot <u-boot@dh-electronics.com>,
"uboot-stm32@st-md-mailman.stormreply.com"
<uboot-stm32@st-md-mailman.stormreply.com>,
Tom Rini <trini@konsulko.com>,
Patrice Chotard <patrice.chotard@foss.st.com>
Subject: RE: [PATCH] arm: dts: stm32mp1: Drop fastboot and stm32prog trigger gpios on DHCOM
Date: Fri, 1 Jul 2022 07:36:11 +0000 [thread overview]
Message-ID: <8ebbf6d336cd410aac13d92a0ff44e08@dh-electronics.com> (raw)
In-Reply-To: <a4962258-852b-fc7c-0c19-166fa1cdde00@denx.de>
> -----Original Message-----
> From: Marek Vasut [mailto:marex@denx.de]
> Sent: Thursday, June 30, 2022 5:20 PM
>
> On 6/30/22 16:19, Johann Neuhauser wrote:
> > PA13 and PA14 are used for USB power control and can't be used
> > to enforce fastboot or stm32prog mode by pressing a button.
> >
> > Defining CONFIG_FASTBOOT/CONFIG_CMD_STM32PROG without this patch applied
> > results in fastboot/stm32prog always starting, because PA13/PA14 are always
> > low during boot. So drop the wrong trigger gpios definitions.
> >
> > Signed-off-by: Johann Neuhauser <jneuhauser@dh-electronics.com>
>
> Those GPIOs also likely make no sense on DHCOM , right ?
They would only make sense on the DHCOM PDK2, since this is the only
mainline baseboard with user buttons available in U-Boot.
>
> Reviewed-by: Marek Vasut <marex@denx.de>
next prev parent reply other threads:[~2022-07-01 7:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 14:19 [PATCH] arm: dts: stm32mp1: Drop fastboot and stm32prog trigger gpios on DHCOM Johann Neuhauser
2022-06-30 15:19 ` Marek Vasut
2022-07-01 7:36 ` Johann Neuhauser [this message]
2022-07-06 16:44 ` Patrick DELAUNAY
2022-07-13 11:12 ` Patrick Delaunay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ebbf6d336cd410aac13d92a0ff44e08@dh-electronics.com \
--to=jneuhauser@dh-electronics.com \
--cc=marex@denx.de \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=trini@konsulko.com \
--cc=u-boot@dh-electronics.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox