From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: Andrew Davis <afd@ti.com>, Simon Glass <sjg@chromium.org>,
Tom Rini <trini@konsulko.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH v3 2/2] doc: board: j721e_evm: Fix code-block type and indents
Date: Fri, 2 Dec 2022 17:46:38 +0100 [thread overview]
Message-ID: <8f29ccba-91ed-70e5-7f03-e3a39605ecc7@gmx.de> (raw)
In-Reply-To: <20221109173001.15818-2-afd@ti.com>
On 11/9/22 18:30, Andrew Davis wrote:
> * BASH code should be labeled as such.
> * Code blocks should be indented by 4 spaces.
>
> Fix these here.
>
> Suggested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Signed-off-by: Andrew Davis <afd@ti.com>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>
> Changes from v2:
> - None
>
> Changes from v1:
> - New patch with fixes suggested by Heinrich
>
> doc/board/ti/j721e_evm.rst | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/doc/board/ti/j721e_evm.rst b/doc/board/ti/j721e_evm.rst
> index 8608373365..ad70f15b7a 100644
> --- a/doc/board/ti/j721e_evm.rst
> +++ b/doc/board/ti/j721e_evm.rst
> @@ -154,37 +154,37 @@ Build procedure:
> ----------------
> 1. SYSFW:
>
> -.. code-block:: text
> +.. code-block:: bash
>
> - $ make CROSS_COMPILE=arm-linux-gnueabihf- SOC=j721e
> + make CROSS_COMPILE=arm-linux-gnueabihf- SOC=j721e
>
> 2. ATF:
>
> -.. code-block:: text
> +.. code-block:: bash
>
> - $ make CROSS_COMPILE=aarch64-linux-gnu- ARCH=aarch64 PLAT=k3 TARGET_BOARD=generic SPD=opteed
> + make CROSS_COMPILE=aarch64-linux-gnu- ARCH=aarch64 PLAT=k3 TARGET_BOARD=generic SPD=opteed
>
> 3. OPTEE:
>
> -.. code-block:: text
> +.. code-block:: bash
>
> - $ make PLATFORM=k3-j721e CFG_ARM64_core=y
> + make PLATFORM=k3-j721e CFG_ARM64_core=y
>
> 4. U-Boot:
>
> * 4.1 R5:
>
> -.. code-block:: text
> +.. code-block:: bash
>
> - $ make CROSS_COMPILE=arm-linux-gnueabihf- j721e_evm_r5_defconfig O=build/r5
> - $ make CROSS_COMPILE=arm-linux-gnueabihf- O=build/r5
> + make CROSS_COMPILE=arm-linux-gnueabihf- j721e_evm_r5_defconfig O=build/r5
> + make CROSS_COMPILE=arm-linux-gnueabihf- O=build/r5
>
> * 4.2 A72:
>
> -.. code-block:: text
> +.. code-block:: bash
>
> - $ make CROSS_COMPILE=aarch64-linux-gnu- j721e_evm_a72_defconfig O=build/a72
> - $ make CROSS_COMPILE=aarch64-linux-gnu- ATF=<ATF dir>/build/k3/generic/release/bl31.bin TEE=<OPTEE OS dir>/out/arm-plat-k3/core/tee-pager_v2.bin DM=<DM firmware>/ti-dm/j721e/ipc_echo_testb_mcu1_0_release_strip.xer5f O=build/a72
> + make CROSS_COMPILE=aarch64-linux-gnu- j721e_evm_a72_defconfig O=build/a72
> + make CROSS_COMPILE=aarch64-linux-gnu- ATF=<ATF dir>/build/k3/generic/release/bl31.bin TEE=<OPTEE OS dir>/out/arm-plat-k3/core/tee-pager_v2.bin DM=<DM firmware>/ti-dm/j721e/ipc_echo_testb_mcu1_0_release_strip.xer5f O=build/a72
>
> Target Images
> --------------
prev parent reply other threads:[~2022-12-02 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 17:30 [PATCH v3 1/2] doc: board: j721e_evm: Add DM firmware steps Andrew Davis
2022-11-09 17:30 ` [PATCH v3 2/2] doc: board: j721e_evm: Fix code-block type and indents Andrew Davis
2022-12-02 16:46 ` Heinrich Schuchardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f29ccba-91ed-70e5-7f03-e3a39605ecc7@gmx.de \
--to=xypron.glpk@gmx.de \
--cc=afd@ti.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox