public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@kernel.org>
To: Nishanth Menon <nm@ti.com>
Cc: robertcnelson@gmail.com, trini@konsulko.com, marex@denx.de,
	n-francis@ti.com, praneeth@ti.com, s-vadapalli@ti.com,
	r-gunasekaran@ti.com, srk@ti.com, vigneshr@ti.com,
	u-boot@lists.denx.de
Subject: Re: [PATCH 4/5] arm: dts: k3-j721e-beagleboneai64: Fix USB operation
Date: Fri, 12 Jan 2024 15:06:26 +0200	[thread overview]
Message-ID: <8f5d151c-aebb-41d9-b638-83c60e740d15@kernel.org> (raw)
In-Reply-To: <20240112130233.bflterluncjoyrhy@treadmill>



On 12/01/2024 15:02, Nishanth Menon wrote:
> On 14:49-20240112, Roger Quadros wrote:
>> Without correct SERDES MUX and Lane control settings
>> USB0 will be broken. Set the MUX and Lane control devices
>> to be auto probed so they are configured correctly.
>>
>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>> ---
>>  arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi b/arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi
>> index f83caf7998..017a5a722e 100644
>> --- a/arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi
>> +++ b/arch/arm/dts/k3-j721e-beagleboneai64-u-boot.dtsi
>> @@ -165,6 +165,7 @@
>>  
>>  &serdes_ln_ctrl {
>>  	bootph-all;
>> +	u-boot,mux-autoprobe;
>>  };
>>  
>>  &serdes2_usb_link {
>> @@ -173,6 +174,7 @@
>>  
>>  &usb_serdes_mux {
>>  	bootph-all;
>> +	u-boot,mux-autoprobe;
>>  };
>>  
>>  &serdes_wiz2 {
>> -- 
>> 2.34.1
>>
> 
> Is this a u-boot thing? or a driver limitation?
> 

u-boot specific. We just want the mux driver to probe
and apply the settings.

from drivers/mux/mux-uclass.c

int dm_mux_init(void)
{
        struct uclass *uc;
        struct udevice *dev;
        int ret;

        ret = uclass_get(UCLASS_MUX, &uc);
        if (ret < 0) {
                log_debug("unable to get MUX uclass\n");
                return ret;
        }
        uclass_foreach_dev(dev, uc) {
                if (dev_read_bool(dev, "u-boot,mux-autoprobe")) {
                        ret = device_probe(dev);
                        if (ret)
                                log_debug("unable to probe device %s\n",
                                          dev->name);
                }
        }

        return 0;
}


-- 
cheers,
-roger

  reply	other threads:[~2024-01-12 13:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12 12:49 [PATCH 0/5] k3-j721e: beagleboneai: Fix USB Roger Quadros
2024-01-12 12:49 ` [PATCH 1/5] board: ti: j721e: Drop SERDES PHY init from board file Roger Quadros
2024-01-12 12:49 ` [PATCH 2/5] usb: cdns3: avoid error messages if phys don't exist Roger Quadros
2024-01-12 12:49 ` [PATCH 3/5] arm: dts: k3-j721e: Fix USB0 operation Roger Quadros
2024-01-12 12:49 ` [PATCH 4/5] arm: dts: k3-j721e-beagleboneai64: Fix USB operation Roger Quadros
2024-01-12 13:02   ` Nishanth Menon
2024-01-12 13:06     ` Roger Quadros [this message]
2024-01-12 13:14       ` Nishanth Menon
2024-01-12 13:21         ` Tom Rini
2024-01-15 11:40           ` Roger Quadros
2024-01-20 16:50             ` Tom Rini
2024-01-22 11:39               ` Roger Quadros
2024-01-22 16:00                 ` Tom Rini
2024-01-12 12:49 ` [PATCH 5/5] configs/j721e_beagleboneai64_a72_defconfig: Enable Sierra PHY Roger Quadros
2024-01-20 21:04 ` [PATCH 0/5] k3-j721e: beagleboneai: Fix USB Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f5d151c-aebb-41d9-b638-83c60e740d15@kernel.org \
    --to=rogerq@kernel.org \
    --cc=marex@denx.de \
    --cc=n-francis@ti.com \
    --cc=nm@ti.com \
    --cc=praneeth@ti.com \
    --cc=r-gunasekaran@ti.com \
    --cc=robertcnelson@gmail.com \
    --cc=s-vadapalli@ti.com \
    --cc=srk@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox