* [PATCH v6 0/3] Timer support for ARM Tegra
@ 2023-01-24 6:57 Svyatoslav Ryhel
2023-01-24 6:57 ` [PATCH v6 1/3] ARM: tegra: remap clock_osc_freq for all Tegra family Svyatoslav Ryhel
` (3 more replies)
0 siblings, 4 replies; 18+ messages in thread
From: Svyatoslav Ryhel @ 2023-01-24 6:57 UTC (permalink / raw)
To: Rayagonda Kokatanur, Tom Warren, Thierry Reding, Marek Vasut,
Svyatoslav Ryhel, Maxim Schwalm, Dmitry Osipenko,
Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev,
Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen,
Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung
Cc: u-boot
- ARM: tegra: remap clock_osc_freq for all Tegra family
Enum clock_osc_freq was designed to use only with T20.
This patch remaps it to use additional frequencies, added in
T30+ SoC while maintaining backwards compatibility with T20.
- drivers: timer: add timer driver for ARMv7 based Tegra devices
Add timer support for T20/T30/T114 and T124 based devices.
Driver is based on DM, has device tree support and can be
used on SPL and early boot stage.
- ARM: tegra: include timer as default option
Enable TIMER as default option for all Tegra devices and
enable TEGRA_TIMER for TEGRA_ARMV7_COMMON. Additionally
enable SPL_TIMER if build as SPL part and drop deprecated
configs from common header.
P. S. I have no arm64 Tegra and according to comment in
tegra-common.h
Use the Tegra US timer on ARMv7, but the architected timer on ARMv8.
Svyatoslav Ryhel (3):
ARM: tegra: remap clock_osc_freq for all Tegra family
drivers: timer: add timer driver for ARMv7 based Tegra devices
ARM: tegra: include timer as default option
arch/arm/Kconfig | 1 +
arch/arm/include/asm/arch-tegra/clock.h | 9 +-
arch/arm/mach-tegra/Kconfig | 2 +
arch/arm/mach-tegra/clock.c | 17 +++-
arch/arm/mach-tegra/cpu.c | 70 ++++++++++---
arch/arm/mach-tegra/tegra114/clock.c | 13 +--
arch/arm/mach-tegra/tegra124/clock.c | 13 +--
arch/arm/mach-tegra/tegra20/clock.c | 4 +-
arch/arm/mach-tegra/tegra210/clock.c | 22 +----
arch/arm/mach-tegra/tegra30/clock.c | 10 +-
drivers/timer/Kconfig | 8 ++
drivers/timer/Makefile | 1 +
drivers/timer/tegra-timer.c | 126 ++++++++++++++++++++++++
drivers/usb/host/ehci-tegra.c | 46 +++++++--
include/configs/tegra-common.h | 6 --
15 files changed, 269 insertions(+), 79 deletions(-)
create mode 100644 drivers/timer/tegra-timer.c
--
2.37.2
^ permalink raw reply [flat|nested] 18+ messages in thread* [PATCH v6 1/3] ARM: tegra: remap clock_osc_freq for all Tegra family 2023-01-24 6:57 [PATCH v6 0/3] Timer support for ARM Tegra Svyatoslav Ryhel @ 2023-01-24 6:57 ` Svyatoslav Ryhel 2023-01-24 6:57 ` [PATCH v6 2/3] drivers: timer: add timer driver for ARMv7 based Tegra devices Svyatoslav Ryhel ` (2 subsequent siblings) 3 siblings, 0 replies; 18+ messages in thread From: Svyatoslav Ryhel @ 2023-01-24 6:57 UTC (permalink / raw) To: Rayagonda Kokatanur, Tom Warren, Thierry Reding, Marek Vasut, Svyatoslav Ryhel, Maxim Schwalm, Dmitry Osipenko, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung Cc: u-boot Enum clock_osc_freq was designed to use only with T20. This patch remaps it to use additional frequencies, added in T30+ SoC while maintaining backwards compatibility with T20. Tested-by: Andreas Westman Dorcsak <hedmoo@yahoo.com> # ASUS TF600T T30 Tested-by: Jonas Schwöbel <jonasschwoebel@yahoo.de> # Surface RT T30 Tested-by: Robert Eckelmann <longnoserob@gmail.com> # ASUS TF101 T20 Tested-by: Agneli <poczt@protomail.ch> # Toshiba AC100 T20 Tested-by: Svyatoslav Ryhel <clamor95@gmail.com> # LG P895 T30 Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> Reviewed-by: Simon Glass <sjg@chromium.org> --- arch/arm/include/asm/arch-tegra/clock.h | 9 ++-- arch/arm/mach-tegra/clock.c | 17 ++++-- arch/arm/mach-tegra/cpu.c | 70 ++++++++++++++++++++----- arch/arm/mach-tegra/tegra114/clock.c | 13 ++--- arch/arm/mach-tegra/tegra124/clock.c | 13 ++--- arch/arm/mach-tegra/tegra20/clock.c | 4 +- arch/arm/mach-tegra/tegra210/clock.c | 22 ++------ arch/arm/mach-tegra/tegra30/clock.c | 10 +--- drivers/usb/host/ehci-tegra.c | 46 ++++++++++++---- 9 files changed, 131 insertions(+), 73 deletions(-) diff --git a/arch/arm/include/asm/arch-tegra/clock.h b/arch/arm/include/asm/arch-tegra/clock.h index 6586015fd2..1dd5d0742c 100644 --- a/arch/arm/include/asm/arch-tegra/clock.h +++ b/arch/arm/include/asm/arch-tegra/clock.h @@ -13,12 +13,13 @@ struct udevice; /* Set of oscillator frequencies supported in the internal API. */ enum clock_osc_freq { /* All in MHz, so 13_0 is 13.0MHz */ - CLOCK_OSC_FREQ_13_0, - CLOCK_OSC_FREQ_19_2, - CLOCK_OSC_FREQ_12_0, - CLOCK_OSC_FREQ_26_0, + CLOCK_OSC_FREQ_13_0 = 0, + CLOCK_OSC_FREQ_16_8, + CLOCK_OSC_FREQ_19_2 = 4, CLOCK_OSC_FREQ_38_4, + CLOCK_OSC_FREQ_12_0 = 8, CLOCK_OSC_FREQ_48_0, + CLOCK_OSC_FREQ_26_0 = 12, CLOCK_OSC_FREQ_COUNT, }; diff --git a/arch/arm/mach-tegra/clock.c b/arch/arm/mach-tegra/clock.c index 77c8ad978e..11bffc1701 100644 --- a/arch/arm/mach-tegra/clock.c +++ b/arch/arm/mach-tegra/clock.c @@ -28,16 +28,23 @@ static unsigned pll_rate[CLOCK_ID_COUNT]; /* - * The oscillator frequency is fixed to one of four set values. Based on this + * The oscillator frequency is fixed to one of seven set values. Based on this * the other clocks are set up appropriately. */ static unsigned osc_freq[CLOCK_OSC_FREQ_COUNT] = { 13000000, + 16800000, + 0, + 0, 19200000, - 12000000, - 26000000, 38400000, + 0, + 0, + 12000000, 48000000, + 0, + 0, + 26000000, }; /* return 1 if a peripheral ID is in range */ @@ -766,6 +773,7 @@ void tegra30_set_up_pllp(void) */ switch (clock_get_osc_freq()) { case CLOCK_OSC_FREQ_12_0: /* OSC is 12Mhz */ + case CLOCK_OSC_FREQ_48_0: /* OSC is 48Mhz */ clock_set_rate(CLOCK_ID_PERIPH, 408, 12, 0, 8); clock_set_rate(CLOCK_ID_CGENERAL, 456, 12, 1, 8); break; @@ -776,10 +784,13 @@ void tegra30_set_up_pllp(void) break; case CLOCK_OSC_FREQ_13_0: /* OSC is 13Mhz */ + case CLOCK_OSC_FREQ_16_8: /* OSC is 16.8Mhz */ clock_set_rate(CLOCK_ID_PERIPH, 408, 13, 0, 8); clock_set_rate(CLOCK_ID_CGENERAL, 600, 13, 0, 8); break; + case CLOCK_OSC_FREQ_19_2: + case CLOCK_OSC_FREQ_38_4: default: /* * These are not supported. It is too early to print a diff --git a/arch/arm/mach-tegra/cpu.c b/arch/arm/mach-tegra/cpu.c index 65b15b79fe..59ca8aeaba 100644 --- a/arch/arm/mach-tegra/cpu.c +++ b/arch/arm/mach-tegra/cpu.c @@ -55,11 +55,18 @@ struct clk_pll_table tegra_pll_x_table[TEGRA_SOC_CNT][CLOCK_OSC_FREQ_COUNT] = { */ { { .n = 1000, .m = 13, .p = 0, .cpcon = 12 }, /* OSC: 13.0 MHz */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ { .n = 625, .m = 12, .p = 0, .cpcon = 8 }, /* OSC: 19.2 MHz */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ { .n = 1000, .m = 12, .p = 0, .cpcon = 12 }, /* OSC: 12.0 MHz */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ { .n = 1000, .m = 26, .p = 0, .cpcon = 12 }, /* OSC: 26.0 MHz */ - { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* OSC: 38.4 MHz (N/A) */ - { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* OSC: 48.0 MHz (N/A) */ }, /* * T25: 1.2 GHz @@ -73,11 +80,18 @@ struct clk_pll_table tegra_pll_x_table[TEGRA_SOC_CNT][CLOCK_OSC_FREQ_COUNT] = { */ { { .n = 923, .m = 10, .p = 0, .cpcon = 12 }, /* OSC: 13.0 MHz */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ { .n = 750, .m = 12, .p = 0, .cpcon = 8 }, /* OSC: 19.2 MHz */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ { .n = 600, .m = 6, .p = 0, .cpcon = 12 }, /* OSC: 12.0 MHz */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ { .n = 600, .m = 13, .p = 0, .cpcon = 12 }, /* OSC: 26.0 MHz */ - { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* OSC: 38.4 MHz (N/A) */ - { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* OSC: 48.0 MHz (N/A) */ }, /* * T30: 600 MHz @@ -91,11 +105,18 @@ struct clk_pll_table tegra_pll_x_table[TEGRA_SOC_CNT][CLOCK_OSC_FREQ_COUNT] = { */ { { .n = 600, .m = 13, .p = 0, .cpcon = 8 }, /* OSC: 13.0 MHz */ + { .n = 600, .m = 13, .p = 0, .cpcon = 8 }, /* OSC: 16.8 MHz */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ { .n = 500, .m = 16, .p = 0, .cpcon = 8 }, /* OSC: 19.2 MHz */ + { .n = 500, .m = 16, .p = 0, .cpcon = 8 }, /* OSC: 38.4 MHz */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ { .n = 600, .m = 12, .p = 0, .cpcon = 8 }, /* OSC: 12.0 MHz */ + { .n = 600, .m = 12, .p = 0, .cpcon = 8 }, /* OSC: 48.0 MHz */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ + { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* N/A */ { .n = 600, .m = 26, .p = 0, .cpcon = 8 }, /* OSC: 26.0 MHz */ - { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* OSC: 38.4 MHz (N/A) */ - { .n = 0, .m = 0, .p = 0, .cpcon = 0 }, /* OSC: 48.0 MHz (N/A) */ }, /* * T114: 700 MHz @@ -108,11 +129,18 @@ struct clk_pll_table tegra_pll_x_table[TEGRA_SOC_CNT][CLOCK_OSC_FREQ_COUNT] = { */ { { .n = 108, .m = 1, .p = 1 }, /* OSC: 13.0 MHz */ + { .n = 108, .m = 1, .p = 1 }, /* OSC: 16.8 MHz */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ { .n = 73, .m = 1, .p = 1 }, /* OSC: 19.2 MHz */ + { .n = 73, .m = 1, .p = 1 }, /* OSC: 38.4 MHz */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ { .n = 116, .m = 1, .p = 1 }, /* OSC: 12.0 MHz */ + { .n = 116, .m = 1, .p = 1 }, /* OSC: 48.0 MHz */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ { .n = 108, .m = 2, .p = 1 }, /* OSC: 26.0 MHz */ - { .n = 0, .m = 0, .p = 0 }, /* OSC: 38.4 MHz (N/A) */ - { .n = 0, .m = 0, .p = 0 }, /* OSC: 48.0 MHz (N/A) */ }, /* @@ -126,11 +154,18 @@ struct clk_pll_table tegra_pll_x_table[TEGRA_SOC_CNT][CLOCK_OSC_FREQ_COUNT] = { */ { { .n = 108, .m = 1, .p = 1 }, /* OSC: 13.0 MHz */ + { .n = 108, .m = 1, .p = 1 }, /* OSC: 16.8 MHz */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ { .n = 73, .m = 1, .p = 1 }, /* OSC: 19.2 MHz */ + { .n = 73, .m = 1, .p = 1 }, /* OSC: 38.4 MHz */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ { .n = 116, .m = 1, .p = 1 }, /* OSC: 12.0 MHz */ + { .n = 116, .m = 1, .p = 1 }, /* OSC: 48.0 MHz */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ { .n = 108, .m = 2, .p = 1 }, /* OSC: 26.0 MHz */ - { .n = 0, .m = 0, .p = 0 }, /* OSC: 38.4 MHz (N/A) */ - { .n = 0, .m = 0, .p = 0 }, /* OSC: 48.0 MHz (N/A) */ }, /* @@ -143,12 +178,19 @@ struct clk_pll_table tegra_pll_x_table[TEGRA_SOC_CNT][CLOCK_OSC_FREQ_COUNT] = { * PLLX_BASE m 7: 0 8 */ { - { .n = 108, .m = 1, .p = 1 }, /* OSC: 13.0 MHz = 702 MHz*/ - { .n = 73, .m = 1, .p = 1 }, /* OSC: 19.2 MHz = 700.8 MHz*/ - { .n = 116, .m = 1, .p = 1 }, /* OSC: 12.0 MHz = 696 MHz*/ - { .n = 108, .m = 2, .p = 1 }, /* OSC: 26.0 MHz = 702 MHz*/ + { .n = 108, .m = 1, .p = 1 }, /* OSC: 13.0 MHz = 702 MHz */ + { .n = 108, .m = 1, .p = 1 }, /* OSC: 16.0 MHz = 702 MHz */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ + { .n = 73, .m = 1, .p = 1 }, /* OSC: 19.2 MHz = 700.8 MHz */ { .n = 36, .m = 1, .p = 1 }, /* OSC: 38.4 MHz = 691.2 MHz */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ + { .n = 116, .m = 1, .p = 1 }, /* OSC: 12.0 MHz = 696 MHz */ { .n = 58, .m = 2, .p = 1 }, /* OSC: 48.0 MHz = 696 MHz */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ + { .n = 0, .m = 0, .p = 0 }, /* (N/A) */ + { .n = 108, .m = 2, .p = 1 }, /* OSC: 26.0 MHz = 702 MHz */ }, }; diff --git a/arch/arm/mach-tegra/tegra114/clock.c b/arch/arm/mach-tegra/tegra114/clock.c index 703a2314e7..143f86863f 100644 --- a/arch/arm/mach-tegra/tegra114/clock.c +++ b/arch/arm/mach-tegra/tegra114/clock.c @@ -459,8 +459,7 @@ struct clk_pll_info tegra_pll_info_table[CLOCK_ID_PLL_COUNT] = { /* * Get the oscillator frequency, from the corresponding hardware configuration - * field. Note that T30/T114 support 3 new higher freqs, but we map back - * to the old T20 freqs. Support for the higher oscillators is TBD. + * field. Note that T30+ supports 3 new higher freqs. */ enum clock_osc_freq clock_get_osc_freq(void) { @@ -469,12 +468,7 @@ enum clock_osc_freq clock_get_osc_freq(void) u32 reg; reg = readl(&clkrst->crc_osc_ctrl); - reg = (reg & OSC_FREQ_MASK) >> OSC_FREQ_SHIFT; - - if (reg & 1) /* one of the newer freqs */ - printf("Warning: OSC_FREQ is unsupported! (%d)\n", reg); - - return reg >> 2; /* Map to most common (T20) freqs */ + return (reg & OSC_FREQ_MASK) >> OSC_FREQ_SHIFT; } /* Returns a pointer to the clock source register for a peripheral */ @@ -674,6 +668,7 @@ void clock_early_init(void) */ switch (clock_get_osc_freq()) { case CLOCK_OSC_FREQ_12_0: /* OSC is 12Mhz */ + case CLOCK_OSC_FREQ_48_0: /* OSC is 48Mhz */ clock_set_rate(CLOCK_ID_CGENERAL, 600, 12, 0, 8); clock_set_rate(CLOCK_ID_DISPLAY, 925, 12, 0, 12); break; @@ -684,10 +679,12 @@ void clock_early_init(void) break; case CLOCK_OSC_FREQ_13_0: /* OSC is 13Mhz */ + case CLOCK_OSC_FREQ_16_8: /* OSC is 16.8Mhz */ clock_set_rate(CLOCK_ID_CGENERAL, 600, 13, 0, 8); clock_set_rate(CLOCK_ID_DISPLAY, 925, 13, 0, 12); break; case CLOCK_OSC_FREQ_19_2: + case CLOCK_OSC_FREQ_38_4: default: /* * These are not supported. It is too early to print a diff --git a/arch/arm/mach-tegra/tegra124/clock.c b/arch/arm/mach-tegra/tegra124/clock.c index bbfe184652..da38b26c27 100644 --- a/arch/arm/mach-tegra/tegra124/clock.c +++ b/arch/arm/mach-tegra/tegra124/clock.c @@ -601,8 +601,7 @@ struct clk_pll_info tegra_pll_info_table[CLOCK_ID_PLL_COUNT] = { /* * Get the oscillator frequency, from the corresponding hardware configuration - * field. Note that Tegra30+ support 3 new higher freqs, but we map back - * to the old T20 freqs. Support for the higher oscillators is TBD. + * field. Note that T30+ supports 3 new higher freqs. */ enum clock_osc_freq clock_get_osc_freq(void) { @@ -611,12 +610,7 @@ enum clock_osc_freq clock_get_osc_freq(void) u32 reg; reg = readl(&clkrst->crc_osc_ctrl); - reg = (reg & OSC_FREQ_MASK) >> OSC_FREQ_SHIFT; - - if (reg & 1) /* one of the newer freqs */ - printf("Warning: OSC_FREQ is unsupported! (%d)\n", reg); - - return reg >> 2; /* Map to most common (T20) freqs */ + return (reg & OSC_FREQ_MASK) >> OSC_FREQ_SHIFT; } /* Returns a pointer to the clock source register for a peripheral */ @@ -854,6 +848,7 @@ void clock_early_init(void) */ switch (clock_get_osc_freq()) { case CLOCK_OSC_FREQ_12_0: /* OSC is 12Mhz */ + case CLOCK_OSC_FREQ_48_0: /* OSC is 48Mhz */ clock_set_rate(CLOCK_ID_CGENERAL, 600, 12, 0, 8); clock_set_rate(CLOCK_ID_DISPLAY, 925, 12, 0, 12); break; @@ -864,10 +859,12 @@ void clock_early_init(void) break; case CLOCK_OSC_FREQ_13_0: /* OSC is 13Mhz */ + case CLOCK_OSC_FREQ_16_8: /* OSC is 16.8Mhz */ clock_set_rate(CLOCK_ID_CGENERAL, 600, 13, 0, 8); clock_set_rate(CLOCK_ID_DISPLAY, 925, 13, 0, 12); break; case CLOCK_OSC_FREQ_19_2: + case CLOCK_OSC_FREQ_38_4: default: /* * These are not supported. It is too early to print a diff --git a/arch/arm/mach-tegra/tegra20/clock.c b/arch/arm/mach-tegra/tegra20/clock.c index 3b50a81194..8c127430aa 100644 --- a/arch/arm/mach-tegra/tegra20/clock.c +++ b/arch/arm/mach-tegra/tegra20/clock.c @@ -399,7 +399,9 @@ enum clock_osc_freq clock_get_osc_freq(void) u32 reg; reg = readl(&clkrst->crc_osc_ctrl); - return (reg & OSC_FREQ_MASK) >> OSC_FREQ_SHIFT; + reg = (reg & OSC_FREQ_MASK) >> OSC_FREQ_SHIFT; + + return reg << 2; } /* Returns a pointer to the clock source register for a peripheral */ diff --git a/arch/arm/mach-tegra/tegra210/clock.c b/arch/arm/mach-tegra/tegra210/clock.c index 10c2478df7..330753f2ad 100644 --- a/arch/arm/mach-tegra/tegra210/clock.c +++ b/arch/arm/mach-tegra/tegra210/clock.c @@ -672,8 +672,7 @@ struct clk_pll_info tegra_pll_info_table[CLOCK_ID_PLL_COUNT] = { /* * Get the oscillator frequency, from the corresponding hardware configuration - * field. Note that Tegra30+ support 3 new higher freqs, but we map back - * to the old T20 freqs. Support for the higher oscillators is TBD. + * field. Note that T30+ supports 3 new higher freqs. */ enum clock_osc_freq clock_get_osc_freq(void) { @@ -682,22 +681,7 @@ enum clock_osc_freq clock_get_osc_freq(void) u32 reg; reg = readl(&clkrst->crc_osc_ctrl); - reg = (reg & OSC_FREQ_MASK) >> OSC_FREQ_SHIFT; - /* - * 0 = 13MHz, 1 = 16.8MHz, 4 = 19.2MHz, 5 = 38.4MHz, - * 8 = 12MHz, 9 = 48MHz, 12 = 26MHz - */ - if (reg == 5) { - debug("OSC_FREQ is 38.4MHz (%d) ...\n", reg); - /* Map it to the 5th CLOCK_OSC_ enum, i.e. 4 */ - return 4; - } - - /* - * Map to most common (T20) freqs (except 38.4, handled above): - * 13/16.8 = 0, 19.2 = 1, 12/48 = 2, 26 = 3 - */ - return reg >> 2; + return (reg & OSC_FREQ_MASK) >> OSC_FREQ_SHIFT; } /* Returns a pointer to the clock source register for a peripheral */ @@ -986,6 +970,7 @@ void clock_early_init(void) */ switch (clock_get_osc_freq()) { case CLOCK_OSC_FREQ_12_0: /* OSC is 12Mhz */ + case CLOCK_OSC_FREQ_48_0: /* OSC is 48Mhz */ clock_set_rate(CLOCK_ID_CGENERAL, 600, 12, 0, 8); clock_set_rate(CLOCK_ID_DISPLAY, 925, 12, 0, 12); break; @@ -996,6 +981,7 @@ void clock_early_init(void) break; case CLOCK_OSC_FREQ_13_0: /* OSC is 13Mhz */ + case CLOCK_OSC_FREQ_16_8: /* OSC is 16.8Mhz */ clock_set_rate(CLOCK_ID_CGENERAL, 600, 13, 0, 8); clock_set_rate(CLOCK_ID_DISPLAY, 925, 13, 0, 12); break; diff --git a/arch/arm/mach-tegra/tegra30/clock.c b/arch/arm/mach-tegra/tegra30/clock.c index c835cd0d47..449b66e3b2 100644 --- a/arch/arm/mach-tegra/tegra30/clock.c +++ b/arch/arm/mach-tegra/tegra30/clock.c @@ -439,8 +439,7 @@ struct clk_pll_info tegra_pll_info_table[CLOCK_ID_PLL_COUNT] = { /* * Get the oscillator frequency, from the corresponding hardware configuration - * field. Note that T30 supports 3 new higher freqs, but we map back - * to the old T20 freqs. Support for the higher oscillators is TBD. + * field. Note that T30+ supports 3 new higher freqs. */ enum clock_osc_freq clock_get_osc_freq(void) { @@ -449,12 +448,7 @@ enum clock_osc_freq clock_get_osc_freq(void) u32 reg; reg = readl(&clkrst->crc_osc_ctrl); - reg = (reg & OSC_FREQ_MASK) >> OSC_FREQ_SHIFT; - - if (reg & 1) /* one of the newer freqs */ - printf("Warning: OSC_FREQ is unsupported! (%d)\n", reg); - - return reg >> 2; /* Map to most common (T20) freqs */ + return (reg & OSC_FREQ_MASK) >> OSC_FREQ_SHIFT; } /* Returns a pointer to the clock source register for a peripheral */ diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index 11d776747c..76562bd749 100644 --- a/drivers/usb/host/ehci-tegra.c +++ b/drivers/usb/host/ehci-tegra.c @@ -127,42 +127,70 @@ struct fdt_usb { static const unsigned T20_usb_pll[CLOCK_OSC_FREQ_COUNT][PARAM_COUNT] = { /* DivN, DivM, DivP, CPCON, LFCON, Delays Debounce, Bias */ { 0x3C0, 0x0D, 0x00, 0xC, 0, 0x02, 0x33, 0x05, 0x7F, 0x7EF4, 5 }, + { 0x3C0, 0x0D, 0x00, 0xC, 0, 0x02, 0x33, 0x05, 0x7F, 0x7EF4, 5 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, + { 0x0C8, 0x04, 0x00, 0x3, 0, 0x03, 0x4B, 0x06, 0xBB, 0xBB80, 7 }, { 0x0C8, 0x04, 0x00, 0x3, 0, 0x03, 0x4B, 0x06, 0xBB, 0xBB80, 7 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, + { 0x3C0, 0x0C, 0x00, 0xC, 0, 0x02, 0x2F, 0x04, 0x76, 0x7530, 5 }, { 0x3C0, 0x0C, 0x00, 0xC, 0, 0x02, 0x2F, 0x04, 0x76, 0x7530, 5 }, - { 0x3C0, 0x1A, 0x00, 0xC, 0, 0x04, 0x66, 0x09, 0xFE, 0xFDE8, 9 }, { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, - { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 } + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, + { 0x3C0, 0x1A, 0x00, 0xC, 0, 0x04, 0x66, 0x09, 0xFE, 0xFDE8, 9 } }; static const unsigned T30_usb_pll[CLOCK_OSC_FREQ_COUNT][PARAM_COUNT] = { /* DivN, DivM, DivP, CPCON, LFCON, Delays Debounce, Bias */ { 0x3C0, 0x0D, 0x00, 0xC, 1, 0x02, 0x33, 0x09, 0x7F, 0x7EF4, 5 }, + { 0x3C0, 0x0D, 0x00, 0xC, 1, 0x02, 0x33, 0x09, 0x7F, 0x7EF4, 5 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, { 0x0C8, 0x04, 0x00, 0x3, 0, 0x03, 0x4B, 0x0C, 0xBB, 0xBB80, 7 }, + { 0x0C8, 0x04, 0x00, 0x3, 0, 0x03, 0x4B, 0x0C, 0xBB, 0xBB80, 7 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, { 0x3C0, 0x0C, 0x00, 0xC, 1, 0x02, 0x2F, 0x08, 0x76, 0x7530, 5 }, - { 0x3C0, 0x1A, 0x00, 0xC, 1, 0x04, 0x66, 0x09, 0xFE, 0xFDE8, 9 }, + { 0x3C0, 0x0C, 0x00, 0xC, 1, 0x02, 0x2F, 0x08, 0x76, 0x7530, 5 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, - { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 } + { 0x3C0, 0x1A, 0x00, 0xC, 1, 0x04, 0x66, 0x09, 0xFE, 0xFDE8, 9 } }; static const unsigned T114_usb_pll[CLOCK_OSC_FREQ_COUNT][PARAM_COUNT] = { /* DivN, DivM, DivP, CPCON, LFCON, Delays Debounce, Bias */ { 0x3C0, 0x0D, 0x00, 0xC, 2, 0x02, 0x33, 0x09, 0x7F, 0x7EF4, 6 }, + { 0x3C0, 0x0D, 0x00, 0xC, 2, 0x02, 0x33, 0x09, 0x7F, 0x7EF4, 6 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, + { 0x0C8, 0x04, 0x00, 0x3, 2, 0x03, 0x4B, 0x0C, 0xBB, 0xBB80, 8 }, { 0x0C8, 0x04, 0x00, 0x3, 2, 0x03, 0x4B, 0x0C, 0xBB, 0xBB80, 8 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, + { 0x3C0, 0x0C, 0x00, 0xC, 2, 0x02, 0x2F, 0x08, 0x76, 0x7530, 5 }, { 0x3C0, 0x0C, 0x00, 0xC, 2, 0x02, 0x2F, 0x08, 0x76, 0x7530, 5 }, - { 0x3C0, 0x1A, 0x00, 0xC, 2, 0x04, 0x66, 0x09, 0xFE, 0xFDE8, 11 }, { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, - { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 } + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0x0000, 0 }, + { 0x3C0, 0x1A, 0x00, 0xC, 2, 0x04, 0x66, 0x09, 0xFE, 0xFDE8, 11 } }; /* NOTE: 13/26MHz settings are N/A for T210, so dupe 12MHz settings for now */ static const unsigned T210_usb_pll[CLOCK_OSC_FREQ_COUNT][PARAM_COUNT] = { /* DivN, DivM, DivP, KCP, KVCO, Delays Debounce, Bias */ { 0x028, 0x01, 0x01, 0x0, 0, 0x02, 0x2F, 0x08, 0x76, 32500, 5 }, + { 0x028, 0x01, 0x01, 0x0, 0, 0x02, 0x2F, 0x08, 0x76, 32500, 5 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0, 0 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0, 0 }, { 0x019, 0x01, 0x01, 0x0, 0, 0x03, 0x4B, 0x0C, 0xBB, 48000, 8 }, - { 0x028, 0x01, 0x01, 0x0, 0, 0x02, 0x2F, 0x08, 0x76, 30000, 5 }, - { 0x028, 0x01, 0x01, 0x0, 0, 0x02, 0x2F, 0x08, 0x76, 65000, 5 }, { 0x019, 0x02, 0x01, 0x0, 0, 0x05, 0x96, 0x18, 0x177, 96000, 15 }, - { 0x028, 0x04, 0x01, 0x0, 0, 0x04, 0x66, 0x09, 0xFE, 120000, 20 } + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0, 0 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0, 0 }, + { 0x028, 0x01, 0x01, 0x0, 0, 0x02, 0x2F, 0x08, 0x76, 30000, 5 }, + { 0x028, 0x04, 0x01, 0x0, 0, 0x04, 0x66, 0x09, 0xFE, 120000, 20 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0, 0 }, + { 0x000, 0x00, 0x00, 0x0, 0, 0x00, 0x00, 0x00, 0x00, 0, 0 }, + { 0x028, 0x01, 0x01, 0x0, 0, 0x02, 0x2F, 0x08, 0x76, 65000, 5 } }; /* UTMIP Idle Wait Delay */ -- 2.37.2 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v6 2/3] drivers: timer: add timer driver for ARMv7 based Tegra devices 2023-01-24 6:57 [PATCH v6 0/3] Timer support for ARM Tegra Svyatoslav Ryhel 2023-01-24 6:57 ` [PATCH v6 1/3] ARM: tegra: remap clock_osc_freq for all Tegra family Svyatoslav Ryhel @ 2023-01-24 6:57 ` Svyatoslav Ryhel 2023-01-24 6:57 ` [PATCH v6 3/3] ARM: tegra: include timer as default option Svyatoslav Ryhel 2023-01-25 16:41 ` [PATCH v6 0/3] Timer support for ARM Tegra Thierry Reding 3 siblings, 0 replies; 18+ messages in thread From: Svyatoslav Ryhel @ 2023-01-24 6:57 UTC (permalink / raw) To: Rayagonda Kokatanur, Tom Warren, Thierry Reding, Marek Vasut, Svyatoslav Ryhel, Maxim Schwalm, Dmitry Osipenko, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung Cc: u-boot Add timer support for T20/T30/T114 and T124 based devices. Driver is based on DM, has device tree support and can be used on SPL and early boot stage. Arm64 Tegra according to comment in tegra-common.h uses architected timer. Tested-by: Andreas Westman Dorcsak <hedmoo@yahoo.com> # ASUS TF600T T30 Tested-by: Jonas Schwöbel <jonasschwoebel@yahoo.de> # Surface RT T30 Tested-by: Robert Eckelmann <longnoserob@gmail.com> # ASUS TF101 T20 Tested-by: Agneli <poczt@protomail.ch> # Toshiba AC100 T20 Tested-by: Svyatoslav Ryhel <clamor95@gmail.com> # LG P895 T30 Co-developed-by: Jonas Schwöbel <jonasschwoebel@yahoo.de> Signed-off-by: Jonas Schwöbel <jonasschwoebel@yahoo.de> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> Reviewed-by: Simon Glass <sjg@chromium.org> --- Changed in v6: - added paz00 tester Changed in v5: - added comments Changed in v4: - removed BOOTSTAGE ifdefs - use early timer on boot stage unconditionally --- drivers/timer/Kconfig | 8 +++ drivers/timer/Makefile | 1 + drivers/timer/tegra-timer.c | 126 ++++++++++++++++++++++++++++++++++++ 3 files changed, 135 insertions(+) create mode 100644 drivers/timer/tegra-timer.c diff --git a/drivers/timer/Kconfig b/drivers/timer/Kconfig index 6d6665005c..f32bd16227 100644 --- a/drivers/timer/Kconfig +++ b/drivers/timer/Kconfig @@ -252,6 +252,14 @@ config STM32_TIMER Select this to enable support for the timer found on STM32 devices. +config TEGRA_TIMER + bool "Tegra timer support" + depends on TIMER + select TIMER_EARLY + help + Select this to enable support for the timer found on + Tegra devices. + config X86_TSC_TIMER bool "x86 Time-Stamp Counter (TSC) timer support" depends on TIMER && X86 diff --git a/drivers/timer/Makefile b/drivers/timer/Makefile index 6470fd5426..3c92113fc6 100644 --- a/drivers/timer/Makefile +++ b/drivers/timer/Makefile @@ -27,6 +27,7 @@ obj-$(CONFIG_SP804_TIMER) += sp804_timer.o obj-$(CONFIG_$(SPL_)SIFIVE_CLINT) += sifive_clint_timer.o obj-$(CONFIG_ARM_GLOBAL_TIMER) += arm_global_timer.o obj-$(CONFIG_STM32_TIMER) += stm32_timer.o +obj-$(CONFIG_TEGRA_TIMER) += tegra-timer.o obj-$(CONFIG_X86_TSC_TIMER) += tsc_timer.o obj-$(CONFIG_MTK_TIMER) += mtk_timer.o obj-$(CONFIG_MCHP_PIT64B_TIMER) += mchp-pit64b-timer.o diff --git a/drivers/timer/tegra-timer.c b/drivers/timer/tegra-timer.c new file mode 100644 index 0000000000..d2d163cf3f --- /dev/null +++ b/drivers/timer/tegra-timer.c @@ -0,0 +1,126 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2022 Svyatoslav Ryhel <clamor95@gmail.com> + */ + +#include <common.h> +#include <dm.h> +#include <errno.h> +#include <timer.h> + +#include <asm/io.h> +#include <asm/arch/clock.h> +#include <asm/arch/tegra.h> + +#define TEGRA_OSC_CLK_ENB_L_SET (NV_PA_CLK_RST_BASE + 0x320) +#define TEGRA_OSC_SET_CLK_ENB_TMR BIT(5) + +#define TEGRA_TIMER_USEC_CNTR (NV_PA_TMRUS_BASE + 0) +#define TEGRA_TIMER_USEC_CFG (NV_PA_TMRUS_BASE + 4) + +#define TEGRA_TIMER_RATE 1000000 /* 1 MHz */ + +/* + * On pre-DM stage timer should be left configured by + * previous bootloader for correct 1MHz clock. + * In the case of reset default value set is 1/13 of + * osc clock which should be decent enough to safely + * get to DM stage. + */ +u64 notrace timer_early_get_count(void) +{ + /* At this stage raw timer is used */ + return readl(TEGRA_TIMER_USEC_CNTR); +} + +unsigned long notrace timer_early_get_rate(void) +{ + return TEGRA_TIMER_RATE; +} + +ulong timer_get_boot_us(void) +{ + return timer_early_get_count(); +} + +/* + * At moment of calling get_count, timer driver is already + * probed and is configured to have precise 1MHz clock. + * Tegra timer has a step of 1 microsecond which removes + * need of using adjusments involving uc_priv->clock_rate. + */ +static notrace u64 tegra_timer_get_count(struct udevice *dev) +{ + u32 val = timer_early_get_count(); + return timer_conv_64(val); +} + +static int tegra_timer_probe(struct udevice *dev) +{ + struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); + u32 usec_config, value; + + /* Timer rate has to be set unconditionally */ + uc_priv->clock_rate = TEGRA_TIMER_RATE; + + /* + * Configure microsecond timers to have 1MHz clock + * Config register is 0xqqww, where qq is "dividend", ww is "divisor" + * Uses n+1 scheme + */ + switch (clock_get_osc_freq()) { + case CLOCK_OSC_FREQ_13_0: + usec_config = 0x000c; /* (12+1)/(0+1) */ + break; + case CLOCK_OSC_FREQ_19_2: + usec_config = 0x045f; /* (95+1)/(4+1) */ + break; + case CLOCK_OSC_FREQ_12_0: + usec_config = 0x000b; /* (11+1)/(0+1) */ + break; + case CLOCK_OSC_FREQ_26_0: + usec_config = 0x0019; /* (25+1)/(0+1) */ + break; + case CLOCK_OSC_FREQ_16_8: + usec_config = 0x0453; /* (83+1)/(4+1) */ + break; + case CLOCK_OSC_FREQ_38_4: + usec_config = 0x04bf; /* (191+1)/(4+1) */ + break; + case CLOCK_OSC_FREQ_48_0: + usec_config = 0x002f; /* (47+1)/(0+1) */ + break; + default: + return -EINVAL; + } + + /* Enable clock to timer hardware */ + value = readl_relaxed(TEGRA_OSC_CLK_ENB_L_SET); + writel_relaxed(value | TEGRA_OSC_SET_CLK_ENB_TMR, + TEGRA_OSC_CLK_ENB_L_SET); + + writel_relaxed(usec_config, TEGRA_TIMER_USEC_CFG); + + return 0; +} + +static const struct timer_ops tegra_timer_ops = { + .get_count = tegra_timer_get_count, +}; + +static const struct udevice_id tegra_timer_ids[] = { + { .compatible = "nvidia,tegra20-timer" }, + { .compatible = "nvidia,tegra30-timer" }, + { .compatible = "nvidia,tegra114-timer" }, + { .compatible = "nvidia,tegra124-timer" }, + { } +}; + +U_BOOT_DRIVER(tegra_timer) = { + .name = "tegra_timer", + .id = UCLASS_TIMER, + .of_match = tegra_timer_ids, + .probe = tegra_timer_probe, + .ops = &tegra_timer_ops, + .flags = DM_FLAG_PRE_RELOC, +}; -- 2.37.2 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v6 3/3] ARM: tegra: include timer as default option 2023-01-24 6:57 [PATCH v6 0/3] Timer support for ARM Tegra Svyatoslav Ryhel 2023-01-24 6:57 ` [PATCH v6 1/3] ARM: tegra: remap clock_osc_freq for all Tegra family Svyatoslav Ryhel 2023-01-24 6:57 ` [PATCH v6 2/3] drivers: timer: add timer driver for ARMv7 based Tegra devices Svyatoslav Ryhel @ 2023-01-24 6:57 ` Svyatoslav Ryhel 2023-01-25 16:41 ` [PATCH v6 0/3] Timer support for ARM Tegra Thierry Reding 3 siblings, 0 replies; 18+ messages in thread From: Svyatoslav Ryhel @ 2023-01-24 6:57 UTC (permalink / raw) To: Rayagonda Kokatanur, Tom Warren, Thierry Reding, Marek Vasut, Svyatoslav Ryhel, Maxim Schwalm, Dmitry Osipenko, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung Cc: u-boot Enable TIMER as default option for all Tegra devices and enable TEGRA_TIMER for TEGRA_ARMV7_COMMON. Additionally enable SPL_TIMER if build as SPL part and drop deprecated configs from common header. Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> Reviewed-by: Simon Glass <sjg@chromium.org> --- arch/arm/Kconfig | 1 + arch/arm/mach-tegra/Kconfig | 2 ++ include/configs/tegra-common.h | 6 ------ 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index c9a44ebc22..92cf509e97 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1284,6 +1284,7 @@ config ARCH_TEGRA select GPIO_EXTRA_HEADER imply DISTRO_DEFAULTS imply FAT_WRITE + imply SPL_TIMER if SPL config ARCH_VEXPRESS64 bool "Support ARMv8 Arm Ltd. VExpress based boards and models" diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig index 1b575cc0f4..cc3f00e501 100644 --- a/arch/arm/mach-tegra/Kconfig +++ b/arch/arm/mach-tegra/Kconfig @@ -56,6 +56,7 @@ config TEGRA_COMMON select MISC select OF_CONTROL select SPI + select TIMER imply CMD_DM imply CRC32_VERIFY @@ -81,6 +82,7 @@ config TEGRA_ARMV7_COMMON select TEGRA_NO_BPMP select TEGRA_PINCTRL select TEGRA_PMC + select TEGRA_TIMER config TEGRA_ARMV8_COMMON bool "Tegra 64-bit common options" diff --git a/include/configs/tegra-common.h b/include/configs/tegra-common.h index bde7ffce00..c558679d04 100644 --- a/include/configs/tegra-common.h +++ b/include/configs/tegra-common.h @@ -15,12 +15,6 @@ #include <asm/arch/tegra.h> /* get chip and board defs */ -/* Use the Tegra US timer on ARMv7, but the architected timer on ARMv8. */ -#ifndef CONFIG_ARM64 -#define CFG_SYS_TIMER_RATE 1000000 -#define CFG_SYS_TIMER_COUNTER NV_PA_TMRUS_BASE -#endif - /* Environment */ /* -- 2.37.2 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v6 0/3] Timer support for ARM Tegra 2023-01-24 6:57 [PATCH v6 0/3] Timer support for ARM Tegra Svyatoslav Ryhel ` (2 preceding siblings ...) 2023-01-24 6:57 ` [PATCH v6 3/3] ARM: tegra: include timer as default option Svyatoslav Ryhel @ 2023-01-25 16:41 ` Thierry Reding 2023-01-26 10:34 ` Thierry Reding 3 siblings, 1 reply; 18+ messages in thread From: Thierry Reding @ 2023-01-25 16:41 UTC (permalink / raw) To: Svyatoslav Ryhel Cc: Rayagonda Kokatanur, Tom Warren, Marek Vasut, Maxim Schwalm, Dmitry Osipenko, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung, u-boot [-- Attachment #1: Type: text/plain, Size: 2364 bytes --] On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: > - ARM: tegra: remap clock_osc_freq for all Tegra family > Enum clock_osc_freq was designed to use only with T20. > This patch remaps it to use additional frequencies, added in > T30+ SoC while maintaining backwards compatibility with T20. > > - drivers: timer: add timer driver for ARMv7 based Tegra devices > Add timer support for T20/T30/T114 and T124 based devices. > Driver is based on DM, has device tree support and can be > used on SPL and early boot stage. > > - ARM: tegra: include timer as default option > Enable TIMER as default option for all Tegra devices and > enable TEGRA_TIMER for TEGRA_ARMV7_COMMON. Additionally > enable SPL_TIMER if build as SPL part and drop deprecated > configs from common header. > > P. S. I have no arm64 Tegra and according to comment in > tegra-common.h > Use the Tegra US timer on ARMv7, but the architected timer on ARMv8. > > Svyatoslav Ryhel (3): > ARM: tegra: remap clock_osc_freq for all Tegra family > drivers: timer: add timer driver for ARMv7 based Tegra devices > ARM: tegra: include timer as default option This causes a regression on Tegra210 (Jetson TX1). I'm trying to investigate, but it's complicated by the fact that I'm not getting out any debug prints, so I suspect the issue is happening quite early. Thierry > > arch/arm/Kconfig | 1 + > arch/arm/include/asm/arch-tegra/clock.h | 9 +- > arch/arm/mach-tegra/Kconfig | 2 + > arch/arm/mach-tegra/clock.c | 17 +++- > arch/arm/mach-tegra/cpu.c | 70 ++++++++++--- > arch/arm/mach-tegra/tegra114/clock.c | 13 +-- > arch/arm/mach-tegra/tegra124/clock.c | 13 +-- > arch/arm/mach-tegra/tegra20/clock.c | 4 +- > arch/arm/mach-tegra/tegra210/clock.c | 22 +---- > arch/arm/mach-tegra/tegra30/clock.c | 10 +- > drivers/timer/Kconfig | 8 ++ > drivers/timer/Makefile | 1 + > drivers/timer/tegra-timer.c | 126 ++++++++++++++++++++++++ > drivers/usb/host/ehci-tegra.c | 46 +++++++-- > include/configs/tegra-common.h | 6 -- > 15 files changed, 269 insertions(+), 79 deletions(-) > create mode 100644 drivers/timer/tegra-timer.c > > -- > 2.37.2 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 0/3] Timer support for ARM Tegra 2023-01-25 16:41 ` [PATCH v6 0/3] Timer support for ARM Tegra Thierry Reding @ 2023-01-26 10:34 ` Thierry Reding 2023-01-26 11:40 ` Thierry Reding 2023-01-26 17:08 ` Svyatoslav Ryhel 0 siblings, 2 replies; 18+ messages in thread From: Thierry Reding @ 2023-01-26 10:34 UTC (permalink / raw) To: Svyatoslav Ryhel Cc: Rayagonda Kokatanur, Tom Warren, Marek Vasut, Maxim Schwalm, Dmitry Osipenko, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung, u-boot [-- Attachment #1: Type: text/plain, Size: 4059 bytes --] On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: > On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: > > - ARM: tegra: remap clock_osc_freq for all Tegra family > > Enum clock_osc_freq was designed to use only with T20. > > This patch remaps it to use additional frequencies, added in > > T30+ SoC while maintaining backwards compatibility with T20. > > > > - drivers: timer: add timer driver for ARMv7 based Tegra devices > > Add timer support for T20/T30/T114 and T124 based devices. > > Driver is based on DM, has device tree support and can be > > used on SPL and early boot stage. > > > > - ARM: tegra: include timer as default option > > Enable TIMER as default option for all Tegra devices and > > enable TEGRA_TIMER for TEGRA_ARMV7_COMMON. Additionally > > enable SPL_TIMER if build as SPL part and drop deprecated > > configs from common header. > > > > P. S. I have no arm64 Tegra and according to comment in > > tegra-common.h > > Use the Tegra US timer on ARMv7, but the architected timer on ARMv8. > > > > Svyatoslav Ryhel (3): > > ARM: tegra: remap clock_osc_freq for all Tegra family > > drivers: timer: add timer driver for ARMv7 based Tegra devices > > ARM: tegra: include timer as default option > > This causes a regression on Tegra210 (Jetson TX1). I'm trying to > investigate, but it's complicated by the fact that I'm not getting out > any debug prints, so I suspect the issue is happening quite early. Alright, I managed to make this work on Tegra210 using the following patch on top of this series: --- >8 --- diff --git a/arch/arm/dts/tegra210.dtsi b/arch/arm/dts/tegra210.dtsi index a521a43d6cfd..ccb5a927da89 100644 --- a/arch/arm/dts/tegra210.dtsi +++ b/arch/arm/dts/tegra210.dtsi @@ -318,7 +318,7 @@ }; timer@60005000 { - compatible = "nvidia,tegra210-timer", "nvidia,tegra20-timer"; + compatible = "nvidia,tegra210-timer", "nvidia,tegra30-timer", "nvidia,tegra20-timer"; reg = <0x0 0x60005000 0x0 0x400>; interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig index cc3f00e50128..b50eec5b8c9b 100644 --- a/arch/arm/mach-tegra/Kconfig +++ b/arch/arm/mach-tegra/Kconfig @@ -136,6 +136,7 @@ config TEGRA210 select TEGRA_PINCTRL select TEGRA_PMC select TEGRA_PMC_SECURE + select TEGRA_TIMER config TEGRA186 bool "Tegra186 family" diff --git a/drivers/timer/tegra-timer.c b/drivers/timer/tegra-timer.c index d2d163cf3fef..235532ba8926 100644 --- a/drivers/timer/tegra-timer.c +++ b/drivers/timer/tegra-timer.c @@ -58,17 +58,26 @@ static notrace u64 tegra_timer_get_count(struct udevice *dev) static int tegra_timer_probe(struct udevice *dev) { struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); + enum clock_osc_freq freq; u32 usec_config, value; /* Timer rate has to be set unconditionally */ uc_priv->clock_rate = TEGRA_TIMER_RATE; + /* + * The microsecond timer runs off of clk_m on Tegra210, and clk_m + * runs at half the OSC, so fake this up. + */ + freq = clock_get_osc_freq(); + if (freq == CLOCK_OSC_FREQ_38_4) + freq = CLOCK_OSC_FREQ_19_2; + /* * Configure microsecond timers to have 1MHz clock * Config register is 0xqqww, where qq is "dividend", ww is "divisor" * Uses n+1 scheme */ - switch (clock_get_osc_freq()) { + switch (freq) { case CLOCK_OSC_FREQ_13_0: usec_config = 0x000c; /* (12+1)/(0+1) */ break; @@ -113,6 +122,7 @@ static const struct udevice_id tegra_timer_ids[] = { { .compatible = "nvidia,tegra30-timer" }, { .compatible = "nvidia,tegra114-timer" }, { .compatible = "nvidia,tegra124-timer" }, + { .compatible = "nvidia,tegra210-timer" }, { } }; --- >8 --- I've also tested this on Tegra186, though no additional changes were needed since Tegra186 doesn't use the Tegra timer. With the above folded in, the series is: Tested-by: Thierry Reding <treding@nvidia.com> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v6 0/3] Timer support for ARM Tegra 2023-01-26 10:34 ` Thierry Reding @ 2023-01-26 11:40 ` Thierry Reding 2023-01-26 16:49 ` Tom Warren 2023-01-26 17:08 ` Svyatoslav Ryhel 1 sibling, 1 reply; 18+ messages in thread From: Thierry Reding @ 2023-01-26 11:40 UTC (permalink / raw) To: Svyatoslav Ryhel Cc: Rayagonda Kokatanur, Tom Warren, Marek Vasut, Maxim Schwalm, Dmitry Osipenko, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung, u-boot [-- Attachment #1: Type: text/plain, Size: 4468 bytes --] On Thu, Jan 26, 2023 at 11:34:59AM +0100, Thierry Reding wrote: > On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: > > On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: > > > - ARM: tegra: remap clock_osc_freq for all Tegra family > > > Enum clock_osc_freq was designed to use only with T20. > > > This patch remaps it to use additional frequencies, added in > > > T30+ SoC while maintaining backwards compatibility with T20. > > > > > > - drivers: timer: add timer driver for ARMv7 based Tegra devices > > > Add timer support for T20/T30/T114 and T124 based devices. > > > Driver is based on DM, has device tree support and can be > > > used on SPL and early boot stage. > > > > > > - ARM: tegra: include timer as default option > > > Enable TIMER as default option for all Tegra devices and > > > enable TEGRA_TIMER for TEGRA_ARMV7_COMMON. Additionally > > > enable SPL_TIMER if build as SPL part and drop deprecated > > > configs from common header. > > > > > > P. S. I have no arm64 Tegra and according to comment in > > > tegra-common.h > > > Use the Tegra US timer on ARMv7, but the architected timer on ARMv8. > > > > > > Svyatoslav Ryhel (3): > > > ARM: tegra: remap clock_osc_freq for all Tegra family > > > drivers: timer: add timer driver for ARMv7 based Tegra devices > > > ARM: tegra: include timer as default option > > > > This causes a regression on Tegra210 (Jetson TX1). I'm trying to > > investigate, but it's complicated by the fact that I'm not getting out > > any debug prints, so I suspect the issue is happening quite early. > > Alright, I managed to make this work on Tegra210 using the following > patch on top of this series: > > --- >8 --- > diff --git a/arch/arm/dts/tegra210.dtsi b/arch/arm/dts/tegra210.dtsi > index a521a43d6cfd..ccb5a927da89 100644 > --- a/arch/arm/dts/tegra210.dtsi > +++ b/arch/arm/dts/tegra210.dtsi > @@ -318,7 +318,7 @@ > }; > > timer@60005000 { > - compatible = "nvidia,tegra210-timer", "nvidia,tegra20-timer"; > + compatible = "nvidia,tegra210-timer", "nvidia,tegra30-timer", "nvidia,tegra20-timer"; > reg = <0x0 0x60005000 0x0 0x400>; > interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, > diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig > index cc3f00e50128..b50eec5b8c9b 100644 > --- a/arch/arm/mach-tegra/Kconfig > +++ b/arch/arm/mach-tegra/Kconfig > @@ -136,6 +136,7 @@ config TEGRA210 > select TEGRA_PINCTRL > select TEGRA_PMC > select TEGRA_PMC_SECURE > + select TEGRA_TIMER > > config TEGRA186 > bool "Tegra186 family" > diff --git a/drivers/timer/tegra-timer.c b/drivers/timer/tegra-timer.c > index d2d163cf3fef..235532ba8926 100644 > --- a/drivers/timer/tegra-timer.c > +++ b/drivers/timer/tegra-timer.c > @@ -58,17 +58,26 @@ static notrace u64 tegra_timer_get_count(struct udevice *dev) > static int tegra_timer_probe(struct udevice *dev) > { > struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); > + enum clock_osc_freq freq; > u32 usec_config, value; > > /* Timer rate has to be set unconditionally */ > uc_priv->clock_rate = TEGRA_TIMER_RATE; > > + /* > + * The microsecond timer runs off of clk_m on Tegra210, and clk_m > + * runs at half the OSC, so fake this up. > + */ > + freq = clock_get_osc_freq(); > + if (freq == CLOCK_OSC_FREQ_38_4) > + freq = CLOCK_OSC_FREQ_19_2; > + > /* > * Configure microsecond timers to have 1MHz clock > * Config register is 0xqqww, where qq is "dividend", ww is "divisor" > * Uses n+1 scheme > */ > - switch (clock_get_osc_freq()) { > + switch (freq) { > case CLOCK_OSC_FREQ_13_0: > usec_config = 0x000c; /* (12+1)/(0+1) */ > break; > @@ -113,6 +122,7 @@ static const struct udevice_id tegra_timer_ids[] = { > { .compatible = "nvidia,tegra30-timer" }, > { .compatible = "nvidia,tegra114-timer" }, > { .compatible = "nvidia,tegra124-timer" }, > + { .compatible = "nvidia,tegra210-timer" }, > { } > }; > --- >8 --- > > I've also tested this on Tegra186, though no additional changes were > needed since Tegra186 doesn't use the Tegra timer. > > With the above folded in, the series is: > > Tested-by: Thierry Reding <treding@nvidia.com> I've also tested your series with the above on Tegra30 (Beaver) and Tegra124 (Jetson TK1), both seem to work fine. Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH v6 0/3] Timer support for ARM Tegra 2023-01-26 11:40 ` Thierry Reding @ 2023-01-26 16:49 ` Tom Warren 2023-01-26 17:12 ` Svyatoslav Ryhel 0 siblings, 1 reply; 18+ messages in thread From: Tom Warren @ 2023-01-26 16:49 UTC (permalink / raw) To: Thierry Reding, Svyatoslav Ryhel Cc: Rayagonda Kokatanur, Marek Vasut, Maxim Schwalm, Dmitry Osipenko, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung, u-boot@lists.denx.de Thanks for testing T210/T186, Thierry. I had Svyatoslav's patches ready to go for a PR yesterday, so I'll need either a patch from you for the T210 changes that I can apply on top of his, or I'll need Svyatoslav to adopt your changes as a 4th patch in his series. Once I have that and can pass buildman OK, I'll be ready to send a PR to TomR. Tom -----Original Message----- From: Thierry Reding <thierry.reding@gmail.com> Sent: Thursday, January 26, 2023 4:41 AM To: Svyatoslav Ryhel <clamor95@gmail.com> Cc: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>; Tom Warren <twarren@nvidia.com>; Marek Vasut <marex@denx.de>; Maxim Schwalm <maxim.schwalm@gmail.com>; Dmitry Osipenko <digetx@gmail.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>; Michal Simek <michal.simek@amd.com>; Stefan Roese <sr@denx.de>; Eugen Hristev <eugen.hristev@microchip.com>; Michael Walle <michael@walle.cc>; Simon Glass <sjg@chromium.org>; Jim Liu <jim.t90615@gmail.com>; William Zhang <william.zhang@broadcom.com>; Rick Chen <rick@andestech.com>; Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>; Andre Przywara <andre.przywara@arm.com>; Jaehoon Chung <jh80.chung@samsung.com>; u-boot@lists.denx.de Subject: Re: [PATCH v6 0/3] Timer support for ARM Tegra On Thu, Jan 26, 2023 at 11:34:59AM +0100, Thierry Reding wrote: > On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: > > On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: > > > - ARM: tegra: remap clock_osc_freq for all Tegra family Enum > > > clock_osc_freq was designed to use only with T20. > > > This patch remaps it to use additional frequencies, added in > > > T30+ SoC while maintaining backwards compatibility with T20. > > > > > > - drivers: timer: add timer driver for ARMv7 based Tegra devices > > > Add timer support for T20/T30/T114 and T124 based devices. > > > Driver is based on DM, has device tree support and can be used on > > > SPL and early boot stage. > > > > > > - ARM: tegra: include timer as default option Enable TIMER as > > > default option for all Tegra devices and enable TEGRA_TIMER for > > > TEGRA_ARMV7_COMMON. Additionally enable SPL_TIMER if build as SPL > > > part and drop deprecated configs from common header. > > > > > > P. S. I have no arm64 Tegra and according to comment in > > > tegra-common.h Use the Tegra US timer on ARMv7, but the > > > architected timer on ARMv8. > > > > > > Svyatoslav Ryhel (3): > > > ARM: tegra: remap clock_osc_freq for all Tegra family > > > drivers: timer: add timer driver for ARMv7 based Tegra devices > > > ARM: tegra: include timer as default option > > > > This causes a regression on Tegra210 (Jetson TX1). I'm trying to > > investigate, but it's complicated by the fact that I'm not getting > > out any debug prints, so I suspect the issue is happening quite early. > > Alright, I managed to make this work on Tegra210 using the following > patch on top of this series: > > --- >8 --- > diff --git a/arch/arm/dts/tegra210.dtsi b/arch/arm/dts/tegra210.dtsi > index a521a43d6cfd..ccb5a927da89 100644 > --- a/arch/arm/dts/tegra210.dtsi > +++ b/arch/arm/dts/tegra210.dtsi > @@ -318,7 +318,7 @@ > }; > > timer@60005000 { > - compatible = "nvidia,tegra210-timer", "nvidia,tegra20-timer"; > + compatible = "nvidia,tegra210-timer", "nvidia,tegra30-timer", > +"nvidia,tegra20-timer"; > reg = <0x0 0x60005000 0x0 0x400>; > interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, diff --git > a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig index > cc3f00e50128..b50eec5b8c9b 100644 > --- a/arch/arm/mach-tegra/Kconfig > +++ b/arch/arm/mach-tegra/Kconfig > @@ -136,6 +136,7 @@ config TEGRA210 > select TEGRA_PINCTRL > select TEGRA_PMC > select TEGRA_PMC_SECURE > + select TEGRA_TIMER > > config TEGRA186 > bool "Tegra186 family" > diff --git a/drivers/timer/tegra-timer.c b/drivers/timer/tegra-timer.c > index d2d163cf3fef..235532ba8926 100644 > --- a/drivers/timer/tegra-timer.c > +++ b/drivers/timer/tegra-timer.c > @@ -58,17 +58,26 @@ static notrace u64 tegra_timer_get_count(struct > udevice *dev) static int tegra_timer_probe(struct udevice *dev) { > struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); > + enum clock_osc_freq freq; > u32 usec_config, value; > > /* Timer rate has to be set unconditionally */ > uc_priv->clock_rate = TEGRA_TIMER_RATE; > > + /* > + * The microsecond timer runs off of clk_m on Tegra210, and clk_m > + * runs at half the OSC, so fake this up. > + */ > + freq = clock_get_osc_freq(); > + if (freq == CLOCK_OSC_FREQ_38_4) > + freq = CLOCK_OSC_FREQ_19_2; > + > /* > * Configure microsecond timers to have 1MHz clock > * Config register is 0xqqww, where qq is "dividend", ww is "divisor" > * Uses n+1 scheme > */ > - switch (clock_get_osc_freq()) { > + switch (freq) { > case CLOCK_OSC_FREQ_13_0: > usec_config = 0x000c; /* (12+1)/(0+1) */ > break; > @@ -113,6 +122,7 @@ static const struct udevice_id tegra_timer_ids[] = { > { .compatible = "nvidia,tegra30-timer" }, > { .compatible = "nvidia,tegra114-timer" }, > { .compatible = "nvidia,tegra124-timer" }, > + { .compatible = "nvidia,tegra210-timer" }, > { } > }; > --- >8 --- > > I've also tested this on Tegra186, though no additional changes were > needed since Tegra186 doesn't use the Tegra timer. > > With the above folded in, the series is: > > Tested-by: Thierry Reding <treding@nvidia.com> I've also tested your series with the above on Tegra30 (Beaver) and Tegra124 (Jetson TK1), both seem to work fine. Thierry ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 0/3] Timer support for ARM Tegra 2023-01-26 16:49 ` Tom Warren @ 2023-01-26 17:12 ` Svyatoslav Ryhel 2023-01-26 17:58 ` Thierry Reding 0 siblings, 1 reply; 18+ messages in thread From: Svyatoslav Ryhel @ 2023-01-26 17:12 UTC (permalink / raw) To: Tom Warren Cc: Thierry Reding, Rayagonda Kokatanur, Marek Vasut, Maxim Schwalm, Dmitry Osipenko, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung, u-boot@lists.denx.de I may implement changes of Thierry Reding in a proper form as a separate patch or include in existing (depends on his choice). The only thing I need to know is if ALL known T210 devices use 19.2MHz as calibration clock for timer? Best regards. Svyatoslav R. чт, 26 січ. 2023 р. о 18:50 Tom Warren <TWarren@nvidia.com> пише: > > Thanks for testing T210/T186, Thierry. > > I had Svyatoslav's patches ready to go for a PR yesterday, so I'll need either a patch from you for the T210 changes that I can apply on top of his, or I'll need Svyatoslav to adopt your changes as a 4th patch in his series. Once I have that and can pass buildman OK, I'll be ready to send a PR to TomR. > > Tom > > -----Original Message----- > From: Thierry Reding <thierry.reding@gmail.com> > Sent: Thursday, January 26, 2023 4:41 AM > To: Svyatoslav Ryhel <clamor95@gmail.com> > Cc: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>; Tom Warren <twarren@nvidia.com>; Marek Vasut <marex@denx.de>; Maxim Schwalm <maxim.schwalm@gmail.com>; Dmitry Osipenko <digetx@gmail.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>; Michal Simek <michal.simek@amd.com>; Stefan Roese <sr@denx.de>; Eugen Hristev <eugen.hristev@microchip.com>; Michael Walle <michael@walle.cc>; Simon Glass <sjg@chromium.org>; Jim Liu <jim.t90615@gmail.com>; William Zhang <william.zhang@broadcom.com>; Rick Chen <rick@andestech.com>; Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>; Andre Przywara <andre.przywara@arm.com>; Jaehoon Chung <jh80.chung@samsung.com>; u-boot@lists.denx.de > Subject: Re: [PATCH v6 0/3] Timer support for ARM Tegra > > On Thu, Jan 26, 2023 at 11:34:59AM +0100, Thierry Reding wrote: > > On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: > > > On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: > > > > - ARM: tegra: remap clock_osc_freq for all Tegra family Enum > > > > clock_osc_freq was designed to use only with T20. > > > > This patch remaps it to use additional frequencies, added in > > > > T30+ SoC while maintaining backwards compatibility with T20. > > > > > > > > - drivers: timer: add timer driver for ARMv7 based Tegra devices > > > > Add timer support for T20/T30/T114 and T124 based devices. > > > > Driver is based on DM, has device tree support and can be used on > > > > SPL and early boot stage. > > > > > > > > - ARM: tegra: include timer as default option Enable TIMER as > > > > default option for all Tegra devices and enable TEGRA_TIMER for > > > > TEGRA_ARMV7_COMMON. Additionally enable SPL_TIMER if build as SPL > > > > part and drop deprecated configs from common header. > > > > > > > > P. S. I have no arm64 Tegra and according to comment in > > > > tegra-common.h Use the Tegra US timer on ARMv7, but the > > > > architected timer on ARMv8. > > > > > > > > Svyatoslav Ryhel (3): > > > > ARM: tegra: remap clock_osc_freq for all Tegra family > > > > drivers: timer: add timer driver for ARMv7 based Tegra devices > > > > ARM: tegra: include timer as default option > > > > > > This causes a regression on Tegra210 (Jetson TX1). I'm trying to > > > investigate, but it's complicated by the fact that I'm not getting > > > out any debug prints, so I suspect the issue is happening quite early. > > > > Alright, I managed to make this work on Tegra210 using the following > > patch on top of this series: > > > > --- >8 --- > > diff --git a/arch/arm/dts/tegra210.dtsi b/arch/arm/dts/tegra210.dtsi > > index a521a43d6cfd..ccb5a927da89 100644 > > --- a/arch/arm/dts/tegra210.dtsi > > +++ b/arch/arm/dts/tegra210.dtsi > > @@ -318,7 +318,7 @@ > > }; > > > > timer@60005000 { > > - compatible = "nvidia,tegra210-timer", "nvidia,tegra20-timer"; > > + compatible = "nvidia,tegra210-timer", "nvidia,tegra30-timer", > > +"nvidia,tegra20-timer"; > > reg = <0x0 0x60005000 0x0 0x400>; > > interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, > > <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, diff --git > > a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig index > > cc3f00e50128..b50eec5b8c9b 100644 > > --- a/arch/arm/mach-tegra/Kconfig > > +++ b/arch/arm/mach-tegra/Kconfig > > @@ -136,6 +136,7 @@ config TEGRA210 > > select TEGRA_PINCTRL > > select TEGRA_PMC > > select TEGRA_PMC_SECURE > > + select TEGRA_TIMER > > > > config TEGRA186 > > bool "Tegra186 family" > > diff --git a/drivers/timer/tegra-timer.c b/drivers/timer/tegra-timer.c > > index d2d163cf3fef..235532ba8926 100644 > > --- a/drivers/timer/tegra-timer.c > > +++ b/drivers/timer/tegra-timer.c > > @@ -58,17 +58,26 @@ static notrace u64 tegra_timer_get_count(struct > > udevice *dev) static int tegra_timer_probe(struct udevice *dev) { > > struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); > > + enum clock_osc_freq freq; > > u32 usec_config, value; > > > > /* Timer rate has to be set unconditionally */ > > uc_priv->clock_rate = TEGRA_TIMER_RATE; > > > > + /* > > + * The microsecond timer runs off of clk_m on Tegra210, and clk_m > > + * runs at half the OSC, so fake this up. > > + */ > > + freq = clock_get_osc_freq(); > > + if (freq == CLOCK_OSC_FREQ_38_4) > > + freq = CLOCK_OSC_FREQ_19_2; > > + > > /* > > * Configure microsecond timers to have 1MHz clock > > * Config register is 0xqqww, where qq is "dividend", ww is "divisor" > > * Uses n+1 scheme > > */ > > - switch (clock_get_osc_freq()) { > > + switch (freq) { > > case CLOCK_OSC_FREQ_13_0: > > usec_config = 0x000c; /* (12+1)/(0+1) */ > > break; > > @@ -113,6 +122,7 @@ static const struct udevice_id tegra_timer_ids[] = { > > { .compatible = "nvidia,tegra30-timer" }, > > { .compatible = "nvidia,tegra114-timer" }, > > { .compatible = "nvidia,tegra124-timer" }, > > + { .compatible = "nvidia,tegra210-timer" }, > > { } > > }; > > --- >8 --- > > > > I've also tested this on Tegra186, though no additional changes were > > needed since Tegra186 doesn't use the Tegra timer. > > > > With the above folded in, the series is: > > > > Tested-by: Thierry Reding <treding@nvidia.com> > > I've also tested your series with the above on Tegra30 (Beaver) and > Tegra124 (Jetson TK1), both seem to work fine. > > Thierry ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 0/3] Timer support for ARM Tegra 2023-01-26 17:12 ` Svyatoslav Ryhel @ 2023-01-26 17:58 ` Thierry Reding 2023-01-26 18:10 ` Svyatoslav Ryhel 2023-01-26 18:28 ` Svyatoslav Ryhel 0 siblings, 2 replies; 18+ messages in thread From: Thierry Reding @ 2023-01-26 17:58 UTC (permalink / raw) To: Svyatoslav Ryhel Cc: Tom Warren, Rayagonda Kokatanur, Marek Vasut, Maxim Schwalm, Dmitry Osipenko, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung, u-boot@lists.denx.de [-- Attachment #1: Type: text/plain, Size: 7419 bytes --] On Thu, Jan 26, 2023 at 07:12:34PM +0200, Svyatoslav Ryhel wrote: > I may implement changes of Thierry Reding in a proper form as a > separate patch or include in existing (depends on his choice). I think it's ultimately better if this is properly integrated into the series because the series would remain bisectible. If the existing series is applied as-is, we have a few patches in the middle during which Tegra210 is unusable. So if we ever have to track down a regression that might be problematic. It's not a big deal since we've rarely had regressions in U-Boot. It's ultimately up to Tom to decide how he wants to handle this. If you send out another series, can you please add me on Cc so I don't miss it? Thanks, Thierry > The only thing I need to know is if ALL known T210 devices use > 19.2MHz as calibration clock for timer? > > Best regards. > Svyatoslav R. > > чт, 26 січ. 2023 р. о 18:50 Tom Warren <TWarren@nvidia.com> пише: > > > > Thanks for testing T210/T186, Thierry. > > > > I had Svyatoslav's patches ready to go for a PR yesterday, so I'll need either a patch from you for the T210 changes that I can apply on top of his, or I'll need Svyatoslav to adopt your changes as a 4th patch in his series. Once I have that and can pass buildman OK, I'll be ready to send a PR to TomR. > > > > Tom > > > > -----Original Message----- > > From: Thierry Reding <thierry.reding@gmail.com> > > Sent: Thursday, January 26, 2023 4:41 AM > > To: Svyatoslav Ryhel <clamor95@gmail.com> > > Cc: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>; Tom Warren <twarren@nvidia.com>; Marek Vasut <marex@denx.de>; Maxim Schwalm <maxim.schwalm@gmail.com>; Dmitry Osipenko <digetx@gmail.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>; Michal Simek <michal.simek@amd.com>; Stefan Roese <sr@denx.de>; Eugen Hristev <eugen.hristev@microchip.com>; Michael Walle <michael@walle.cc>; Simon Glass <sjg@chromium.org>; Jim Liu <jim.t90615@gmail.com>; William Zhang <william.zhang@broadcom.com>; Rick Chen <rick@andestech.com>; Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>; Andre Przywara <andre.przywara@arm.com>; Jaehoon Chung <jh80.chung@samsung.com>; u-boot@lists.denx.de > > Subject: Re: [PATCH v6 0/3] Timer support for ARM Tegra > > > > On Thu, Jan 26, 2023 at 11:34:59AM +0100, Thierry Reding wrote: > > > On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: > > > > On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: > > > > > - ARM: tegra: remap clock_osc_freq for all Tegra family Enum > > > > > clock_osc_freq was designed to use only with T20. > > > > > This patch remaps it to use additional frequencies, added in > > > > > T30+ SoC while maintaining backwards compatibility with T20. > > > > > > > > > > - drivers: timer: add timer driver for ARMv7 based Tegra devices > > > > > Add timer support for T20/T30/T114 and T124 based devices. > > > > > Driver is based on DM, has device tree support and can be used on > > > > > SPL and early boot stage. > > > > > > > > > > - ARM: tegra: include timer as default option Enable TIMER as > > > > > default option for all Tegra devices and enable TEGRA_TIMER for > > > > > TEGRA_ARMV7_COMMON. Additionally enable SPL_TIMER if build as SPL > > > > > part and drop deprecated configs from common header. > > > > > > > > > > P. S. I have no arm64 Tegra and according to comment in > > > > > tegra-common.h Use the Tegra US timer on ARMv7, but the > > > > > architected timer on ARMv8. > > > > > > > > > > Svyatoslav Ryhel (3): > > > > > ARM: tegra: remap clock_osc_freq for all Tegra family > > > > > drivers: timer: add timer driver for ARMv7 based Tegra devices > > > > > ARM: tegra: include timer as default option > > > > > > > > This causes a regression on Tegra210 (Jetson TX1). I'm trying to > > > > investigate, but it's complicated by the fact that I'm not getting > > > > out any debug prints, so I suspect the issue is happening quite early. > > > > > > Alright, I managed to make this work on Tegra210 using the following > > > patch on top of this series: > > > > > > --- >8 --- > > > diff --git a/arch/arm/dts/tegra210.dtsi b/arch/arm/dts/tegra210.dtsi > > > index a521a43d6cfd..ccb5a927da89 100644 > > > --- a/arch/arm/dts/tegra210.dtsi > > > +++ b/arch/arm/dts/tegra210.dtsi > > > @@ -318,7 +318,7 @@ > > > }; > > > > > > timer@60005000 { > > > - compatible = "nvidia,tegra210-timer", "nvidia,tegra20-timer"; > > > + compatible = "nvidia,tegra210-timer", "nvidia,tegra30-timer", > > > +"nvidia,tegra20-timer"; > > > reg = <0x0 0x60005000 0x0 0x400>; > > > interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, > > > <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, diff --git > > > a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig index > > > cc3f00e50128..b50eec5b8c9b 100644 > > > --- a/arch/arm/mach-tegra/Kconfig > > > +++ b/arch/arm/mach-tegra/Kconfig > > > @@ -136,6 +136,7 @@ config TEGRA210 > > > select TEGRA_PINCTRL > > > select TEGRA_PMC > > > select TEGRA_PMC_SECURE > > > + select TEGRA_TIMER > > > > > > config TEGRA186 > > > bool "Tegra186 family" > > > diff --git a/drivers/timer/tegra-timer.c b/drivers/timer/tegra-timer.c > > > index d2d163cf3fef..235532ba8926 100644 > > > --- a/drivers/timer/tegra-timer.c > > > +++ b/drivers/timer/tegra-timer.c > > > @@ -58,17 +58,26 @@ static notrace u64 tegra_timer_get_count(struct > > > udevice *dev) static int tegra_timer_probe(struct udevice *dev) { > > > struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); > > > + enum clock_osc_freq freq; > > > u32 usec_config, value; > > > > > > /* Timer rate has to be set unconditionally */ > > > uc_priv->clock_rate = TEGRA_TIMER_RATE; > > > > > > + /* > > > + * The microsecond timer runs off of clk_m on Tegra210, and clk_m > > > + * runs at half the OSC, so fake this up. > > > + */ > > > + freq = clock_get_osc_freq(); > > > + if (freq == CLOCK_OSC_FREQ_38_4) > > > + freq = CLOCK_OSC_FREQ_19_2; > > > + > > > /* > > > * Configure microsecond timers to have 1MHz clock > > > * Config register is 0xqqww, where qq is "dividend", ww is "divisor" > > > * Uses n+1 scheme > > > */ > > > - switch (clock_get_osc_freq()) { > > > + switch (freq) { > > > case CLOCK_OSC_FREQ_13_0: > > > usec_config = 0x000c; /* (12+1)/(0+1) */ > > > break; > > > @@ -113,6 +122,7 @@ static const struct udevice_id tegra_timer_ids[] = { > > > { .compatible = "nvidia,tegra30-timer" }, > > > { .compatible = "nvidia,tegra114-timer" }, > > > { .compatible = "nvidia,tegra124-timer" }, > > > + { .compatible = "nvidia,tegra210-timer" }, > > > { } > > > }; > > > --- >8 --- > > > > > > I've also tested this on Tegra186, though no additional changes were > > > needed since Tegra186 doesn't use the Tegra timer. > > > > > > With the above folded in, the series is: > > > > > > Tested-by: Thierry Reding <treding@nvidia.com> > > > > I've also tested your series with the above on Tegra30 (Beaver) and > > Tegra124 (Jetson TK1), both seem to work fine. > > > > Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 0/3] Timer support for ARM Tegra 2023-01-26 17:58 ` Thierry Reding @ 2023-01-26 18:10 ` Svyatoslav Ryhel 2023-01-26 22:12 ` Tom Warren 2023-01-26 18:28 ` Svyatoslav Ryhel 1 sibling, 1 reply; 18+ messages in thread From: Svyatoslav Ryhel @ 2023-01-26 18:10 UTC (permalink / raw) To: Thierry Reding Cc: Tom Warren, Rayagonda Kokatanur, Marek Vasut, Maxim Schwalm, Dmitry Osipenko, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung, u-boot@lists.denx.de чт, 26 січ. 2023 р. о 19:58 Thierry Reding <thierry.reding@gmail.com> пише: > > On Thu, Jan 26, 2023 at 07:12:34PM +0200, Svyatoslav Ryhel wrote: > > I may implement changes of Thierry Reding in a proper form as a > > separate patch or include in existing (depends on his choice). > > I think it's ultimately better if this is properly integrated into the > series because the series would remain bisectible. > > If the existing series is applied as-is, we have a few patches in the > middle during which Tegra210 is unusable. So if we ever have to track > down a regression that might be problematic. > > It's not a big deal since we've rarely had regressions in U-Boot. It's > ultimately up to Tom to decide how he wants to handle this. > > If you send out another series, can you please add me on Cc so I don't > miss it? > > Thanks, > Thierry Thierry Reding thanks for your clarification. If you and Tom Warren are ok, I will modify existing patches and send them as v7 in final form. Then you can check if T210 works as intended and if everything is correct. We can apply it. P. S. You may be sure that I will include you in all my patches for u-boot since it is explicitly hard to find a person with boards you own. Best Regards. Svyatoslav R. > > The only thing I need to know is if ALL known T210 devices use > > 19.2MHz as calibration clock for timer? > > > > Best regards. > > Svyatoslav R. > > > > чт, 26 січ. 2023 р. о 18:50 Tom Warren <TWarren@nvidia.com> пише: > > > > > > Thanks for testing T210/T186, Thierry. > > > > > > I had Svyatoslav's patches ready to go for a PR yesterday, so I'll need either a patch from you for the T210 changes that I can apply on top of his, or I'll need Svyatoslav to adopt your changes as a 4th patch in his series. Once I have that and can pass buildman OK, I'll be ready to send a PR to TomR. > > > > > > Tom > > > > > > -----Original Message----- > > > From: Thierry Reding <thierry.reding@gmail.com> > > > Sent: Thursday, January 26, 2023 4:41 AM > > > To: Svyatoslav Ryhel <clamor95@gmail.com> > > > Cc: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>; Tom Warren <twarren@nvidia.com>; Marek Vasut <marex@denx.de>; Maxim Schwalm <maxim.schwalm@gmail.com>; Dmitry Osipenko <digetx@gmail.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>; Michal Simek <michal.simek@amd.com>; Stefan Roese <sr@denx.de>; Eugen Hristev <eugen.hristev@microchip.com>; Michael Walle <michael@walle.cc>; Simon Glass <sjg@chromium.org>; Jim Liu <jim.t90615@gmail.com>; William Zhang <william.zhang@broadcom.com>; Rick Chen <rick@andestech.com>; Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>; Andre Przywara <andre.przywara@arm.com>; Jaehoon Chung <jh80.chung@samsung.com>; u-boot@lists.denx.de > > > Subject: Re: [PATCH v6 0/3] Timer support for ARM Tegra > > > > > > On Thu, Jan 26, 2023 at 11:34:59AM +0100, Thierry Reding wrote: > > > > On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: > > > > > On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: > > > > > > - ARM: tegra: remap clock_osc_freq for all Tegra family Enum > > > > > > clock_osc_freq was designed to use only with T20. > > > > > > This patch remaps it to use additional frequencies, added in > > > > > > T30+ SoC while maintaining backwards compatibility with T20. > > > > > > > > > > > > - drivers: timer: add timer driver for ARMv7 based Tegra devices > > > > > > Add timer support for T20/T30/T114 and T124 based devices. > > > > > > Driver is based on DM, has device tree support and can be used on > > > > > > SPL and early boot stage. > > > > > > > > > > > > - ARM: tegra: include timer as default option Enable TIMER as > > > > > > default option for all Tegra devices and enable TEGRA_TIMER for > > > > > > TEGRA_ARMV7_COMMON. Additionally enable SPL_TIMER if build as SPL > > > > > > part and drop deprecated configs from common header. > > > > > > > > > > > > P. S. I have no arm64 Tegra and according to comment in > > > > > > tegra-common.h Use the Tegra US timer on ARMv7, but the > > > > > > architected timer on ARMv8. > > > > > > > > > > > > Svyatoslav Ryhel (3): > > > > > > ARM: tegra: remap clock_osc_freq for all Tegra family > > > > > > drivers: timer: add timer driver for ARMv7 based Tegra devices > > > > > > ARM: tegra: include timer as default option > > > > > > > > > > This causes a regression on Tegra210 (Jetson TX1). I'm trying to > > > > > investigate, but it's complicated by the fact that I'm not getting > > > > > out any debug prints, so I suspect the issue is happening quite early. > > > > > > > > Alright, I managed to make this work on Tegra210 using the following > > > > patch on top of this series: > > > > > > > > --- >8 --- > > > > diff --git a/arch/arm/dts/tegra210.dtsi b/arch/arm/dts/tegra210.dtsi > > > > index a521a43d6cfd..ccb5a927da89 100644 > > > > --- a/arch/arm/dts/tegra210.dtsi > > > > +++ b/arch/arm/dts/tegra210.dtsi > > > > @@ -318,7 +318,7 @@ > > > > }; > > > > > > > > timer@60005000 { > > > > - compatible = "nvidia,tegra210-timer", "nvidia,tegra20-timer"; > > > > + compatible = "nvidia,tegra210-timer", "nvidia,tegra30-timer", > > > > +"nvidia,tegra20-timer"; > > > > reg = <0x0 0x60005000 0x0 0x400>; > > > > interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, > > > > <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, diff --git > > > > a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig index > > > > cc3f00e50128..b50eec5b8c9b 100644 > > > > --- a/arch/arm/mach-tegra/Kconfig > > > > +++ b/arch/arm/mach-tegra/Kconfig > > > > @@ -136,6 +136,7 @@ config TEGRA210 > > > > select TEGRA_PINCTRL > > > > select TEGRA_PMC > > > > select TEGRA_PMC_SECURE > > > > + select TEGRA_TIMER > > > > > > > > config TEGRA186 > > > > bool "Tegra186 family" > > > > diff --git a/drivers/timer/tegra-timer.c b/drivers/timer/tegra-timer.c > > > > index d2d163cf3fef..235532ba8926 100644 > > > > --- a/drivers/timer/tegra-timer.c > > > > +++ b/drivers/timer/tegra-timer.c > > > > @@ -58,17 +58,26 @@ static notrace u64 tegra_timer_get_count(struct > > > > udevice *dev) static int tegra_timer_probe(struct udevice *dev) { > > > > struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); > > > > + enum clock_osc_freq freq; > > > > u32 usec_config, value; > > > > > > > > /* Timer rate has to be set unconditionally */ > > > > uc_priv->clock_rate = TEGRA_TIMER_RATE; > > > > > > > > + /* > > > > + * The microsecond timer runs off of clk_m on Tegra210, and clk_m > > > > + * runs at half the OSC, so fake this up. > > > > + */ > > > > + freq = clock_get_osc_freq(); > > > > + if (freq == CLOCK_OSC_FREQ_38_4) > > > > + freq = CLOCK_OSC_FREQ_19_2; > > > > + > > > > /* > > > > * Configure microsecond timers to have 1MHz clock > > > > * Config register is 0xqqww, where qq is "dividend", ww is "divisor" > > > > * Uses n+1 scheme > > > > */ > > > > - switch (clock_get_osc_freq()) { > > > > + switch (freq) { > > > > case CLOCK_OSC_FREQ_13_0: > > > > usec_config = 0x000c; /* (12+1)/(0+1) */ > > > > break; > > > > @@ -113,6 +122,7 @@ static const struct udevice_id tegra_timer_ids[] = { > > > > { .compatible = "nvidia,tegra30-timer" }, > > > > { .compatible = "nvidia,tegra114-timer" }, > > > > { .compatible = "nvidia,tegra124-timer" }, > > > > + { .compatible = "nvidia,tegra210-timer" }, > > > > { } > > > > }; > > > > --- >8 --- > > > > > > > > I've also tested this on Tegra186, though no additional changes were > > > > needed since Tegra186 doesn't use the Tegra timer. > > > > > > > > With the above folded in, the series is: > > > > > > > > Tested-by: Thierry Reding <treding@nvidia.com> > > > > > > I've also tested your series with the above on Tegra30 (Beaver) and > > > Tegra124 (Jetson TK1), both seem to work fine. > > > > > > Thierry ^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH v6 0/3] Timer support for ARM Tegra 2023-01-26 18:10 ` Svyatoslav Ryhel @ 2023-01-26 22:12 ` Tom Warren 0 siblings, 0 replies; 18+ messages in thread From: Tom Warren @ 2023-01-26 22:12 UTC (permalink / raw) To: Svyatoslav Ryhel, Thierry Reding Cc: Rayagonda Kokatanur, Marek Vasut, Maxim Schwalm, Dmitry Osipenko, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung, u-boot@lists.denx.de Using your existing patches and generating a v7 to fix the T210 boards sounds like the right approach to me. Tom -----Original Message----- From: Svyatoslav Ryhel <clamor95@gmail.com> Sent: Thursday, January 26, 2023 11:11 AM To: Thierry Reding <thierry.reding@gmail.com> Cc: Tom Warren <TWarren@nvidia.com>; Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>; Marek Vasut <marex@denx.de>; Maxim Schwalm <maxim.schwalm@gmail.com>; Dmitry Osipenko <digetx@gmail.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>; Michal Simek <michal.simek@amd.com>; Stefan Roese <sr@denx.de>; Eugen Hristev <eugen.hristev@microchip.com>; Michael Walle <michael@walle.cc>; Simon Glass <sjg@chromium.org>; Jim Liu <jim.t90615@gmail.com>; William Zhang <william.zhang@broadcom.com>; Rick Chen <rick@andestech.com>; Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>; Andre Przywara <andre.przywara@arm.com>; Jaehoon Chung <jh80.chung@samsung.com>; u-boot@lists.denx.de Subject: Re: [PATCH v6 0/3] Timer support for ARM Tegra External email: Use caution opening links or attachments чт, 26 січ. 2023 р. о 19:58 Thierry Reding <thierry.reding@gmail.com> пише: > > On Thu, Jan 26, 2023 at 07:12:34PM +0200, Svyatoslav Ryhel wrote: > > I may implement changes of Thierry Reding in a proper form as a > > separate patch or include in existing (depends on his choice). > > I think it's ultimately better if this is properly integrated into the > series because the series would remain bisectible. > > If the existing series is applied as-is, we have a few patches in the > middle during which Tegra210 is unusable. So if we ever have to track > down a regression that might be problematic. > > It's not a big deal since we've rarely had regressions in U-Boot. It's > ultimately up to Tom to decide how he wants to handle this. > > If you send out another series, can you please add me on Cc so I don't > miss it? > > Thanks, > Thierry Thierry Reding thanks for your clarification. If you and Tom Warren are ok, I will modify existing patches and send them as v7 in final form. Then you can check if T210 works as intended and if everything is correct. We can apply it. P. S. You may be sure that I will include you in all my patches for u-boot since it is explicitly hard to find a person with boards you own. Best Regards. Svyatoslav R. > > The only thing I need to know is if ALL known T210 devices use > > 19.2MHz as calibration clock for timer? > > > > Best regards. > > Svyatoslav R. > > > > чт, 26 січ. 2023 р. о 18:50 Tom Warren <TWarren@nvidia.com> пише: > > > > > > Thanks for testing T210/T186, Thierry. > > > > > > I had Svyatoslav's patches ready to go for a PR yesterday, so I'll need either a patch from you for the T210 changes that I can apply on top of his, or I'll need Svyatoslav to adopt your changes as a 4th patch in his series. Once I have that and can pass buildman OK, I'll be ready to send a PR to TomR. > > > > > > Tom > > > > > > -----Original Message----- > > > From: Thierry Reding <thierry.reding@gmail.com> > > > Sent: Thursday, January 26, 2023 4:41 AM > > > To: Svyatoslav Ryhel <clamor95@gmail.com> > > > Cc: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>; Tom > > > Warren <twarren@nvidia.com>; Marek Vasut <marex@denx.de>; Maxim > > > Schwalm <maxim.schwalm@gmail.com>; Dmitry Osipenko > > > <digetx@gmail.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>; > > > Michal Simek <michal.simek@amd.com>; Stefan Roese <sr@denx.de>; > > > Eugen Hristev <eugen.hristev@microchip.com>; Michael Walle > > > <michael@walle.cc>; Simon Glass <sjg@chromium.org>; Jim Liu > > > <jim.t90615@gmail.com>; William Zhang > > > <william.zhang@broadcom.com>; Rick Chen <rick@andestech.com>; > > > Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>; > > > Andre Przywara <andre.przywara@arm.com>; Jaehoon Chung > > > <jh80.chung@samsung.com>; u-boot@lists.denx.de > > > Subject: Re: [PATCH v6 0/3] Timer support for ARM Tegra > > > > > > On Thu, Jan 26, 2023 at 11:34:59AM +0100, Thierry Reding wrote: > > > > On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: > > > > > On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: > > > > > > - ARM: tegra: remap clock_osc_freq for all Tegra family Enum > > > > > > clock_osc_freq was designed to use only with T20. > > > > > > This patch remaps it to use additional frequencies, added in > > > > > > T30+ SoC while maintaining backwards compatibility with T20. > > > > > > > > > > > > - drivers: timer: add timer driver for ARMv7 based Tegra > > > > > > devices Add timer support for T20/T30/T114 and T124 based devices. > > > > > > Driver is based on DM, has device tree support and can be > > > > > > used on SPL and early boot stage. > > > > > > > > > > > > - ARM: tegra: include timer as default option Enable TIMER > > > > > > as default option for all Tegra devices and enable > > > > > > TEGRA_TIMER for TEGRA_ARMV7_COMMON. Additionally enable > > > > > > SPL_TIMER if build as SPL part and drop deprecated configs from common header. > > > > > > > > > > > > P. S. I have no arm64 Tegra and according to comment in > > > > > > tegra-common.h Use the Tegra US timer on ARMv7, but the > > > > > > architected timer on ARMv8. > > > > > > > > > > > > Svyatoslav Ryhel (3): > > > > > > ARM: tegra: remap clock_osc_freq for all Tegra family > > > > > > drivers: timer: add timer driver for ARMv7 based Tegra devices > > > > > > ARM: tegra: include timer as default option > > > > > > > > > > This causes a regression on Tegra210 (Jetson TX1). I'm trying > > > > > to investigate, but it's complicated by the fact that I'm not > > > > > getting out any debug prints, so I suspect the issue is happening quite early. > > > > > > > > Alright, I managed to make this work on Tegra210 using the > > > > following patch on top of this series: > > > > > > > > --- >8 --- > > > > diff --git a/arch/arm/dts/tegra210.dtsi > > > > b/arch/arm/dts/tegra210.dtsi index a521a43d6cfd..ccb5a927da89 > > > > 100644 > > > > --- a/arch/arm/dts/tegra210.dtsi > > > > +++ b/arch/arm/dts/tegra210.dtsi > > > > @@ -318,7 +318,7 @@ > > > > }; > > > > > > > > timer@60005000 { > > > > - compatible = "nvidia,tegra210-timer", "nvidia,tegra20-timer"; > > > > + compatible = "nvidia,tegra210-timer", > > > > +"nvidia,tegra30-timer", "nvidia,tegra20-timer"; > > > > reg = <0x0 0x60005000 0x0 0x400>; > > > > interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, > > > > <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, diff > > > > --git a/arch/arm/mach-tegra/Kconfig > > > > b/arch/arm/mach-tegra/Kconfig index cc3f00e50128..b50eec5b8c9b > > > > 100644 > > > > --- a/arch/arm/mach-tegra/Kconfig > > > > +++ b/arch/arm/mach-tegra/Kconfig > > > > @@ -136,6 +136,7 @@ config TEGRA210 > > > > select TEGRA_PINCTRL > > > > select TEGRA_PMC > > > > select TEGRA_PMC_SECURE > > > > + select TEGRA_TIMER > > > > > > > > config TEGRA186 > > > > bool "Tegra186 family" > > > > diff --git a/drivers/timer/tegra-timer.c > > > > b/drivers/timer/tegra-timer.c index d2d163cf3fef..235532ba8926 > > > > 100644 > > > > --- a/drivers/timer/tegra-timer.c > > > > +++ b/drivers/timer/tegra-timer.c > > > > @@ -58,17 +58,26 @@ static notrace u64 > > > > tegra_timer_get_count(struct udevice *dev) static int tegra_timer_probe(struct udevice *dev) { > > > > struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); > > > > + enum clock_osc_freq freq; > > > > u32 usec_config, value; > > > > > > > > /* Timer rate has to be set unconditionally */ > > > > uc_priv->clock_rate = TEGRA_TIMER_RATE; > > > > > > > > + /* > > > > + * The microsecond timer runs off of clk_m on Tegra210, and clk_m > > > > + * runs at half the OSC, so fake this up. > > > > + */ > > > > + freq = clock_get_osc_freq(); > > > > + if (freq == CLOCK_OSC_FREQ_38_4) > > > > + freq = CLOCK_OSC_FREQ_19_2; > > > > + > > > > /* > > > > * Configure microsecond timers to have 1MHz clock > > > > * Config register is 0xqqww, where qq is "dividend", ww is "divisor" > > > > * Uses n+1 scheme > > > > */ > > > > - switch (clock_get_osc_freq()) { > > > > + switch (freq) { > > > > case CLOCK_OSC_FREQ_13_0: > > > > usec_config = 0x000c; /* (12+1)/(0+1) */ > > > > break; > > > > @@ -113,6 +122,7 @@ static const struct udevice_id tegra_timer_ids[] = { > > > > { .compatible = "nvidia,tegra30-timer" }, > > > > { .compatible = "nvidia,tegra114-timer" }, > > > > { .compatible = "nvidia,tegra124-timer" }, > > > > + { .compatible = "nvidia,tegra210-timer" }, > > > > { } > > > > }; > > > > --- >8 --- > > > > > > > > I've also tested this on Tegra186, though no additional changes > > > > were needed since Tegra186 doesn't use the Tegra timer. > > > > > > > > With the above folded in, the series is: > > > > > > > > Tested-by: Thierry Reding <treding@nvidia.com> > > > > > > I've also tested your series with the above on Tegra30 (Beaver) > > > and > > > Tegra124 (Jetson TK1), both seem to work fine. > > > > > > Thierry ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 0/3] Timer support for ARM Tegra 2023-01-26 17:58 ` Thierry Reding 2023-01-26 18:10 ` Svyatoslav Ryhel @ 2023-01-26 18:28 ` Svyatoslav Ryhel 1 sibling, 0 replies; 18+ messages in thread From: Svyatoslav Ryhel @ 2023-01-26 18:28 UTC (permalink / raw) To: Thierry Reding Cc: Tom Warren, Rayagonda Kokatanur, Marek Vasut, Maxim Schwalm, Dmitry Osipenko, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung, u-boot@lists.denx.de I propose this solution, based on Thierry idea. diff --git a/drivers/timer/tegra-timer.c b/drivers/timer/tegra-timer.c index d2d163cf3fef..86abc0e8fa54 100644 --- a/drivers/timer/tegra-timer.c +++ b/drivers/timer/tegra-timer.c @@ -94,6 +94,15 @@ static int tegra_timer_probe(struct udevice *dev) return -EINVAL; } + /* + * T210 TIMERUS is calibrated using clk_m which is + * div2 of osc clock. All known T210 boards use + * 38.4 MHz osc clock which means clk_m should be + * 19.2 MHz, hence correct usec_config is applied. + */ + if (IS_ENABLED(CONFIG_TEGRA210)) + usec_config = 0x045f; /* (95+1)/(4+1) */ + /* Enable clock to timer hardware */ value = readl_relaxed(TEGRA_OSC_CLK_ENB_L_SET); writel_relaxed(value | TEGRA_OSC_SET_CLK_ENB_TMR, @@ -113,6 +122,7 @@ static const struct udevice_id tegra_timer_ids[] = { { .compatible = "nvidia,tegra30-timer" }, { .compatible = "nvidia,tegra114-timer" }, { .compatible = "nvidia,tegra124-timer" }, + { .compatible = "nvidia,tegra210-timer" }, { } }; In case if T210 board with non 38.4MHz exists we can get back to this for proper and exact fix. Best Regards. Svyatoslav R. чт, 26 січ. 2023 р. о 19:58 Thierry Reding <thierry.reding@gmail.com> пише: > > On Thu, Jan 26, 2023 at 07:12:34PM +0200, Svyatoslav Ryhel wrote: > > I may implement changes of Thierry Reding in a proper form as a > > separate patch or include in existing (depends on his choice). > > I think it's ultimately better if this is properly integrated into the > series because the series would remain bisectible. > > If the existing series is applied as-is, we have a few patches in the > middle during which Tegra210 is unusable. So if we ever have to track > down a regression that might be problematic. > > It's not a big deal since we've rarely had regressions in U-Boot. It's > ultimately up to Tom to decide how he wants to handle this. > > If you send out another series, can you please add me on Cc so I don't > miss it? > > Thanks, > Thierry > > > The only thing I need to know is if ALL known T210 devices use > > 19.2MHz as calibration clock for timer? > > > > Best regards. > > Svyatoslav R. > > > > чт, 26 січ. 2023 р. о 18:50 Tom Warren <TWarren@nvidia.com> пише: > > > > > > Thanks for testing T210/T186, Thierry. > > > > > > I had Svyatoslav's patches ready to go for a PR yesterday, so I'll need either a patch from you for the T210 changes that I can apply on top of his, or I'll need Svyatoslav to adopt your changes as a 4th patch in his series. Once I have that and can pass buildman OK, I'll be ready to send a PR to TomR. > > > > > > Tom > > > > > > -----Original Message----- > > > From: Thierry Reding <thierry.reding@gmail.com> > > > Sent: Thursday, January 26, 2023 4:41 AM > > > To: Svyatoslav Ryhel <clamor95@gmail.com> > > > Cc: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>; Tom Warren <twarren@nvidia.com>; Marek Vasut <marex@denx.de>; Maxim Schwalm <maxim.schwalm@gmail.com>; Dmitry Osipenko <digetx@gmail.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>; Michal Simek <michal.simek@amd.com>; Stefan Roese <sr@denx.de>; Eugen Hristev <eugen.hristev@microchip.com>; Michael Walle <michael@walle.cc>; Simon Glass <sjg@chromium.org>; Jim Liu <jim.t90615@gmail.com>; William Zhang <william.zhang@broadcom.com>; Rick Chen <rick@andestech.com>; Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>; Andre Przywara <andre.przywara@arm.com>; Jaehoon Chung <jh80.chung@samsung.com>; u-boot@lists.denx.de > > > Subject: Re: [PATCH v6 0/3] Timer support for ARM Tegra > > > > > > On Thu, Jan 26, 2023 at 11:34:59AM +0100, Thierry Reding wrote: > > > > On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: > > > > > On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: > > > > > > - ARM: tegra: remap clock_osc_freq for all Tegra family Enum > > > > > > clock_osc_freq was designed to use only with T20. > > > > > > This patch remaps it to use additional frequencies, added in > > > > > > T30+ SoC while maintaining backwards compatibility with T20. > > > > > > > > > > > > - drivers: timer: add timer driver for ARMv7 based Tegra devices > > > > > > Add timer support for T20/T30/T114 and T124 based devices. > > > > > > Driver is based on DM, has device tree support and can be used on > > > > > > SPL and early boot stage. > > > > > > > > > > > > - ARM: tegra: include timer as default option Enable TIMER as > > > > > > default option for all Tegra devices and enable TEGRA_TIMER for > > > > > > TEGRA_ARMV7_COMMON. Additionally enable SPL_TIMER if build as SPL > > > > > > part and drop deprecated configs from common header. > > > > > > > > > > > > P. S. I have no arm64 Tegra and according to comment in > > > > > > tegra-common.h Use the Tegra US timer on ARMv7, but the > > > > > > architected timer on ARMv8. > > > > > > > > > > > > Svyatoslav Ryhel (3): > > > > > > ARM: tegra: remap clock_osc_freq for all Tegra family > > > > > > drivers: timer: add timer driver for ARMv7 based Tegra devices > > > > > > ARM: tegra: include timer as default option > > > > > > > > > > This causes a regression on Tegra210 (Jetson TX1). I'm trying to > > > > > investigate, but it's complicated by the fact that I'm not getting > > > > > out any debug prints, so I suspect the issue is happening quite early. > > > > > > > > Alright, I managed to make this work on Tegra210 using the following > > > > patch on top of this series: > > > > > > > > --- >8 --- > > > > diff --git a/arch/arm/dts/tegra210.dtsi b/arch/arm/dts/tegra210.dtsi > > > > index a521a43d6cfd..ccb5a927da89 100644 > > > > --- a/arch/arm/dts/tegra210.dtsi > > > > +++ b/arch/arm/dts/tegra210.dtsi > > > > @@ -318,7 +318,7 @@ > > > > }; > > > > > > > > timer@60005000 { > > > > - compatible = "nvidia,tegra210-timer", "nvidia,tegra20-timer"; > > > > + compatible = "nvidia,tegra210-timer", "nvidia,tegra30-timer", > > > > +"nvidia,tegra20-timer"; > > > > reg = <0x0 0x60005000 0x0 0x400>; > > > > interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, > > > > <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, diff --git > > > > a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig index > > > > cc3f00e50128..b50eec5b8c9b 100644 > > > > --- a/arch/arm/mach-tegra/Kconfig > > > > +++ b/arch/arm/mach-tegra/Kconfig > > > > @@ -136,6 +136,7 @@ config TEGRA210 > > > > select TEGRA_PINCTRL > > > > select TEGRA_PMC > > > > select TEGRA_PMC_SECURE > > > > + select TEGRA_TIMER > > > > > > > > config TEGRA186 > > > > bool "Tegra186 family" > > > > diff --git a/drivers/timer/tegra-timer.c b/drivers/timer/tegra-timer.c > > > > index d2d163cf3fef..235532ba8926 100644 > > > > --- a/drivers/timer/tegra-timer.c > > > > +++ b/drivers/timer/tegra-timer.c > > > > @@ -58,17 +58,26 @@ static notrace u64 tegra_timer_get_count(struct > > > > udevice *dev) static int tegra_timer_probe(struct udevice *dev) { > > > > struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); > > > > + enum clock_osc_freq freq; > > > > u32 usec_config, value; > > > > > > > > /* Timer rate has to be set unconditionally */ > > > > uc_priv->clock_rate = TEGRA_TIMER_RATE; > > > > > > > > + /* > > > > + * The microsecond timer runs off of clk_m on Tegra210, and clk_m > > > > + * runs at half the OSC, so fake this up. > > > > + */ > > > > + freq = clock_get_osc_freq(); > > > > + if (freq == CLOCK_OSC_FREQ_38_4) > > > > + freq = CLOCK_OSC_FREQ_19_2; > > > > + > > > > /* > > > > * Configure microsecond timers to have 1MHz clock > > > > * Config register is 0xqqww, where qq is "dividend", ww is "divisor" > > > > * Uses n+1 scheme > > > > */ > > > > - switch (clock_get_osc_freq()) { > > > > + switch (freq) { > > > > case CLOCK_OSC_FREQ_13_0: > > > > usec_config = 0x000c; /* (12+1)/(0+1) */ > > > > break; > > > > @@ -113,6 +122,7 @@ static const struct udevice_id tegra_timer_ids[] = { > > > > { .compatible = "nvidia,tegra30-timer" }, > > > > { .compatible = "nvidia,tegra114-timer" }, > > > > { .compatible = "nvidia,tegra124-timer" }, > > > > + { .compatible = "nvidia,tegra210-timer" }, > > > > { } > > > > }; > > > > --- >8 --- > > > > > > > > I've also tested this on Tegra186, though no additional changes were > > > > needed since Tegra186 doesn't use the Tegra timer. > > > > > > > > With the above folded in, the series is: > > > > > > > > Tested-by: Thierry Reding <treding@nvidia.com> > > > > > > I've also tested your series with the above on Tegra30 (Beaver) and > > > Tegra124 (Jetson TK1), both seem to work fine. > > > > > > Thierry ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v6 0/3] Timer support for ARM Tegra 2023-01-26 10:34 ` Thierry Reding 2023-01-26 11:40 ` Thierry Reding @ 2023-01-26 17:08 ` Svyatoslav Ryhel 2023-01-26 17:54 ` Thierry Reding 1 sibling, 1 reply; 18+ messages in thread From: Svyatoslav Ryhel @ 2023-01-26 17:08 UTC (permalink / raw) To: Thierry Reding Cc: Rayagonda Kokatanur, Tom Warren, Marek Vasut, Maxim Schwalm, Dmitry Osipenko, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung, u-boot чт, 26 січ. 2023 р. о 12:35 Thierry Reding <thierry.reding@gmail.com> пише: > > On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: > > On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: > > > - ARM: tegra: remap clock_osc_freq for all Tegra family > > > Enum clock_osc_freq was designed to use only with T20. > > > This patch remaps it to use additional frequencies, added in > > > T30+ SoC while maintaining backwards compatibility with T20. > > > > > > - drivers: timer: add timer driver for ARMv7 based Tegra devices > > > Add timer support for T20/T30/T114 and T124 based devices. > > > Driver is based on DM, has device tree support and can be > > > used on SPL and early boot stage. > > > > > > - ARM: tegra: include timer as default option > > > Enable TIMER as default option for all Tegra devices and > > > enable TEGRA_TIMER for TEGRA_ARMV7_COMMON. Additionally > > > enable SPL_TIMER if build as SPL part and drop deprecated > > > configs from common header. > > > > > > P. S. I have no arm64 Tegra and according to comment in > > > tegra-common.h > > > Use the Tegra US timer on ARMv7, but the architected timer on ARMv8. > > > > > > Svyatoslav Ryhel (3): > > > ARM: tegra: remap clock_osc_freq for all Tegra family > > > drivers: timer: add timer driver for ARMv7 based Tegra devices > > > ARM: tegra: include timer as default option > > > > This causes a regression on Tegra210 (Jetson TX1). I'm trying to > > investigate, but it's complicated by the fact that I'm not getting out > > any debug prints, so I suspect the issue is happening quite early. > > Alright, I managed to make this work on Tegra210 using the following > patch on top of this series: > Hello! Thanks for testing this on T210 SoC. > --- >8 --- > diff --git a/arch/arm/dts/tegra210.dtsi b/arch/arm/dts/tegra210.dtsi > index a521a43d6cfd..ccb5a927da89 100644 > --- a/arch/arm/dts/tegra210.dtsi > +++ b/arch/arm/dts/tegra210.dtsi > @@ -318,7 +318,7 @@ > }; > > timer@60005000 { > - compatible = "nvidia,tegra210-timer", "nvidia,tegra20-timer"; > + compatible = "nvidia,tegra210-timer", "nvidia,tegra30-timer", "nvidia,tegra20-timer"; This compatibe should not be needed since the driver will have t210 compatible included. > reg = <0x0 0x60005000 0x0 0x400>; > interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, > diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig > index cc3f00e50128..b50eec5b8c9b 100644 > --- a/arch/arm/mach-tegra/Kconfig > +++ b/arch/arm/mach-tegra/Kconfig > @@ -136,6 +136,7 @@ config TEGRA210 > select TEGRA_PINCTRL > select TEGRA_PMC > select TEGRA_PMC_SECURE > + select TEGRA_TIMER > > config TEGRA186 > bool "Tegra186 family" > diff --git a/drivers/timer/tegra-timer.c b/drivers/timer/tegra-timer.c > index d2d163cf3fef..235532ba8926 100644 > --- a/drivers/timer/tegra-timer.c > +++ b/drivers/timer/tegra-timer.c > @@ -58,17 +58,26 @@ static notrace u64 tegra_timer_get_count(struct udevice *dev) > static int tegra_timer_probe(struct udevice *dev) > { > struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); > + enum clock_osc_freq freq; > u32 usec_config, value; > > /* Timer rate has to be set unconditionally */ > uc_priv->clock_rate = TEGRA_TIMER_RATE; > > + /* > + * The microsecond timer runs off of clk_m on Tegra210, and clk_m > + * runs at half the OSC, so fake this up. > + */ > + freq = clock_get_osc_freq(); > + if (freq == CLOCK_OSC_FREQ_38_4) > + freq = CLOCK_OSC_FREQ_19_2; > + May you confirm that ALL known T210 devices use 19.2MHz as calibration clock for timer? If yes I can set this change in simpler as a separate commit or including into existing patches. > /* > * Configure microsecond timers to have 1MHz clock > * Config register is 0xqqww, where qq is "dividend", ww is "divisor" > * Uses n+1 scheme > */ > - switch (clock_get_osc_freq()) { > + switch (freq) { > case CLOCK_OSC_FREQ_13_0: > usec_config = 0x000c; /* (12+1)/(0+1) */ > break; > @@ -113,6 +122,7 @@ static const struct udevice_id tegra_timer_ids[] = { > { .compatible = "nvidia,tegra30-timer" }, > { .compatible = "nvidia,tegra114-timer" }, > { .compatible = "nvidia,tegra124-timer" }, > + { .compatible = "nvidia,tegra210-timer" }, > { } > }; > --- >8 --- > > I've also tested this on Tegra186, though no additional changes were > needed since Tegra186 doesn't use the Tegra timer. > > With the above folded in, the series is: > > Tested-by: Thierry Reding <treding@nvidia.com> ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 0/3] Timer support for ARM Tegra 2023-01-26 17:08 ` Svyatoslav Ryhel @ 2023-01-26 17:54 ` Thierry Reding 2023-01-26 22:00 ` Dmitry Osipenko 0 siblings, 1 reply; 18+ messages in thread From: Thierry Reding @ 2023-01-26 17:54 UTC (permalink / raw) To: Svyatoslav Ryhel Cc: Rayagonda Kokatanur, Tom Warren, Marek Vasut, Maxim Schwalm, Dmitry Osipenko, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung, u-boot [-- Attachment #1: Type: text/plain, Size: 7143 bytes --] On Thu, Jan 26, 2023 at 07:08:54PM +0200, Svyatoslav Ryhel wrote: > чт, 26 січ. 2023 р. о 12:35 Thierry Reding <thierry.reding@gmail.com> пише: > > > > On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: > > > On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: > > > > - ARM: tegra: remap clock_osc_freq for all Tegra family > > > > Enum clock_osc_freq was designed to use only with T20. > > > > This patch remaps it to use additional frequencies, added in > > > > T30+ SoC while maintaining backwards compatibility with T20. > > > > > > > > - drivers: timer: add timer driver for ARMv7 based Tegra devices > > > > Add timer support for T20/T30/T114 and T124 based devices. > > > > Driver is based on DM, has device tree support and can be > > > > used on SPL and early boot stage. > > > > > > > > - ARM: tegra: include timer as default option > > > > Enable TIMER as default option for all Tegra devices and > > > > enable TEGRA_TIMER for TEGRA_ARMV7_COMMON. Additionally > > > > enable SPL_TIMER if build as SPL part and drop deprecated > > > > configs from common header. > > > > > > > > P. S. I have no arm64 Tegra and according to comment in > > > > tegra-common.h > > > > Use the Tegra US timer on ARMv7, but the architected timer on ARMv8. > > > > > > > > Svyatoslav Ryhel (3): > > > > ARM: tegra: remap clock_osc_freq for all Tegra family > > > > drivers: timer: add timer driver for ARMv7 based Tegra devices > > > > ARM: tegra: include timer as default option > > > > > > This causes a regression on Tegra210 (Jetson TX1). I'm trying to > > > investigate, but it's complicated by the fact that I'm not getting out > > > any debug prints, so I suspect the issue is happening quite early. > > > > Alright, I managed to make this work on Tegra210 using the following > > patch on top of this series: > > > > Hello! Thanks for testing this on T210 SoC. > > > --- >8 --- > > diff --git a/arch/arm/dts/tegra210.dtsi b/arch/arm/dts/tegra210.dtsi > > index a521a43d6cfd..ccb5a927da89 100644 > > --- a/arch/arm/dts/tegra210.dtsi > > +++ b/arch/arm/dts/tegra210.dtsi > > @@ -318,7 +318,7 @@ > > }; > > > > timer@60005000 { > > - compatible = "nvidia,tegra210-timer", "nvidia,tegra20-timer"; > > + compatible = "nvidia,tegra210-timer", "nvidia,tegra30-timer", "nvidia,tegra20-timer"; > > This compatibe should not be needed since the driver will have t210 > compatible included. Yes, it should be fine to leave this as-is. I had included this before updating the driver, to get the driver to bind to this. Upstream Linux doesn't include "nvidia,tegra20-timer", so it only has the compatible string for Tegra210. I think that's slightly better because the register interface isn't quite compatible. That's a separate issue and we can do that in a follow-up patch. > > > reg = <0x0 0x60005000 0x0 0x400>; > > interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, > > <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, > > diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig > > index cc3f00e50128..b50eec5b8c9b 100644 > > --- a/arch/arm/mach-tegra/Kconfig > > +++ b/arch/arm/mach-tegra/Kconfig > > @@ -136,6 +136,7 @@ config TEGRA210 > > select TEGRA_PINCTRL > > select TEGRA_PMC > > select TEGRA_PMC_SECURE > > + select TEGRA_TIMER > > > > config TEGRA186 > > bool "Tegra186 family" > > diff --git a/drivers/timer/tegra-timer.c b/drivers/timer/tegra-timer.c > > index d2d163cf3fef..235532ba8926 100644 > > --- a/drivers/timer/tegra-timer.c > > +++ b/drivers/timer/tegra-timer.c > > @@ -58,17 +58,26 @@ static notrace u64 tegra_timer_get_count(struct udevice *dev) > > static int tegra_timer_probe(struct udevice *dev) > > { > > struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); > > + enum clock_osc_freq freq; > > u32 usec_config, value; > > > > /* Timer rate has to be set unconditionally */ > > uc_priv->clock_rate = TEGRA_TIMER_RATE; > > > > + /* > > + * The microsecond timer runs off of clk_m on Tegra210, and clk_m > > + * runs at half the OSC, so fake this up. > > + */ > > + freq = clock_get_osc_freq(); > > + if (freq == CLOCK_OSC_FREQ_38_4) > > + freq = CLOCK_OSC_FREQ_19_2; > > + > > May you confirm that ALL known T210 devices use 19.2MHz as calibration > clock for timer? According to the Tegra210 TRM, the TIMERUS depends on the rate of clk_m and clk_m is derived from OSC and either divided by 1, 2, 3 or 4. The TRM goes on to say that: The expectation is that this CLK_M_DIVISOR will only be changed once after powering VDD_SOC on in cold boot/LP0 exit path. So these sequences are verified with an oscillator clock of 38.4 MHz; div2 setting of the CLK_M divisor must be used. The result is 19.2 MHz clk_m. And then it says: Note: Div2 is the recommended clk_m divisor value. Do not use any other value. This is from Section 5.1.2 "Clk_m Divisor" of the Tegra210 TRM. > If yes I can set this change in simpler as a separate commit or > including into existing patches. Anything you have in mind? I tried a couple of variations to the above and they all failed because in other places it's important that OSC is recognized as running at 38.4 MHz. If not, then other PLLs will not work properly and even basic things like the debug UART won't work. Technically the right thing to do would be to base the USEC config off the clk_m rate. We didn't do that back at the time, IIRC, because most of the clock infrastructure didn't exist, but it might be possible to achieve this today. I kept the above because it is still a bit simpler and as the TRM suggests nobody should be using anything other than the div2 setting for clk_m. I'm certainly not aware of any devices that do something different. And U-Boot has always had this assumption as well, so I think it's safe to use. Thierry > > /* > > * Configure microsecond timers to have 1MHz clock > > * Config register is 0xqqww, where qq is "dividend", ww is "divisor" > > * Uses n+1 scheme > > */ > > - switch (clock_get_osc_freq()) { > > + switch (freq) { > > case CLOCK_OSC_FREQ_13_0: > > usec_config = 0x000c; /* (12+1)/(0+1) */ > > break; > > @@ -113,6 +122,7 @@ static const struct udevice_id tegra_timer_ids[] = { > > { .compatible = "nvidia,tegra30-timer" }, > > { .compatible = "nvidia,tegra114-timer" }, > > { .compatible = "nvidia,tegra124-timer" }, > > + { .compatible = "nvidia,tegra210-timer" }, > > { } > > }; > > --- >8 --- > > > > I've also tested this on Tegra186, though no additional changes were > > needed since Tegra186 doesn't use the Tegra timer. > > > > With the above folded in, the series is: > > > > Tested-by: Thierry Reding <treding@nvidia.com> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 0/3] Timer support for ARM Tegra 2023-01-26 17:54 ` Thierry Reding @ 2023-01-26 22:00 ` Dmitry Osipenko 2023-01-26 22:12 ` Dmitry Osipenko 0 siblings, 1 reply; 18+ messages in thread From: Dmitry Osipenko @ 2023-01-26 22:00 UTC (permalink / raw) To: Thierry Reding, Svyatoslav Ryhel Cc: Rayagonda Kokatanur, Tom Warren, Marek Vasut, Maxim Schwalm, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung, u-boot 26.01.2023 20:54, Thierry Reding пишет: > On Thu, Jan 26, 2023 at 07:08:54PM +0200, Svyatoslav Ryhel wrote: >> чт, 26 січ. 2023 р. о 12:35 Thierry Reding <thierry.reding@gmail.com> пише: >>> >>> On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: >>>> On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: >>>>> - ARM: tegra: remap clock_osc_freq for all Tegra family >>>>> Enum clock_osc_freq was designed to use only with T20. >>>>> This patch remaps it to use additional frequencies, added in >>>>> T30+ SoC while maintaining backwards compatibility with T20. >>>>> >>>>> - drivers: timer: add timer driver for ARMv7 based Tegra devices >>>>> Add timer support for T20/T30/T114 and T124 based devices. >>>>> Driver is based on DM, has device tree support and can be >>>>> used on SPL and early boot stage. >>>>> >>>>> - ARM: tegra: include timer as default option >>>>> Enable TIMER as default option for all Tegra devices and >>>>> enable TEGRA_TIMER for TEGRA_ARMV7_COMMON. Additionally >>>>> enable SPL_TIMER if build as SPL part and drop deprecated >>>>> configs from common header. >>>>> >>>>> P. S. I have no arm64 Tegra and according to comment in >>>>> tegra-common.h >>>>> Use the Tegra US timer on ARMv7, but the architected timer on ARMv8. >>>>> >>>>> Svyatoslav Ryhel (3): >>>>> ARM: tegra: remap clock_osc_freq for all Tegra family >>>>> drivers: timer: add timer driver for ARMv7 based Tegra devices >>>>> ARM: tegra: include timer as default option >>>> >>>> This causes a regression on Tegra210 (Jetson TX1). I'm trying to >>>> investigate, but it's complicated by the fact that I'm not getting out >>>> any debug prints, so I suspect the issue is happening quite early. >>> >>> Alright, I managed to make this work on Tegra210 using the following >>> patch on top of this series: >>> >> >> Hello! Thanks for testing this on T210 SoC. >> >>> --- >8 --- >>> diff --git a/arch/arm/dts/tegra210.dtsi b/arch/arm/dts/tegra210.dtsi >>> index a521a43d6cfd..ccb5a927da89 100644 >>> --- a/arch/arm/dts/tegra210.dtsi >>> +++ b/arch/arm/dts/tegra210.dtsi >>> @@ -318,7 +318,7 @@ >>> }; >>> >>> timer@60005000 { >>> - compatible = "nvidia,tegra210-timer", "nvidia,tegra20-timer"; >>> + compatible = "nvidia,tegra210-timer", "nvidia,tegra30-timer", "nvidia,tegra20-timer"; >> >> This compatibe should not be needed since the driver will have t210 >> compatible included. > > Yes, it should be fine to leave this as-is. I had included this before > updating the driver, to get the driver to bind to this. Upstream Linux > doesn't include "nvidia,tegra20-timer", so it only has the compatible > string for Tegra210. I think that's slightly better because the register > interface isn't quite compatible. That's a separate issue and we can do > that in a follow-up patch. > >> >>> reg = <0x0 0x60005000 0x0 0x400>; >>> interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, >>> <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, >>> diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig >>> index cc3f00e50128..b50eec5b8c9b 100644 >>> --- a/arch/arm/mach-tegra/Kconfig >>> +++ b/arch/arm/mach-tegra/Kconfig >>> @@ -136,6 +136,7 @@ config TEGRA210 >>> select TEGRA_PINCTRL >>> select TEGRA_PMC >>> select TEGRA_PMC_SECURE >>> + select TEGRA_TIMER >>> >>> config TEGRA186 >>> bool "Tegra186 family" >>> diff --git a/drivers/timer/tegra-timer.c b/drivers/timer/tegra-timer.c >>> index d2d163cf3fef..235532ba8926 100644 >>> --- a/drivers/timer/tegra-timer.c >>> +++ b/drivers/timer/tegra-timer.c >>> @@ -58,17 +58,26 @@ static notrace u64 tegra_timer_get_count(struct udevice *dev) >>> static int tegra_timer_probe(struct udevice *dev) >>> { >>> struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); >>> + enum clock_osc_freq freq; >>> u32 usec_config, value; >>> >>> /* Timer rate has to be set unconditionally */ >>> uc_priv->clock_rate = TEGRA_TIMER_RATE; >>> >>> + /* >>> + * The microsecond timer runs off of clk_m on Tegra210, and clk_m >>> + * runs at half the OSC, so fake this up. >>> + */ >>> + freq = clock_get_osc_freq(); >>> + if (freq == CLOCK_OSC_FREQ_38_4) >>> + freq = CLOCK_OSC_FREQ_19_2; >>> + >> >> May you confirm that ALL known T210 devices use 19.2MHz as calibration >> clock for timer? > > According to the Tegra210 TRM, the TIMERUS depends on the rate of clk_m > and clk_m is derived from OSC and either divided by 1, 2, 3 or 4. The > TRM goes on to say that: > > The expectation is that this CLK_M_DIVISOR will only be changed > once after powering VDD_SOC on in cold boot/LP0 exit path. So > these sequences are verified with an oscillator clock of 38.4 > MHz; div2 setting of the CLK_M divisor must be used. The result > is 19.2 MHz clk_m. > > And then it says: > > Note: Div2 is the recommended clk_m divisor value. Do not use > any other value. > > This is from Section 5.1.2 "Clk_m Divisor" of the Tegra210 TRM. > >> If yes I can set this change in simpler as a separate commit or >> including into existing patches. > > Anything you have in mind? I tried a couple of variations to the above > and they all failed because in other places it's important that OSC is > recognized as running at 38.4 MHz. If not, then other PLLs will not > work properly and even basic things like the debug UART won't work. > > Technically the right thing to do would be to base the USEC config off > the clk_m rate. We didn't do that back at the time, IIRC, because most > of the clock infrastructure didn't exist, but it might be possible to > achieve this today. I kept the above because it is still a bit simpler > and as the TRM suggests nobody should be using anything other than the > div2 setting for clk_m. I'm certainly not aware of any devices that do > something different. And U-Boot has always had this assumption as well, > so I think it's safe to use. Am I understanding correctly that for T210 we can/should use clk_m_get_rate() instead of clock_get_osc_freq() in tegra_timer_probe()? Have you tested this option? ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 0/3] Timer support for ARM Tegra 2023-01-26 22:00 ` Dmitry Osipenko @ 2023-01-26 22:12 ` Dmitry Osipenko 2023-01-27 4:51 ` Svyatoslav Ryhel 0 siblings, 1 reply; 18+ messages in thread From: Dmitry Osipenko @ 2023-01-26 22:12 UTC (permalink / raw) To: Thierry Reding, Svyatoslav Ryhel Cc: Rayagonda Kokatanur, Tom Warren, Marek Vasut, Maxim Schwalm, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung, u-boot 27.01.2023 01:00, Dmitry Osipenko пишет: > 26.01.2023 20:54, Thierry Reding пишет: >> On Thu, Jan 26, 2023 at 07:08:54PM +0200, Svyatoslav Ryhel wrote: >>> чт, 26 січ. 2023 р. о 12:35 Thierry Reding <thierry.reding@gmail.com> пише: >>>> >>>> On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: >>>>> On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: >>>>>> - ARM: tegra: remap clock_osc_freq for all Tegra family >>>>>> Enum clock_osc_freq was designed to use only with T20. >>>>>> This patch remaps it to use additional frequencies, added in >>>>>> T30+ SoC while maintaining backwards compatibility with T20. >>>>>> >>>>>> - drivers: timer: add timer driver for ARMv7 based Tegra devices >>>>>> Add timer support for T20/T30/T114 and T124 based devices. >>>>>> Driver is based on DM, has device tree support and can be >>>>>> used on SPL and early boot stage. >>>>>> >>>>>> - ARM: tegra: include timer as default option >>>>>> Enable TIMER as default option for all Tegra devices and >>>>>> enable TEGRA_TIMER for TEGRA_ARMV7_COMMON. Additionally >>>>>> enable SPL_TIMER if build as SPL part and drop deprecated >>>>>> configs from common header. >>>>>> >>>>>> P. S. I have no arm64 Tegra and according to comment in >>>>>> tegra-common.h >>>>>> Use the Tegra US timer on ARMv7, but the architected timer on ARMv8. >>>>>> >>>>>> Svyatoslav Ryhel (3): >>>>>> ARM: tegra: remap clock_osc_freq for all Tegra family >>>>>> drivers: timer: add timer driver for ARMv7 based Tegra devices >>>>>> ARM: tegra: include timer as default option >>>>> >>>>> This causes a regression on Tegra210 (Jetson TX1). I'm trying to >>>>> investigate, but it's complicated by the fact that I'm not getting out >>>>> any debug prints, so I suspect the issue is happening quite early. >>>> >>>> Alright, I managed to make this work on Tegra210 using the following >>>> patch on top of this series: >>>> >>> >>> Hello! Thanks for testing this on T210 SoC. >>> >>>> --- >8 --- >>>> diff --git a/arch/arm/dts/tegra210.dtsi b/arch/arm/dts/tegra210.dtsi >>>> index a521a43d6cfd..ccb5a927da89 100644 >>>> --- a/arch/arm/dts/tegra210.dtsi >>>> +++ b/arch/arm/dts/tegra210.dtsi >>>> @@ -318,7 +318,7 @@ >>>> }; >>>> >>>> timer@60005000 { >>>> - compatible = "nvidia,tegra210-timer", "nvidia,tegra20-timer"; >>>> + compatible = "nvidia,tegra210-timer", "nvidia,tegra30-timer", "nvidia,tegra20-timer"; >>> >>> This compatibe should not be needed since the driver will have t210 >>> compatible included. >> >> Yes, it should be fine to leave this as-is. I had included this before >> updating the driver, to get the driver to bind to this. Upstream Linux >> doesn't include "nvidia,tegra20-timer", so it only has the compatible >> string for Tegra210. I think that's slightly better because the register >> interface isn't quite compatible. That's a separate issue and we can do >> that in a follow-up patch. >> >>> >>>> reg = <0x0 0x60005000 0x0 0x400>; >>>> interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, >>>> <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, >>>> diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig >>>> index cc3f00e50128..b50eec5b8c9b 100644 >>>> --- a/arch/arm/mach-tegra/Kconfig >>>> +++ b/arch/arm/mach-tegra/Kconfig >>>> @@ -136,6 +136,7 @@ config TEGRA210 >>>> select TEGRA_PINCTRL >>>> select TEGRA_PMC >>>> select TEGRA_PMC_SECURE >>>> + select TEGRA_TIMER >>>> >>>> config TEGRA186 >>>> bool "Tegra186 family" >>>> diff --git a/drivers/timer/tegra-timer.c b/drivers/timer/tegra-timer.c >>>> index d2d163cf3fef..235532ba8926 100644 >>>> --- a/drivers/timer/tegra-timer.c >>>> +++ b/drivers/timer/tegra-timer.c >>>> @@ -58,17 +58,26 @@ static notrace u64 tegra_timer_get_count(struct udevice *dev) >>>> static int tegra_timer_probe(struct udevice *dev) >>>> { >>>> struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); >>>> + enum clock_osc_freq freq; >>>> u32 usec_config, value; >>>> >>>> /* Timer rate has to be set unconditionally */ >>>> uc_priv->clock_rate = TEGRA_TIMER_RATE; >>>> >>>> + /* >>>> + * The microsecond timer runs off of clk_m on Tegra210, and clk_m >>>> + * runs at half the OSC, so fake this up. >>>> + */ >>>> + freq = clock_get_osc_freq(); >>>> + if (freq == CLOCK_OSC_FREQ_38_4) >>>> + freq = CLOCK_OSC_FREQ_19_2; >>>> + >>> >>> May you confirm that ALL known T210 devices use 19.2MHz as calibration >>> clock for timer? >> >> According to the Tegra210 TRM, the TIMERUS depends on the rate of clk_m >> and clk_m is derived from OSC and either divided by 1, 2, 3 or 4. The >> TRM goes on to say that: >> >> The expectation is that this CLK_M_DIVISOR will only be changed >> once after powering VDD_SOC on in cold boot/LP0 exit path. So >> these sequences are verified with an oscillator clock of 38.4 >> MHz; div2 setting of the CLK_M divisor must be used. The result >> is 19.2 MHz clk_m. >> >> And then it says: >> >> Note: Div2 is the recommended clk_m divisor value. Do not use >> any other value. >> >> This is from Section 5.1.2 "Clk_m Divisor" of the Tegra210 TRM. >> >>> If yes I can set this change in simpler as a separate commit or >>> including into existing patches. >> >> Anything you have in mind? I tried a couple of variations to the above >> and they all failed because in other places it's important that OSC is >> recognized as running at 38.4 MHz. If not, then other PLLs will not >> work properly and even basic things like the debug UART won't work. >> >> Technically the right thing to do would be to base the USEC config off >> the clk_m rate. We didn't do that back at the time, IIRC, because most >> of the clock infrastructure didn't exist, but it might be possible to >> achieve this today. I kept the above because it is still a bit simpler >> and as the TRM suggests nobody should be using anything other than the >> div2 setting for clk_m. I'm certainly not aware of any devices that do >> something different. And U-Boot has always had this assumption as well, >> so I think it's safe to use. > > Am I understanding correctly that for T210 we can/should use > clk_m_get_rate() instead of clock_get_osc_freq() in tegra_timer_probe()? > Have you tested this option? Although, looking at the kernel code, I see that clk_m is the parent clock for timer on all SoCs. Hence replacing clock_get_osc_freq() with clk_m_get_rate() should be the proper solution and then no T210-specific workarounds are needed. ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 0/3] Timer support for ARM Tegra 2023-01-26 22:12 ` Dmitry Osipenko @ 2023-01-27 4:51 ` Svyatoslav Ryhel 0 siblings, 0 replies; 18+ messages in thread From: Svyatoslav Ryhel @ 2023-01-27 4:51 UTC (permalink / raw) To: Dmitry Osipenko Cc: Thierry Reding, Rayagonda Kokatanur, Tom Warren, Marek Vasut, Maxim Schwalm, Heinrich Schuchardt, Michal Simek, Stefan Roese, Eugen Hristev, Michael Walle, Simon Glass, Jim Liu, William Zhang, Rick Chen, Stefan Herbrechtsmeier, Andre Przywara, Jaehoon Chung, u-boot Good point. U-Boot has instruments to get clk_m rate on time of timer probe. I need some time to prepare this modification for testing. пт, 27 січ. 2023 р. о 00:12 Dmitry Osipenko <digetx@gmail.com> пише: > > 27.01.2023 01:00, Dmitry Osipenko пишет: > > 26.01.2023 20:54, Thierry Reding пишет: > >> On Thu, Jan 26, 2023 at 07:08:54PM +0200, Svyatoslav Ryhel wrote: > >>> чт, 26 січ. 2023 р. о 12:35 Thierry Reding <thierry.reding@gmail.com> пише: > >>>> > >>>> On Wed, Jan 25, 2023 at 05:41:08PM +0100, Thierry Reding wrote: > >>>>> On Tue, Jan 24, 2023 at 08:57:48AM +0200, Svyatoslav Ryhel wrote: > >>>>>> - ARM: tegra: remap clock_osc_freq for all Tegra family > >>>>>> Enum clock_osc_freq was designed to use only with T20. > >>>>>> This patch remaps it to use additional frequencies, added in > >>>>>> T30+ SoC while maintaining backwards compatibility with T20. > >>>>>> > >>>>>> - drivers: timer: add timer driver for ARMv7 based Tegra devices > >>>>>> Add timer support for T20/T30/T114 and T124 based devices. > >>>>>> Driver is based on DM, has device tree support and can be > >>>>>> used on SPL and early boot stage. > >>>>>> > >>>>>> - ARM: tegra: include timer as default option > >>>>>> Enable TIMER as default option for all Tegra devices and > >>>>>> enable TEGRA_TIMER for TEGRA_ARMV7_COMMON. Additionally > >>>>>> enable SPL_TIMER if build as SPL part and drop deprecated > >>>>>> configs from common header. > >>>>>> > >>>>>> P. S. I have no arm64 Tegra and according to comment in > >>>>>> tegra-common.h > >>>>>> Use the Tegra US timer on ARMv7, but the architected timer on ARMv8. > >>>>>> > >>>>>> Svyatoslav Ryhel (3): > >>>>>> ARM: tegra: remap clock_osc_freq for all Tegra family > >>>>>> drivers: timer: add timer driver for ARMv7 based Tegra devices > >>>>>> ARM: tegra: include timer as default option > >>>>> > >>>>> This causes a regression on Tegra210 (Jetson TX1). I'm trying to > >>>>> investigate, but it's complicated by the fact that I'm not getting out > >>>>> any debug prints, so I suspect the issue is happening quite early. > >>>> > >>>> Alright, I managed to make this work on Tegra210 using the following > >>>> patch on top of this series: > >>>> > >>> > >>> Hello! Thanks for testing this on T210 SoC. > >>> > >>>> --- >8 --- > >>>> diff --git a/arch/arm/dts/tegra210.dtsi b/arch/arm/dts/tegra210.dtsi > >>>> index a521a43d6cfd..ccb5a927da89 100644 > >>>> --- a/arch/arm/dts/tegra210.dtsi > >>>> +++ b/arch/arm/dts/tegra210.dtsi > >>>> @@ -318,7 +318,7 @@ > >>>> }; > >>>> > >>>> timer@60005000 { > >>>> - compatible = "nvidia,tegra210-timer", "nvidia,tegra20-timer"; > >>>> + compatible = "nvidia,tegra210-timer", "nvidia,tegra30-timer", "nvidia,tegra20-timer"; > >>> > >>> This compatibe should not be needed since the driver will have t210 > >>> compatible included. > >> > >> Yes, it should be fine to leave this as-is. I had included this before > >> updating the driver, to get the driver to bind to this. Upstream Linux > >> doesn't include "nvidia,tegra20-timer", so it only has the compatible > >> string for Tegra210. I think that's slightly better because the register > >> interface isn't quite compatible. That's a separate issue and we can do > >> that in a follow-up patch. > >> > >>> > >>>> reg = <0x0 0x60005000 0x0 0x400>; > >>>> interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>, > >>>> <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>, > >>>> diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig > >>>> index cc3f00e50128..b50eec5b8c9b 100644 > >>>> --- a/arch/arm/mach-tegra/Kconfig > >>>> +++ b/arch/arm/mach-tegra/Kconfig > >>>> @@ -136,6 +136,7 @@ config TEGRA210 > >>>> select TEGRA_PINCTRL > >>>> select TEGRA_PMC > >>>> select TEGRA_PMC_SECURE > >>>> + select TEGRA_TIMER > >>>> > >>>> config TEGRA186 > >>>> bool "Tegra186 family" > >>>> diff --git a/drivers/timer/tegra-timer.c b/drivers/timer/tegra-timer.c > >>>> index d2d163cf3fef..235532ba8926 100644 > >>>> --- a/drivers/timer/tegra-timer.c > >>>> +++ b/drivers/timer/tegra-timer.c > >>>> @@ -58,17 +58,26 @@ static notrace u64 tegra_timer_get_count(struct udevice *dev) > >>>> static int tegra_timer_probe(struct udevice *dev) > >>>> { > >>>> struct timer_dev_priv *uc_priv = dev_get_uclass_priv(dev); > >>>> + enum clock_osc_freq freq; > >>>> u32 usec_config, value; > >>>> > >>>> /* Timer rate has to be set unconditionally */ > >>>> uc_priv->clock_rate = TEGRA_TIMER_RATE; > >>>> > >>>> + /* > >>>> + * The microsecond timer runs off of clk_m on Tegra210, and clk_m > >>>> + * runs at half the OSC, so fake this up. > >>>> + */ > >>>> + freq = clock_get_osc_freq(); > >>>> + if (freq == CLOCK_OSC_FREQ_38_4) > >>>> + freq = CLOCK_OSC_FREQ_19_2; > >>>> + > >>> > >>> May you confirm that ALL known T210 devices use 19.2MHz as calibration > >>> clock for timer? > >> > >> According to the Tegra210 TRM, the TIMERUS depends on the rate of clk_m > >> and clk_m is derived from OSC and either divided by 1, 2, 3 or 4. The > >> TRM goes on to say that: > >> > >> The expectation is that this CLK_M_DIVISOR will only be changed > >> once after powering VDD_SOC on in cold boot/LP0 exit path. So > >> these sequences are verified with an oscillator clock of 38.4 > >> MHz; div2 setting of the CLK_M divisor must be used. The result > >> is 19.2 MHz clk_m. > >> > >> And then it says: > >> > >> Note: Div2 is the recommended clk_m divisor value. Do not use > >> any other value. > >> > >> This is from Section 5.1.2 "Clk_m Divisor" of the Tegra210 TRM. > >> > >>> If yes I can set this change in simpler as a separate commit or > >>> including into existing patches. > >> > >> Anything you have in mind? I tried a couple of variations to the above > >> and they all failed because in other places it's important that OSC is > >> recognized as running at 38.4 MHz. If not, then other PLLs will not > >> work properly and even basic things like the debug UART won't work. > >> > >> Technically the right thing to do would be to base the USEC config off > >> the clk_m rate. We didn't do that back at the time, IIRC, because most > >> of the clock infrastructure didn't exist, but it might be possible to > >> achieve this today. I kept the above because it is still a bit simpler > >> and as the TRM suggests nobody should be using anything other than the > >> div2 setting for clk_m. I'm certainly not aware of any devices that do > >> something different. And U-Boot has always had this assumption as well, > >> so I think it's safe to use. > > > > Am I understanding correctly that for T210 we can/should use > > clk_m_get_rate() instead of clock_get_osc_freq() in tegra_timer_probe()? > > Have you tested this option? > > Although, looking at the kernel code, I see that clk_m is the parent > clock for timer on all SoCs. Hence replacing clock_get_osc_freq() with > clk_m_get_rate() should be the proper solution and then no T210-specific > workarounds are needed. > ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2023-01-27 13:40 UTC | newest] Thread overview: 18+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-01-24 6:57 [PATCH v6 0/3] Timer support for ARM Tegra Svyatoslav Ryhel 2023-01-24 6:57 ` [PATCH v6 1/3] ARM: tegra: remap clock_osc_freq for all Tegra family Svyatoslav Ryhel 2023-01-24 6:57 ` [PATCH v6 2/3] drivers: timer: add timer driver for ARMv7 based Tegra devices Svyatoslav Ryhel 2023-01-24 6:57 ` [PATCH v6 3/3] ARM: tegra: include timer as default option Svyatoslav Ryhel 2023-01-25 16:41 ` [PATCH v6 0/3] Timer support for ARM Tegra Thierry Reding 2023-01-26 10:34 ` Thierry Reding 2023-01-26 11:40 ` Thierry Reding 2023-01-26 16:49 ` Tom Warren 2023-01-26 17:12 ` Svyatoslav Ryhel 2023-01-26 17:58 ` Thierry Reding 2023-01-26 18:10 ` Svyatoslav Ryhel 2023-01-26 22:12 ` Tom Warren 2023-01-26 18:28 ` Svyatoslav Ryhel 2023-01-26 17:08 ` Svyatoslav Ryhel 2023-01-26 17:54 ` Thierry Reding 2023-01-26 22:00 ` Dmitry Osipenko 2023-01-26 22:12 ` Dmitry Osipenko 2023-01-27 4:51 ` Svyatoslav Ryhel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox