From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mmc: Use proper IS_ENABLED macro to check block support
Date: Tue, 8 Jan 2019 17:14:44 +0100 [thread overview]
Message-ID: <8f7ebc9a-a9ba-3291-2269-c7bc1cb38397@gmail.com> (raw)
In-Reply-To: <20190107211325.13526-1-ezequiel@collabora.com>
Am 07.01.19 um 22:13 schrieb Ezequiel Garcia:
> Use CONFIG_IS_ENABLED(BLK) instead of CONFIG_BLK,
> in order to fix the following build issues when
> CONFIG_SPL_MMC_WRITE is selected:
>
> drivers/mmc/mmc_write.c:69:7: error: conflicting types for 'mmc_berase'
> ulong mmc_berase(struct udevice *dev, lbaint_t start, lbaint_t blkcnt)
> ^~~~~~~~~~
> In file included from drivers/mmc/mmc_write.c:15:0:
> drivers/mmc/mmc_private.h:39:7: note: previous declaration of 'mmc_berase' was here
> ulong mmc_berase(struct blk_desc *block_dev, lbaint_t start, lbaint_t blkcnt);
> ^~~~~~~~~~
> drivers/mmc/mmc_write.c:187:7: error: conflicting types for 'mmc_bwrite'
> ulong mmc_bwrite(struct udevice *dev, lbaint_t start, lbaint_t blkcnt,
> ^~~~~~~~~~
> In file included from drivers/mmc/mmc_write.c:15:0:
> drivers/mmc/mmc_private.h:37:7: note: previous declaration of 'mmc_bwrite' was here
> ulong mmc_bwrite(struct blk_desc *block_dev, lbaint_t start, lbaint_t blkcnt,
> ^~~~~~~~~~
>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
> drivers/mmc/mmc_write.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
--
- Daniel
next prev parent reply other threads:[~2019-01-08 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 21:13 [U-Boot] [PATCH 1/2] mmc: Use proper IS_ENABLED macro to check block support Ezequiel Garcia
2019-01-07 21:13 ` [U-Boot] [PATCH 2/2] mmc: jz_mmc: Compile-out write support if disabled Ezequiel Garcia
2019-01-08 16:16 ` Daniel Schwierzeck
2019-01-12 16:52 ` Daniel Schwierzeck
2019-01-08 16:14 ` Daniel Schwierzeck [this message]
2019-01-12 16:51 ` [U-Boot] [PATCH 1/2] mmc: Use proper IS_ENABLED macro to check block support Daniel Schwierzeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f7ebc9a-a9ba-3291-2269-c7bc1cb38397@gmail.com \
--to=daniel.schwierzeck@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox