From: Marek Vasut <marex@denx.de>
To: Hector Martin <marcan@marcan.st>, Bin Meng <bmeng.cn@gmail.com>
Cc: Mark Kettenis <kettenis@openbsd.org>,
u-boot@lists.denx.de, asahi@lists.linux.dev
Subject: Re: [PATCH 2/8] usb: xhci: Better error handling in abort_td()
Date: Fri, 27 Oct 2023 02:52:15 +0200 [thread overview]
Message-ID: <8fd6dfd6-2ac3-423e-9380-e1139b98ab45@denx.de> (raw)
In-Reply-To: <20231027-usb-fixes-1-v1-2-1c879bbcd928@marcan.st>
On 10/27/23 01:16, Hector Martin wrote:
> If the xHC has a problem with our STOP ENDPOINT command, it is likely to
> return a completion directly instead of first a transfer event for the
> in-progress transfer. Handle that more gracefully.
>
> Right now we still BUG() on the error code, but at least we don't end up
> timing out on the event and ending up with unexpected event errors.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
I'll defer the rest of the review to Bin , he just knows better when it
comes to xHCI . Please ping me if things are stuck for too long however.
next prev parent reply other threads:[~2023-10-27 1:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 23:16 [PATCH 0/8] USB fixes: xHCI error handling Hector Martin
2023-10-26 23:16 ` [PATCH 1/8] usb: xhci: Guard all calls to xhci_wait_for_event Hector Martin
2023-10-26 23:26 ` [PATCH] fixup! " Hector Martin
2023-10-27 0:36 ` Marek Vasut
2023-10-27 6:03 ` Hector Martin
2023-10-29 21:25 ` Marek Vasut
2023-10-29 21:33 ` Peter Robinson
2023-10-29 22:01 ` Tony Dinh
2023-10-26 23:16 ` [PATCH 2/8] usb: xhci: Better error handling in abort_td() Hector Martin
2023-10-27 0:52 ` Marek Vasut [this message]
2023-10-26 23:16 ` [PATCH 3/8] usb: xhci: Allow context state errors when halting an endpoint Hector Martin
2023-10-26 23:16 ` [PATCH 4/8] usb: xhci: Recover from halted non-control endpoints Hector Martin
2023-10-26 23:16 ` [PATCH 5/8] usb: xhci: Fail on attempt to queue TRBs to a halted endpoint Hector Martin
2023-10-26 23:16 ` [PATCH 6/8] usb: xhci: Do not panic on event timeouts Hector Martin
2023-10-26 23:16 ` [PATCH 7/8] usb: xhci: Fix DMA address calculation in queue_trb Hector Martin
2023-10-26 23:16 ` [PATCH 8/8] usb: xhci: Add more debugging Hector Martin
2023-10-27 18:58 ` [PATCH 0/8] USB fixes: xHCI error handling Neal Gompa
2023-10-27 19:42 ` Neal Gompa
2023-11-19 20:08 ` Marek Vasut
2023-11-19 23:17 ` Shantur Rathore
2023-11-20 2:09 ` Marek Vasut
2023-11-20 10:45 ` Hector Martin
2023-11-20 12:15 ` Marek Vasut
2023-11-21 6:46 ` Hector Martin
2023-11-22 23:52 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fd6dfd6-2ac3-423e-9380-e1139b98ab45@denx.de \
--to=marex@denx.de \
--cc=asahi@lists.linux.dev \
--cc=bmeng.cn@gmail.com \
--cc=kettenis@openbsd.org \
--cc=marcan@marcan.st \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox