From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA4CCC07E9B for ; Wed, 21 Jul 2021 07:53:03 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85BF060FE9 for ; Wed, 21 Jul 2021 07:53:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85BF060FE9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DF5D582977; Wed, 21 Jul 2021 09:52:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1626853980; bh=uF5EAiFdW2AH2Ny+jz6p992/ai97hcnWVhUzPyOHLR0=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JsHsv2Ji7KcWEDc0ooUATwWE2yXaMBbWI3AanrDeeMpebZYKr/reHhTrGCtGj2tqd Yi9GGXi7s6hbWrfaipXf8mZCHWkdDYyuOHPsUU0TDJA4Xu2E/XkHmKGMNk5TCOzlxN Xkk0jJGPJgXyV6XnLUs55xVZ50QFuiIVGBnY/TwQsZZLoFFbZ1Hw1ozrXZAwhklPzb TGMnTJ2C14qHlTZeQjwPgOo2pKn4mqPrWTulLMbPAqV080YTAiZ7dDuTsicmIu7HuM 9P8rQkrnNu9byj6Ux6b7jLote3zPtHBY2kL0iHhuHcIlA/qwzOJjj+5sv4ZUPA2Bo6 Lv/PZHF5BGh7w== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id D6B6481FEB for ; Wed, 21 Jul 2021 09:52:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1626853978; bh=uF5EAiFdW2AH2Ny+jz6p992/ai97hcnWVhUzPyOHLR0=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=o4dKXUtM13QKlk8g0a23ivvChNROjYiZ6PNFZ57B52k6+2IYBqi629I4rkwQTQrH3 RdbWd5kCmr/WnGKFH8SLxJ/YS9Ion1eFHi5QE/tF8n9d90UX/omqNcMfwh+VXVLNUp YfGR8XGTqsp84KwwncDseE2ZZ7jTiYwKGSIL9Hf+pWTXpdM1yrHXoeRM30Pgh8AVAK /OsBHZfdbIP1hyaQDr3qYwoiWIOqYXw4qTEDPukw4g7hzpyG+bOk7MK2ZBoqVe2KCc aqUsBq1kXXQEO2XnzccQ4/8Vp7JSPqnf1h4KdmdVq0TeiJg2sCgNXcymS+4fGbvRw2 4HnJTYKdBcRsw== Received: by janitor.denx.de (Postfix, from userid 108) id 92059A0272; Wed, 21 Jul 2021 09:52:58 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 6B410A00A4; Wed, 21 Jul 2021 09:52:50 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 284031E14C3; Wed, 21 Jul 2021 09:52:50 +0200 (CEST) To: Tom Rini cc: Simon Glass , U-Boot Mailing List , Eugeniu Rosca , Roland Gaudig , Heinrich Schuchardt , Stefan Herbrechtsmeier , Sean Anderson , Marek =?iso-8859-1?Q?Beh=FAn?= , Marek Vasut , Joe Hershberger From: Wolfgang Denk Subject: Re: [PATCH 00/15] lib: Add support for a decimal 0m prefix for numbers MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20210720160547.GM9379@bill-the-cat> References: <20210720132940.1171011-1-sjg@chromium.org> <20210720142218.GI9379@bill-the-cat> <20210720160547.GM9379@bill-the-cat> Comments: In-reply-to Tom Rini message dated "Tue, 20 Jul 2021 12:05:47 -0400." Date: Wed, 21 Jul 2021 09:52:50 +0200 Message-ID: <912010.1626853970@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi, In message <20210720160547.GM9379@bill-the-cat> you wrote: > > > So for example (10)123 would mean decimal 123? I don't know how we > > would parse brackets separately from expressions though. > > (123)10 would be "123" in decimal. Which is indeed a mouthful. But it > would also be generic and (123)16 would be 0x123. So the parsing > shouldn't be too hard, for most commands. But then yes, expressions > become quite hard. Come on, guys, be serious! This is a boot loader. Size matters. Do we _really_ need all this, and is it worth the code size? Simon's patches include some cleanup, which probably even reduces the size, so good. But whether it's 0m123 or 0t123 or 0!123 or ... is pretty much irrelevant - chose one symbol, use it, and be done with that. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Do you suppose the reason the ends of the `Intel Inside' logo don't match up is that it was drawn on a Pentium?