From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E14B4C11F64 for ; Tue, 29 Jun 2021 03:17:55 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4265161CDA for ; Tue, 29 Jun 2021 03:17:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4265161CDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8F96682E94; Tue, 29 Jun 2021 05:17:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="qWnlnZHE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1287382E98; Tue, 29 Jun 2021 05:17:52 +0200 (CEST) Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BB53482E6A for ; Tue, 29 Jun 2021 05:17:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20210629031737epoutp0372d3965f4113c149472fdddf5fa5417c~M70fbMHPc2557925579epoutp03e for ; Tue, 29 Jun 2021 03:17:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20210629031737epoutp0372d3965f4113c149472fdddf5fa5417c~M70fbMHPc2557925579epoutp03e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1624936657; bh=+rfDm2ds7nlet1SEFSoUjQZI0pqmu3j4XtonPJmGXv4=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=qWnlnZHEgJXnYERRWEvDC+GNzI/LWW8EQFWFWu4twri9gChpiMy5b3WkRkyeId1R1 JQmA5/1xRrxrhLpXICuERZOR3IU4aLe+75feL/udBYE771QepWbr9L0UlWq7UrK6BH wMQdmmiejdFF8IeG1bAY2nmhinPOYJcGlWZv0vEo= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20210629031737epcas1p14965fb684da64b88570b215f8fea5c01~M70fJGR4q2347923479epcas1p1O; Tue, 29 Jun 2021 03:17:37 +0000 (GMT) Received: from epsmges1p1.samsung.com (unknown [182.195.40.152]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4GDV5q65nTz4x9Pr; Tue, 29 Jun 2021 03:17:35 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p1.samsung.com (Symantec Messaging Gateway) with SMTP id 31.E5.09952.8C09AD06; Tue, 29 Jun 2021 12:17:28 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20210629031727epcas1p39d098121c0e26bcb3a16db81afdfcfa6~M70WlVCyx3026830268epcas1p3P; Tue, 29 Jun 2021 03:17:27 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20210629031727epsmtrp2fc518f00af204732ce143d9da66784c9~M70WknXQi1068610686epsmtrp2f; Tue, 29 Jun 2021 03:17:27 +0000 (GMT) X-AuditID: b6c32a35-45dff700000026e0-5b-60da90c8a5fb Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 72.62.08289.7C09AD06; Tue, 29 Jun 2021 12:17:27 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20210629031727epsmtip21f2ca446bee82e40a03bea42bee41135~M70WYsIUz2230422304epsmtip2c; Tue, 29 Jun 2021 03:17:27 +0000 (GMT) Subject: Re: [PATCH v2 2/3] mmc: rockchip_sdhci: Add support for RK3568 To: =?UTF-8?B?6LW15Luq5bOw?= , sjg , =?UTF-8?B?5p2o5Yev?= Cc: Peng Fan , Philipp Tomsich , u-boot From: Jaehoon Chung Message-ID: <91cad437-e6ef-b356-8601-eac6b6acb059@samsung.com> Date: Tue, 29 Jun 2021 12:18:22 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210629100628047117160@rock-chips.com> Content-Language: en-US Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCJsWRmVeSWpSXmKPExsWy7bCmge6JCbcSDKZc0rDYNv0nm8WPVV9Y LbpXVlt827KN0eLt3k52i6dP/rE4sHnMbrjI4nH2zg5Gj43vdjB5/J21n8Vj5+2HTAGsUdk2 GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUAXKCmUJeaU AoUCEouLlfTtbIryS0tSFTLyi0tslVILUnIKLAv0ihNzi0vz0vWS83OtDA0MjEyBChOyM471 NjIVPGGq+Hv7BWsD4xSmLkZODgkBE4kPmzvZuhi5OIQEdjBK3Px3HMr5xCjxeUsnK4TzmVFi 7f17LDAtk37sZoFI7GKUuPTkEjuE855RYuORduYuRg4OYQF3iQndcSBxEYFWRonGhrusIN3M AjkSZye/Ygax2QR0JLZ/Ow52CK+AncTdr7PBbBYBVYm5P04zgtiiApES53cvYIGoEZQ4OfMJ mM0pYCoxddMCZoiZ4hK3nsxngrDlJZq3zmYGWSwh0MohsfH9VjaIs10kVr3ZDmULS7w6voUd wpaS+PxuL1S8WmJX8xmo5g5GiVvbmqDBZCyxf+lkJpDPmAU0Jdbv0ocIK0rs/D2XEWIxn8S7 rz2sICUSArwSHW1CECUqEpdev2SCWXX3yX9WCNtDYvOaqYwTGBVnIXltFpJ3ZiF5ZxbC4gWM LKsYxVILinPTU4sNCwyRo3sTIzh5apnuYJz49oPeIUYmDsZDjBIczEoivG/zbiUI8aYkVlal FuXHF5XmpBYfYjQFBvZEZinR5Hxg+s4riTc0NTI2NrYwMTQzNTRUEufdyXYoQUggPbEkNTs1 tSC1CKaPiYNTqoEpvHj74ScnHNbNmBG+0efjNtZ9D1xum7SdMlg3s7dla3uv6jRV70ipzA2C KdarV84+p6Z7/s2TplWFR8Kr3vr/eOojzu6ptObuhTATw5pMhTevai6VWN2ddn9K2fqCnu3V Sf2XglzOf0h+8bXKKeXD1e9c9VdepbO7G1xMCK7Nf75fK+wIY0j0nYs+fnqy3hKlJ/bsKN4s tlBryc777J/EnmZtF4wQ3zKnOeKYxZqHCX3lj++Kx20pupr49tEq3V3LPV/fWjdp85kdPg1N aueKLk1guvzq+9LfYrF7NGf9OOR67IT++jvfdN+fnGQxW+rVgiYX4XurJpprlbSLad+7fqN8 l96Oi2KTuqb4uld+k1NiKc5INNRiLipOBACxFG17JwQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsWy7bCSvO7xCbcSDD7+MbXYNv0nm8WPVV9Y LbpXVlt827KN0eLt3k52i6dP/rE4sHnMbrjI4nH2zg5Gj43vdjB5/J21n8Vj5+2HTAGsUVw2 Kak5mWWpRfp2CVwZx3obmQqeMFX8vf2CtYFxClMXIyeHhICJxKQfu1m6GLk4hAR2MEr8nNvE CpGQkvj8dCpbFyMHkC0scfhwMUTNW0aJC2umsoPEhQXcJSZ0x4HERQRaGSVmtfxlAellFsiR WDrvAdTQlUwSr+4+BhvKJqAjsf3bcbDNvAJ2Ene/zgazWQRUJeb+OM0IYosKREp8XvCKFaJG UOLkzCdgQzkFTCWmblrADLFAXeLPvEtQtrjErSfzmSBseYnmrbOZJzAKzULSPgtJyywkLbOQ tCxgZFnFKJlaUJybnltsWGCUl1quV5yYW1yal66XnJ+7iREcLVpaOxj3rPqgd4iRiYPxEKME B7OSCO/bvFsJQrwpiZVVqUX58UWlOanFhxilOViUxHkvdJ2MFxJITyxJzU5NLUgtgskycXBK NTDNCmt8WykZ8276p598TukTD906vDxsUt+Jn1uZHOpD9/p/PKos93JN9Xz/6atvnk7KnV8T +FpTXI6rNCNqubEyc8bFnnXrX3Dde775etZ17tgDImfYjaZGbPvEu9Jr+s0WdhfR9OeC05+d sdiTb5/zRco18+dqtS1rGHoSCoPvL5j+pr7QfPKJ13sLvvpO35e9ti2c7eTVLTozGp4YF14R ejzJV0HCscB2c/Przzcsdk93PHLL8sebs4u+fIo8/D/7pVyV2gH558rSy8t3mnl1MK2slC7O ENUtU1nzo+n5pEOztc++K2RZqvro8gfhKenq9QENeQ0Or51XSEmqS337wynWXWV8NTCmtfi2 NdsbJZbijERDLeai4kQAKUq2mQUDAAA= X-CMS-MailID: 20210629031727epcas1p39d098121c0e26bcb3a16db81afdfcfa6 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20210628092003epcas1p3c423764e175dd5ad2832212bfa63607b References: <20210628091952.29533-1-yifeng.zhao@rock-chips.com> <20210628091952.29533-3-yifeng.zhao@rock-chips.com> <91fba9f1-1b1f-41ad-00b7-b104c79a2d3f@samsung.com> <20210629100628047117160@rock-chips.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi, On 6/29/21 11:07 AM, 赵仪峰 wrote: > > > The variable types are different, IS_ERR_VALUE(host->max_clk) will not got the right results. > > unsigned int max_clk; > > #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO) Thanks for kindly explanation. I didn't check its type. Best Regards, Jaehoon Chung >