From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kever Yang Date: Wed, 24 Jul 2019 17:11:02 +0800 Subject: [U-Boot] [PATCH 1/2] arm: dts: rock960: Enable booting from eMMC when using SPL In-Reply-To: References: <20190520154656.28476-1-manivannan.sadhasivam@linaro.org> Message-ID: <91f28792-2df2-d127-25ce-06d581418673@rock-chips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de Hi Manivannan, On 2019/7/24 下午3:59, Peter Robinson wrote: > On Mon, May 20, 2019 at 4:47 PM Manivannan Sadhasivam > wrote: >> This commits enables booting from eMMC when using SPL on 96Boards >> Rock960 board by adding SDHCI to boot order. Since the SDHCI driver >> already has the reloc flag, this works straightaway. >> >> Signed-off-by: Manivannan Sadhasivam >> --- >> arch/arm/dts/rk3399-rock960-u-boot.dtsi | 1 + >> arch/arm/dts/rk3399-rock960.dts | 2 ++ >> 2 files changed, 3 insertions(+) >> >> diff --git a/arch/arm/dts/rk3399-rock960-u-boot.dtsi b/arch/arm/dts/rk3399-rock960-u-boot.dtsi >> index 5256f6d3f2..7fb5072a9b 100644 >> --- a/arch/arm/dts/rk3399-rock960-u-boot.dtsi >> +++ b/arch/arm/dts/rk3399-rock960-u-boot.dtsi >> @@ -3,4 +3,5 @@ >> * Copyright (C) 2019 Jagan Teki >> */ >> >> +#include "rk3399-u-boot.dtsi" >> #include "rk3399-sdram-lpddr3-2GB-1600.dtsi" >> diff --git a/arch/arm/dts/rk3399-rock960.dts b/arch/arm/dts/rk3399-rock960.dts >> index 7e06bc97e5..c8b9075c73 100644 >> --- a/arch/arm/dts/rk3399-rock960.dts >> +++ b/arch/arm/dts/rk3399-rock960.dts >> @@ -12,6 +12,8 @@ >> >> chosen { >> stdout-path = "serial2:1500000n8"; >> + u-boot,spl-boot-order = \ >> + &sdhci, &sdmmc; > Shouldn't this bit be in the rk3399-rock960-u-boot.dtsi not > rk3399-rock960.dts because it's U-Boot specific? Peter is correct, all the update to dts by U-Boot should go to -u-boot.dtsi now, could you update and send the patch again? Thanks, - Kever > >> }; >> }; >> >> -- >> 2.17.1 >>