From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/8] net: ravb: Fix "left shift in type int" undefined behavior
Date: Mon, 20 Aug 2018 10:05:48 +0200 [thread overview]
Message-ID: <9219c882-a1de-8ec7-a595-e835369877f7@gmail.com> (raw)
In-Reply-To: <20180820000033.25519-7-erosca@de.adit-jv.com>
On 08/20/2018 02:00 AM, Eugeniu Rosca wrote:
> Running "tftp" on R-Car H3 Salvator-X with CONFIG_UBSAN=y results in:
>
[...]
>
> =====================================================================
> UBSAN: Undefined behaviour in drivers/net/ravb.c:205:20
> left shift of 12 by 28 places cannot be represented in type 'int'
> =====================================================================
> host 192.168.2.11 is alive
>
> There are two issues behind:
> - calculating RAVB_DESC_DT_* bitfields
> - assembling MAC address from its char components
>
> Fix both.
Nice
Acked-by: Marek Vasut <marek.vasut@gmail.com>
btw sh_eth.c might have similar issue .
> Fixes: 8ae51b6f324e ("net: ravb: Add Renesas Ethernet RAVB driver")
> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
[...]
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-08-20 8:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 0:00 [U-Boot] [PATCH 0/8] Import Undefined Behavior Sanitizer Eugeniu Rosca
2018-08-20 0:00 ` [U-Boot] [PATCH 1/8] UBSAN: run-time undefined behavior sanity checker Eugeniu Rosca
2018-08-20 1:51 ` Tom Rini
2018-08-20 12:54 ` Eugeniu Rosca
2018-08-20 17:50 ` Tom Rini
2018-08-20 15:00 ` York Sun
2018-08-20 21:00 ` Eugeniu Rosca
2018-08-20 0:00 ` [U-Boot] [PATCH 2/8] mmc: Fix "left shift in type int" undefined behavior Eugeniu Rosca
2018-08-20 0:00 ` [U-Boot] [PATCH 3/8] armv8: mmu: " Eugeniu Rosca
2018-08-20 1:51 ` Tom Rini
2018-08-20 13:24 ` Eugeniu Rosca
2018-08-20 0:00 ` [U-Boot] [PATCH 4/8] pinctrl: renesas: " Eugeniu Rosca
2018-08-20 8:07 ` Marek Vasut
2018-08-20 13:42 ` Eugeniu Rosca
2018-08-20 0:00 ` [U-Boot] [PATCH 5/8] net: phy: " Eugeniu Rosca
2018-08-20 0:00 ` [U-Boot] [PATCH 6/8] net: ravb: " Eugeniu Rosca
2018-08-20 8:05 ` Marek Vasut [this message]
2018-08-20 0:00 ` [U-Boot] [PATCH 7/8] mmc: Fix read-past-end-of-array " Eugeniu Rosca
2018-08-20 0:00 ` [U-Boot] [PATCH 8/8] hashtable: Fix zero-sized array " Eugeniu Rosca
2018-08-20 1:51 ` Tom Rini
2018-08-20 1:51 ` [U-Boot] [PATCH 0/8] Import Undefined Behavior Sanitizer Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9219c882-a1de-8ec7-a595-e835369877f7@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox