Re: [PATCH v2 1/5] misc: fs_loader: fix ubifs not unmounted on dev_get_priv error

["Francis, Neha" <n-francis@ti.com>]

Hi Christian

On 3/7/2026 12:35 AM, Christian Marangi wrote:
> When dev_get_priv errors out, the ubifs is not umounted (if used).
> 
> Correctly handle this handle condition and while at it also return -EINVAL
> instead of -ENOMEM as a better error since no memory is allocated but is
> actually an invalid scenario for fw_get_filesystem_firmware().
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
>  drivers/misc/fs_loader.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c
> index 2928cf75f89e..7e432a7ebd62 100644
> --- a/drivers/misc/fs_loader.c
> +++ b/drivers/misc/fs_loader.c
> @@ -178,8 +178,10 @@ static int fw_get_filesystem_firmware(struct udevice *dev)
>  
>  	struct firmware *firmwarep = dev_get_priv(dev);
>  
> -	if (!firmwarep)
> -		return -ENOMEM;
> +	if (!firmwarep) {
> +		ret = -EINVAL;
> +		goto out;
> +	}
>  
>  	ret = fs_read(firmwarep->name, (ulong)map_to_sysmem(firmwarep->data),
>  			firmwarep->offset, firmwarep->size, &actread);

Reviewed-by: Neha Malcom Francis <n-francis@ti.com>

-- 
Thanking You
Neha Malcom Francis