From: Michal Simek <michal.simek@amd.com>
To: "Erkiaga Elorza, Ibai" <ibai.erkiaga-elorza@amd.com>,
Alexander Dahl <ada@thorsis.com>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>
Subject: Re: [U-Boot][PATCH 1/2] fpga: fix alignment on fpga cmd usage info
Date: Tue, 14 Jan 2025 08:53:46 +0100 [thread overview]
Message-ID: <92e6fdbd-d367-47bd-8c4e-ba62c4b7745e@amd.com> (raw)
In-Reply-To: <MN0PR12MB600443410FBC58B96C973CD5A0132@MN0PR12MB6004.namprd12.prod.outlook.com>
On 1/9/25 13:45, Erkiaga Elorza, Ibai wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
>
>
> Agree Alex,
>
> I just used /t to stick as much as possible to the current implementation, but
> I'm open to change to white spaces if Michal thinks it's better.
>
> Regards
> Ibai
>
> --------------------------------------------------------------------------------
> *From:* Alexander Dahl <ada@thorsis.com>
> *Sent:* 09 January 2025 07:52
> *To:* Erkiaga Elorza, Ibai <ibai.erkiaga-elorza@amd.com>
> *Cc:* u-boot@lists.denx.de <u-boot@lists.denx.de>; Simek, Michal
> <michal.simek@amd.com>
> *Subject:* Re: [U-Boot][PATCH 1/2] fpga: fix alignment on fpga cmd usage info
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Hello,
>
> Am Wed, Jan 08, 2025 at 02:03:50PM +0000 schrieb Ibai Erkiaga:
>> The current implementation generates some alignment issues as well as
>> some overlapping when all the fpga command options are enabled. The fix
>> is intended to improve readability of the usage info.
>
> Alignment could indeed improved. One question: the \t is dependent on
> the terminal, right? Would it be better to use spaces instead? That
> would also make the code more readable.
Agree. Even other commands are using tabs using spaces would be better.
Thanks,
Michal
next prev parent reply other threads:[~2025-01-14 7:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 14:03 [U-Boot][PATCH 0/2] Improve fpga cmd usage information Ibai Erkiaga
2025-01-08 14:03 ` [U-Boot][PATCH 1/2] fpga: fix alignment on fpga cmd usage info Ibai Erkiaga
2025-01-09 7:52 ` Alexander Dahl
2025-01-09 12:45 ` Erkiaga Elorza, Ibai
2025-01-14 7:53 ` Michal Simek [this message]
2025-01-14 8:10 ` Michal Simek
2025-01-08 14:03 ` [U-Boot][PATCH 2/2] fpga: improve loads usage information Ibai Erkiaga
2025-01-14 7:58 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92e6fdbd-d367-47bd-8c4e-ba62c4b7745e@amd.com \
--to=michal.simek@amd.com \
--cc=ada@thorsis.com \
--cc=ibai.erkiaga-elorza@amd.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox