Re: [PATCH v1 21/26] imx8mn: synchronise device tree with linux

Adam Ford
2022-07-31T16:58:38Z

On Thu, Jul 21, 2022 at 8:44 AM Marcel Ziswiler <marcel@ziswiler.com> wrote:
>
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Synchronise device tree with linux v5.19-rc5.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

For what it's worth to others who may have been impacted, this patch
broke my nano booting because the imx8mn.dtsi now has the UART's as
subnodes to spba1 which wasn't being included in SPL's device tree.
It's likely to impact others who are booting with DM_SERIAL enabled on
their Nano.

To fix, I had to add a small line of code to my
imx8mn-beacon-kit-u-boot.dtsi file with the following:

&spba1 {
u-boot,dm-spl;
};

With that, my board boots again. If anyone else is using DM_SERIAL
and having issues no longer starting, give that a try.

Since there are few nano boards with common -u-boot.dtsi entries, it
seems like it makes sense to have a common imx8mn-u-boot.dtsi file
like we do for Mini and Plus. I'll try to work on that as I have
time. (hopefully today)

adam
> ---
>
> arch/arm/dts/imx8mn-beacon-baseboard.dtsi | 4 +-
> arch/arm/dts/imx8mn-beacon-som.dtsi | 12 +-
> arch/arm/dts/imx8mn-bsh-smm-s2-common.dtsi | 113 ++++-----
> arch/arm/dts/imx8mn-bsh-smm-s2pro.dts | 90 +++++++
> arch/arm/dts/imx8mn-ddr4-evk.dts | 4 +
> arch/arm/dts/imx8mn-evk-u-boot.dtsi | 4 +-
> arch/arm/dts/imx8mn-evk.dts | 56 ++---
> arch/arm/dts/imx8mn-evk.dtsi | 121 +++++++++
> arch/arm/dts/imx8mn-var-som.dtsi | 15 +-
> arch/arm/dts/imx8mn-venice-gw7902.dts | 80 ++++--
> arch/arm/dts/imx8mn.dtsi | 270 ++++++++++++++-------
> board/freescale/imx8mn_evk/spl.c | 2 +-
> include/dt-bindings/clock/imx8mn-clock.h | 25 +-
> include/dt-bindings/power/imx8mn-power.h | 5 +
> include/dt-bindings/sound/tlv320aic31xx.h | 14 ++
> 15 files changed, 607 insertions(+), 208 deletions(-)
> create mode 100644 include/dt-bindings/sound/tlv320aic31xx.h
>
<snip>

> --
> 2.35.1
>