From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68FFEC433FE for ; Tue, 4 Oct 2022 12:32:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 06AC484CF9; Tue, 4 Oct 2022 14:32:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="DfP642q6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 041C784CA4; Tue, 4 Oct 2022 14:32:54 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2084.outbound.protection.outlook.com [40.107.92.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4BECD84CF9 for ; Tue, 4 Oct 2022 14:32:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=knKWy1Xh0ucol4WtvogAJ2N7tLNdyOdxrHu3SgQIKcfB1WWotYG1b0fVzr0X5rMpOoHghEZVhbdc4j5mgy68aki1Ka8sF+QMXhPBXKHzyMF/nyFImM8e9veRfYWvfh8Rqaw1vIZMZlGMmWwN4MG0f/QQ2ZxPjjm1+BkmpD2ZBMWZGh9k8Ij9ftrLAH9+DyoX7cTdiFH1gGtyonNruV15eV184I1BBTgqe/jnUX6bueQMMZpF9lBHBFPKbs8gL67VVCVInKivg6DoLkCf+CNqCgXzvNyBD+YG4idY5Y5nLa52ez1rxDJy4HVa6WW1gw9z/x/1Lcarp+L8AZEf0w+WdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cQb572S+WBuBGHnWqudvplBeEMcqmpQqSLDxCLAfuRY=; b=aX0P3P7OKwVH0YuP2hWXxOXhyWAzDvN+qEpax+kmrCyLXMaBx+n7VuQJ4Mt7y/y8NL3IcSdONwJtzkVNM4b8mv210a25gU6BLxaM+dAkvgIJuY+Z38ERASa8cuzN5OgaDmii/vv0qwHiv2PzabgAtoywQkMFzsyWpQHsReaZmaKrdme4BrZG76vwzOKZq4oGvjl1z3rIx1qVYnzkAurTMP2BLc+gS34a2IGxSdKgRjppuTdEW6dde89rINUksc6iELFACWcC+n2T5eD1ccx0CEEHtZ1P9cJeOPZPWMCLGu8xbAPkJeIeONpsSSWA97kevYJQ1WA4BcspfdCS5b4DKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cQb572S+WBuBGHnWqudvplBeEMcqmpQqSLDxCLAfuRY=; b=DfP642q6QGME24HmGeG7+z8gDvfQCC9q6FytiNlQUofv3nsuV9aPTjVdlBRMKwUYnNbHUF9kYZw3n/RSlAhn9p9aj2eePZMGSMupLHCFzjdpIrave2vEU8bfoqawHR3yp00o842VYCglqA1XVowHlAvJ74nVWf8Ov85c0X7+/WQ= Received: from MW4P223CA0030.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::35) by DM6PR12MB4468.namprd12.prod.outlook.com (2603:10b6:5:2ac::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Tue, 4 Oct 2022 12:32:46 +0000 Received: from CO1NAM11FT023.eop-nam11.prod.protection.outlook.com (2603:10b6:303:80:cafe::3e) by MW4P223CA0030.outlook.office365.com (2603:10b6:303:80::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31 via Frontend Transport; Tue, 4 Oct 2022 12:32:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT023.mail.protection.outlook.com (10.13.175.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5676.17 via Frontend Transport; Tue, 4 Oct 2022 12:32:46 +0000 Received: from [10.254.241.52] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 4 Oct 2022 07:32:43 -0500 Message-ID: <93d6ebad-e24b-069d-6051-7149af9d3d50@amd.com> Date: Tue, 4 Oct 2022 14:32:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH] mmc: Fix static checker warnings Content-Language: en-US To: Venkatesh Yadav Abbarapu , CC: , , References: <20220929045249.23842-1-venkatesh.abbarapu@amd.com> From: Michal Simek In-Reply-To: <20220929045249.23842-1-venkatesh.abbarapu@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT023:EE_|DM6PR12MB4468:EE_ X-MS-Office365-Filtering-Correlation-Id: 0397bf21-b932-4833-cc2b-08daa6048ab8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gcj9PscWR3fgnTL1PSsBNn+1CWBUp9A0pFbeBAZN8tQg3nkcBOO9bvmjPlIUR4/7S2BbVW6BJW6tBLUB4+aW2p1Pnmvp61AIu6NUfPHBvcKrptqIARCJc/vUjoAJ2JbK/WSll3D1vv5aT6D0Q5pQvFP0gubmbap92LAlhCDULBVfpYn911RPgPTCWebEmdcp2C/6UZXaOVPtLveogOkEnnnRPyvb7POXsw83+DZwF17MFOVgxMr/SrgaeYdsoVwx1eADXm8eFBYaoeMV53MnP13yAKIWvxLc6q+t9BwBLaMOKFgiDe/SevW+JRfxB8KUoFTfOA0uhgtIr7hHACmMMwCxZ7gF3RUMStk9GHdjeJgd5Bia+9PByqGCCMtcKkx/RYtieM7oDdhdMHg6OMTosJQOLd5XiEyP/AeTZlfQ8Xl2DRW4R4ZasvSAVqOMf/7X7JrBfN7ZHXvKevd1hsRNtxFKJSW7pd6pb1nVM3YKkAZB1au+dPy6b9I9DapsF0RjXnM7L1oFYzEuFvffSRaXZwaCrxff8eMmZcQy81LN6Htp+rVq7S9myvWWMm4U3IrtLgd+hQZQ0yIR5JhQv5YMRkcfOKLE7OzE24S/yePqaQqakl/U4fvaNSfqMSqu1BksxltZWQ/8+d0mZb6ZsseBUhyYIkxLcO6Ghsqy3j/Hee4GtmL1t8+pyk4zID6Oj8nSqR1vcrT5peivM0K0qay9ySyG7CiOXhlKy2+I5JFEVvuWlnZIbQmIqGIdtJu/ydRDctWn4csM8BNYBNcv7CH35vV4rIOvsV9grh0kK9lSIUjrrr2ykou36llr/2uFWGN+nkXkCF11RHcP2AgTmctNaQ== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(376002)(136003)(39860400002)(346002)(396003)(451199015)(40470700004)(36840700001)(46966006)(82740400003)(47076005)(36860700001)(31686004)(70206006)(16526019)(8676002)(36756003)(336012)(426003)(83380400001)(2616005)(54906003)(186003)(26005)(70586007)(53546011)(478600001)(107886003)(356005)(110136005)(44832011)(16576012)(316002)(81166007)(8936002)(4326008)(5660300002)(41300700001)(2906002)(4744005)(40460700003)(40480700001)(86362001)(82310400005)(31696002)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 12:32:46.1918 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0397bf21-b932-4833-cc2b-08daa6048ab8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT023.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4468 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 9/29/22 06:52, Venkatesh Yadav Abbarapu wrote: > Correct pointer dereferencing check to be more consistent. > > Eliminate the below smatch warning: > drivers/mmc/mmc.c:3118 mmc_init_device() > warn: variable dereferenced before check 'm' (see line 3116) > > Signed-off-by: Venkatesh Yadav Abbarapu > --- > > drivers/mmc/mmc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c > index 0b7c0be8cb..210703ea46 100644 > --- a/drivers/mmc/mmc.c > +++ b/drivers/mmc/mmc.c > @@ -3113,10 +3113,12 @@ int mmc_init_device(int num) > } > > m = mmc_get_mmc_dev(dev); > - m->user_speed_mode = MMC_MODES_END; /* Initialising user set speed mode */ > - > if (!m) > return 0; > + > + /* Initialising user set speed mode */ > + m->user_speed_mode = MMC_MODES_END; > + > if (m->preinit) > mmc_start_init(m); > Reviewed-by: Michal Simek Thanks, Michal