public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] usb_stor_BBB_transport 5 ms delay - performance
Date: Sun, 29 Jul 2012 03:31:48 +0200 (CEST)	[thread overview]
Message-ID: <943730195.759658.1343525508215.JavaMail.root@advansee.com> (raw)
In-Reply-To: <201207271944.04577.marex@denx.de>

Dear Marek,

On Fri, Jul 27, 2012 at 07:44:04 PM, Marek Vasut wrote:
> > I did see a flags field but thought having a new one was
> > conservative (I
> > had no real reason to have a new field).   As for the typecasts I
> > was
> > following the API which tests for device ready (Monkey See Monkey
> > Do).
> 
> Ouch, the API seems so broken then :-(

There is already a local ss variable defined for that purpose anyway, so
duplicating this typecast can be avoided.

> > Also I have no compelling reason to need a "setter function"
> > either.  I
> > have no compelling feelings towards the implementation other than
> > the 5ms
> > adds an unnecessary delay when the device is already known to be
> > ready, and
> > this delay accumulates to a very poor performance for large files.
> 
> Correct!
> 
> > Thanks for working on this!
> 
> No, thank you!

I'll try to do that on Monday. That will make many changes to the patch, so I'll
add my SoB after Jim's, saying what I did.

Best regards,
Beno?t

  reply	other threads:[~2012-07-29  1:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26 20:20 [U-Boot] usb_stor_BBB_transport 5 ms delay - performance Jim Shimer
2012-07-27  0:43 ` Benoît Thébaudeau
2012-07-27  4:47   ` Jim Shimer
2012-07-27 12:59   ` Marek Vasut
2012-07-27 14:07     ` Benoît Thébaudeau
2012-07-27 14:09       ` Marek Vasut
2012-07-27 14:17         ` Benoît Thébaudeau
2012-07-27 14:55           ` Jim Shimer
2012-07-27 15:06   ` Marek Vasut
2012-07-27 15:43     ` Jim Shimer
2012-07-27 17:44       ` Marek Vasut
2012-07-29  1:31         ` Benoît Thébaudeau [this message]
2012-07-29  1:38           ` Marek Vasut
2012-08-09 21:53 ` [U-Boot] [PATCH v3 7/8] usb_stor_BBB_transport: Do not delay when not required Benoît Thébaudeau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=943730195.759658.1343525508215.JavaMail.root@advansee.com \
    --to=benoit.thebaudeau@advansee.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox