From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= <benoit.thebaudeau@advansee.com>
Date: Sun, 29 Jul 2012 03:31:48 +0200 (CEST)
Subject: [U-Boot] usb_stor_BBB_transport 5 ms delay - performance
In-Reply-To: <201207271944.04577.marex@denx.de>
Message-ID: <943730195.759658.1343525508215.JavaMail.root@advansee.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Marek,

On Fri, Jul 27, 2012 at 07:44:04 PM, Marek Vasut wrote:
> > I did see a flags field but thought having a new one was
> > conservative (I
> > had no real reason to have a new field).   As for the typecasts I
> > was
> > following the API which tests for device ready (Monkey See Monkey
> > Do).
> 
> Ouch, the API seems so broken then :-(

There is already a local ss variable defined for that purpose anyway, so
duplicating this typecast can be avoided.

> > Also I have no compelling reason to need a "setter function"
> > either.  I
> > have no compelling feelings towards the implementation other than
> > the 5ms
> > adds an unnecessary delay when the device is already known to be
> > ready, and
> > this delay accumulates to a very poor performance for large files.
> 
> Correct!
> 
> > Thanks for working on this!
> 
> No, thank you!

I'll try to do that on Monday. That will make many changes to the patch, so I'll
add my SoB after Jim's, saying what I did.

Best regards,
Beno?t