From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ajay Bhargav Date: Tue, 23 Aug 2011 11:41:57 +0530 (IST) Subject: [U-Boot] [PATCH 1/3] net: Adds Fast Ethernet Controller driver for Armada100 In-Reply-To: <201108221453.19541.marek.vasut@gmail.com> Message-ID: <948373945.121424.1314079917382.JavaMail.root@ahm.einfochips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de ----- "Marek Vasut" wrote: > On Monday, August 22, 2011 07:11:57 AM Ajay Bhargav wrote: > > This patch adds support for Fast Ethernet Controller driver for > > Armada100 series. > > > > Signed-off-by: Ajay Bhargav > > --- > > arch/arm/include/asm/arch-armada100/armada100.h | 1 + > > drivers/net/Makefile | 1 + > > drivers/net/armada100_fec.c | 802 > > +++++++++++++++++++++++ drivers/net/armada100_fec.h > | > > 225 +++++++ > > include/netdev.h | 1 + > > 5 files changed, 1030 insertions(+), 0 deletions(-) > > create mode 100644 drivers/net/armada100_fec.c > > create mode 100644 drivers/net/armada100_fec.h > > [...] > > +static u8 get_random_byte(u8 seed) > > +{ > > + udelay(seed * 1000); > > + return (u8)(read_timer()); > > Parens not needed, anyway, don't we have any better "random()" here ? > I could not find random() function anywhere in the u-boot source. [...] > > + /* Generate random lower MAC half */ > > + dev->enetaddr[3] = get_random_byte((u8)read_timer()); > > + dev->enetaddr[4] = get_random_byte(dev->enetaddr[3]); > > + dev->enetaddr[5] = get_random_byte(dev->enetaddr[4]); > > +#endif > > Won't uboot handle this ... or aren't there some mechanisms to > generate random > MAC that can be reused? > There is a program given in tools directory for generating ethernet mac "gen_eth_addr.c" but nothing as such in u-boot source as far as i checked. Please let me know if I missed something to check. Thanks & Regards, Ajay Bhargav