From: Sam Edwards <cfsworks@gmail.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: u-boot@lists.denx.de, Jagan Teki <jagan@amarulasolutions.com>,
Samuel Holland <samuel@sholland.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Icenowy Zheng <uwu@icenowy.me>,
Maksim Kiselev <bigunclemax@gmail.com>
Subject: Re: [PATCH 0/3] Allwinner R528/T113s PSCI
Date: Mon, 14 Aug 2023 12:31:08 -0600 [thread overview]
Message-ID: <95603ff4-9cf2-c20d-3c17-84135bb931a2@gmail.com> (raw)
In-Reply-To: <20230814150648.1dddd00d@donnerap.manchester.arm.com>
On 8/14/23 08:06, Andre Przywara wrote:
> Hi Sam,
>
> many many thanks for sending this, I especially like your clean up around
> the #ifdef's!
>
> The patches looks good on the first glance (apart from some regression in
> patch 3/3), but I will reply to them individually.
>
> Cheers,
> Andre
Thanks for your attention to these! While you're in a PSCI headspace,
could you also look at my patch titled:
sunxi: psci: remove redundant initialization from psci_arch_init
...dated May 31?
This one should be pretty uncontroversial and straightforward to review. :)
Many thanks,
Sam
prev parent reply other threads:[~2023-08-14 18:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 0:30 [PATCH 0/3] Allwinner R528/T113s PSCI Sam Edwards
2023-08-12 0:30 ` [PATCH 1/3] sunxi: psci: clean away preprocessor macros Sam Edwards
2023-08-14 16:37 ` Andre Przywara
2023-08-14 18:10 ` Sam Edwards
2023-08-14 21:05 ` Andre Przywara
2023-08-14 21:23 ` Sam Edwards
2023-08-12 0:30 ` [PATCH 2/3] sunxi: psci: refactor register access to separate functions Sam Edwards
2023-08-12 0:30 ` [PATCH 3/3] sunxi: psci: implement PSCI on R528 Sam Edwards
2023-08-14 14:16 ` Andre Przywara
2023-08-15 19:17 ` Sam Edwards
2023-08-15 22:59 ` Andre Przywara
2023-08-16 1:48 ` Sam Edwards
2023-08-18 14:27 ` Andre Przywara
2023-08-18 22:22 ` Sam Edwards
2023-08-14 14:06 ` [PATCH 0/3] Allwinner R528/T113s PSCI Andre Przywara
2023-08-14 18:31 ` Sam Edwards [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95603ff4-9cf2-c20d-3c17-84135bb931a2@gmail.com \
--to=cfsworks@gmail.com \
--cc=andre.przywara@arm.com \
--cc=bigunclemax@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=samuel@sholland.org \
--cc=u-boot@lists.denx.de \
--cc=uwu@icenowy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox