From mboxrd@z Thu Jan 1 00:00:00 1970 From: Murray.Jensen at csiro.au Date: Fri, 01 Jul 2005 00:19:04 +1000 Subject: [U-Boot-Users] [PATCH] sinclude board specific make fragment In-Reply-To: Your message of "Thu, 30 Jun 2005 15:35:41 +0200" <20050630133541.9A9E3353A0E@atlas.denx.de> Message-ID: <9571.1120141144@huldra> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 30 Jun 2005 15:35:41 +0200, Wolfgang Denk writes: >> As I said in the description, this allows board specific make targets >> such as "install", or other board specific targets that might need to >> be included in the $(ALL) make variable. >> >> If make targets are placed in the board specific "config.mk", the first >> such target becomes the default make target, instead of "all", which is >> declared later in the main Makefile. > >This is something I don't like. "config.mk" is intended to hold >configration information needd for the make, nothing else. Definitely >no make targets or rules or things like that. Precisely - that is what I was saying. You cannot include targets or rules in the board specific "config.mk" file. >Actually the board specific "config.mk" files might be romved one >day. Umm.. this would be very bad. Why would you want to do that? >> make targets placed in the board specific Makefile can't be called from >> the top level directory. > >Do you reallyneed your own private make targets? I gave two examples - "install", and a target for an image of the "boot page" for our MPC8560 board (which I want to be added to the $(ALL) list). I have others, but they are more trivial. >Then make sure that an appropriate note about the patch being >copyrighted by you and available under GPL is included with your >patch. ... >If you cannot avoid the trailer, then make clear that it does not >apply, please. Fair enough. I will do that in future. Cheers! Murray... -- Murray Jensen, CSIRO Manufacturing & Infra. Tech. Phone: +61 3 9662 7763 Locked Bag No. 9, Preston, Vic, 3072, Australia. Fax: +61 3 9662 7853 Internet: Murray.Jensen at csiro.au To the extent permitted by law, CSIRO does not represent, warrant and/or guarantee that the integrity of this communication has been maintained or that the communication is free of errors, virus, interception or interference. The information contained in this e-mail may be confidential or privileged. Any unauthorised use or disclosure is prohibited. If you have received this e-mail in error, please delete it immediately and notify Murray Jensen on +61 3 9662 7763. Thank you.