public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Martin Schiller <ms@dev.tdt.de>
To: "Camelia Alexandra Groza (OSS)" <camelia.groza@oss.nxp.com>
Cc: u-boot@lists.denx.de, Priyanka Jain <priyanka.jain@nxp.com>
Subject: Re: [PATCH] board: ls1046ardb: force PCI device enumeration
Date: Tue, 23 Nov 2021 07:18:43 +0100	[thread overview]
Message-ID: <95a1a5abb4bd059363a2a89fd52db993@dev.tdt.de> (raw)
In-Reply-To: <VI1PR04MB5807489789A32202D8009FF9F29F9@VI1PR04MB5807.eurprd04.prod.outlook.com>

On 2021-11-22 17:30, Camelia Alexandra Groza (OSS) wrote:
>> -----Original Message-----
>> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Martin 
>> Schiller
>> Sent: Wednesday, November 17, 2021 13:59
>> To: u-boot@lists.denx.de
>> Cc: Martin Schiller <ms@dev.tdt.de>; Priyanka Jain 
>> <priyanka.jain@nxp.com>
>> Subject: [PATCH] board: ls1046ardb: force PCI device enumeration
>> 
>> Commit 045ecf899252 ("configs: enable DM_ETH support for LS1046ARDB")
>> resulted in the PCI bus no longer being implicitly enumerated.
>> 
>> However, this is necessary for the fdt pcie fixups to work.
>> 
>> Therefore, similar to commit 8b6558bd4187 ("board: ls1088ardb:
>> transition to DM_ETH"), pci_init() is now called in the board_init()
>> routine when CONFIG_DM_ETH is active.
>> 
>> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
>> CC: Priyanka Jain <priyanka.jain@nxp.com>
>> ---
>>  board/freescale/ls1046ardb/ls1046ardb.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>> 
>> diff --git a/board/freescale/ls1046ardb/ls1046ardb.c
>> b/board/freescale/ls1046ardb/ls1046ardb.c
>> index 93ef903f29..d0abfe8869 100644
>> --- a/board/freescale/ls1046ardb/ls1046ardb.c
>> +++ b/board/freescale/ls1046ardb/ls1046ardb.c
>> @@ -93,6 +93,10 @@ int board_init(void)
>>  	ppa_init();
>>  #endif
>> 
>> +#if !defined(CONFIG_SYS_EARLY_PCI_INIT) && defined(CONFIG_DM_ETH)
>> +	pci_init();
>> +#endif
>> +
>>  	/* invert AQR105 IRQ pins polarity */
>>  	out_be32(&scfg->intpcr, AQR105_IRQ_MASK);
>> 
> 
> Hi
> 
> Thank you for the patch. A very similar fix is needed for the 
> ls1043ardb board.
> Are you interested to send a patch for that as well?
> 

Hi

Yes, I can do that. But I can't test it due to lack of hardware.

> Acked-by: Camelia Groza <camelia.groza@nxp.com>

  reply	other threads:[~2021-11-23  6:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17 11:59 [PATCH] board: ls1046ardb: force PCI device enumeration Martin Schiller
2021-11-22 16:30 ` Camelia Alexandra Groza (OSS)
2021-11-23  6:18   ` Martin Schiller [this message]
2021-12-06  8:23   ` Priyanka Jain (OSS)
  -- strict thread matches above, loose matches on Subject: below --
2021-11-17  7:02 Martin Schiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95a1a5abb4bd059363a2a89fd52db993@dev.tdt.de \
    --to=ms@dev.tdt.de \
    --cc=camelia.groza@oss.nxp.com \
    --cc=priyanka.jain@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox