public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ron Madrid <ron_madrid@sbcglobal.net>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 4/8] New board SIMPC8313 support: support forbooting from NAND in start.S
Date: Fri, 30 May 2008 16:00:16 -0700 (PDT)	[thread overview]
Message-ID: <967840.20593.qm@web83512.mail.sp1.yahoo.com> (raw)
In-Reply-To: <58A20A281BAF1047B4EAE68DE5C0BDC2C82258@zch01exm21.fsl.freescale.net>

OK.  Thank you for responding, this was my biggest concern.  I tried to talk about what should be
done about this before, but people didn't appear to be very interested.

Is this something that will go into the cpu/mpc83xx/ folder as well?  If you'd like I can strip
out everything that isn't involved in the NAND boot (as far as I know) at see what people think. 
Or is this something that the folks at Freescale would rather do?  Let me know.

Ron
--- Liu Dave <DaveLiu@freescale.com> wrote:

> 
> ---
>  cpu/mpc83xx/start.S |  310
> ++++++++++++++++++++++++++++++++++++---------------
>  1 files changed, 220 insertions(+), 90 deletions(-)
> 
> diff --git a/cpu/mpc83xx/start.S b/cpu/mpc83xx/start.S
> index 309eb30..39bcaa8 100644
> --- a/cpu/mpc83xx/start.S
> +++ b/cpu/mpc83xx/start.S
> @@ -63,6 +63,9 @@
>   * Use r14 to access the GOT
>   */
>  	START_GOT
> +#if defined(CONFIG_NAND_SPL)
> +	GOT_ENTRY(_GOT_TABLE_)
> +#else
>  	GOT_ENTRY(_GOT2_TABLE_)
>  	GOT_ENTRY(_FIXUP_TABLE_)
>  
> @@ -74,6 +77,7 @@
>  	GOT_ENTRY(__init_end)
>  	GOT_ENTRY(_end)
>  	GOT_ENTRY(__bss_start)
> +#endif /* CONFIG_NAND_SPL */
>  	END_GOT
>  
> [Dave] I strongly suggest we create one lite new start.S for the NAND boot,
>        not modify the original start.S
> 

  parent reply	other threads:[~2008-05-30 23:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-30 18:13 [U-Boot-Users] [PATCH 4/8] New board SIMPC8313 support: support for booting from NAND in start.S Ron Madrid
2008-05-30 19:48 ` Kumar Gala
2008-05-30 20:06   ` Ron Madrid
2008-05-30 22:47 ` [U-Boot-Users] [PATCH 4/8] New board SIMPC8313 support: support forbooting " Liu Dave
2008-05-30 22:51   ` Scott Wood
2008-05-30 22:56     ` Liu Dave
2008-05-30 23:11       ` Wolfgang Denk
2008-05-31  6:07     ` Kumar Gala
2008-05-30 23:00   ` Ron Madrid [this message]
2008-05-31  0:47     ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=967840.20593.qm@web83512.mail.sp1.yahoo.com \
    --to=ron_madrid@sbcglobal.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox