public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ajay Bhargav <ajay.bhargav@einfochips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 1/2] gpio: Add GPIO driver framework for Marvell SoCs
Date: Wed, 17 Aug 2011 14:18:16 +0530 (IST)	[thread overview]
Message-ID: <972251876.97297.1313570896449.JavaMail.root@ahm.einfochips.com> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19FE5D25D0@SC-VEXCH4.marvell.com>


----- "Prafulla Wadaskar" <prafulla@marvell.com> wrote:

> Hi Ajay
> I am sorry if I missed this in my earlier reviews.
> 
> Why you wish to keep mvgpio.h in /include folder?
> I think it should be in drivers/gpio/.
> 
> Regards..
> Prafulla . .
> 

Hi Prafulla,

gpio.h includes this file, as GPIO_LEVEL_SET/CLR are defined
in mvgpio.h which may be needed by other files accessing gpios.
In my case I am using gpio for PHY reset. I was thinking not to
keep any magic number 1/0 for set/clr gpio pin.

Regards,
Ajay Bhargav

  reply	other threads:[~2011-08-17  8:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-16  6:01 [U-Boot] [PATCH v6 1/2] gpio: Add GPIO driver framework for Marvell SoCs Ajay Bhargav
2011-08-17  8:39 ` Prafulla Wadaskar
2011-08-17  8:48   ` Ajay Bhargav [this message]
2011-08-17 12:03     ` Prafulla Wadaskar
2011-08-17 12:08       ` Ajay Bhargav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=972251876.97297.1313570896449.JavaMail.root@ahm.einfochips.com \
    --to=ajay.bhargav@einfochips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox